[v2] Fix AIX CI build break.
Checks
Context |
Check |
Description |
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 |
success
|
Build passed
|
linaro-tcwg-bot/tcwg_gdb_build--master-arm |
success
|
Build passed
|
linaro-tcwg-bot/tcwg_gdb_check--master-arm |
success
|
Test passed
|
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 |
fail
|
Patch failed to apply
|
Commit Message
From: KamathForAIX <Aditya.Kamath1@ibm.com>
In AIX a recent commit caused a build break with the error as shown below.
In file included from python/py-color.h:23,
from python/python.c:39:
python/python-internal.h:86:10: fatal error: Python.h: No such file or directory
86 | #include <Python.h>
In AIX, we run builds with and without python for our internal CI's.
A feature development made by the recent commit https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=6447969d0ac774b6dec0f95a0d3d27c27d158690
missed to guard Python.h in HAVE_PYTHON macro.
This commit is a fix for the same.
Requesting approval to commit.
---
gdb/python/python.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
>>>>> Aditya Vidyadhar Kamath <akamath996@gmail.com> writes:
> A feature development made by the recent commit
> https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=6447969d0ac774b6dec0f95a0d3d27c27d158690
> missed to guard Python.h in HAVE_PYTHON macro.
> This commit is a fix for the same.
> Requesting approval to commit.
Thank you, this is ok.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
Thank you.
I have made the commit. https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=127f733f88717bdb52f03c12c0c2d240bbc892e3
Regards,
Aditya.
From: Tom Tromey <tom@tromey.com>
Date: Monday, 13 January 2025 at 8:13 PM
To: Aditya Vidyadhar Kamath <akamath996@gmail.com>
Cc: Ulrich Weigand <Ulrich.Weigand@de.ibm.com>, tom@tromey.com <tom@tromey.com>, gdb-patches@sourceware.org <gdb-patches@sourceware.org>, Aditya Kamath <Aditya.Kamath1@ibm.com>, SANGAMESH MALLAYYA <sangamesh.swamy@in.ibm.com>
Subject: [EXTERNAL] Re: [PATCH v2] Fix AIX CI build break.
>>>>> Aditya Vidyadhar Kamath <akamath996@gmail.com> writes:
> A feature development made by the recent commit
> https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=6447969d0ac774b6dec0f95a0d3d27c27d158690
> missed to guard Python.h in HAVE_PYTHON macro.
> This commit is a fix for the same.
> Requesting approval to commit.
Thank you, this is ok.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
@@ -36,7 +36,6 @@
#include "run-on-main-thread.h"
#include "observable.h"
#include "build-id.h"
-#include "py-color.h"
#if GDB_SELF_TEST
#include "gdbsupport/selftest.h"
@@ -78,6 +77,7 @@ static const char *gdbpy_should_print_stack = python_excp_message;
#include "interps.h"
#include "event-top.h"
#include "py-event.h"
+#include "py-color.h"
/* True if Python has been successfully initialized, false
otherwise. */