Message ID | 20250113044351.45450-1-akamath996@gmail.com |
---|---|
State | New |
Headers |
Return-Path: <gdb-patches-bounces~patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E6BF03857823 for <patchwork@sourceware.org>; Mon, 13 Jan 2025 04:46:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E6BF03857823 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=hcFz+1wn X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id CE3673858D26 for <gdb-patches@sourceware.org>; Mon, 13 Jan 2025 04:45:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CE3673858D26 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CE3673858D26 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736743550; cv=none; b=hhr4m1WhVwZsd/hSQEE390YpUX6YcHUJoI+EnEwx23/qfRKhr0gqquMAG50/FjBDBjJlz4XnQPJlXvGjQHEBz3M3hEMWxO3JouDWKiyIfGAEH297fEiRxIQFLbFDPDSu3Aqb9aOvjCYa5LxZ9k1YK287CUTOvGtlwTQbJtpzbnY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736743550; c=relaxed/simple; bh=pw8c7omvHTZtFwBB5oC3Xe2b624YbKP6xmy7zIkOOyw=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=DgaRLMmyeTSJkz61B/IEPNePJMUo4vHi5c3DL1CTva9ic4LVvCyu1k9Iy9p2+k42lxvwbN0UQzSZNkxE7VO9B4g9F45mSU3PSiX3/ebJ9K3JFhn5DDJV+yF2SZ1MZXEQl/7IKyr9h5gy0ujAn+ckNo9GQJ/wELVyRjMY+jE7ZA8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CE3673858D26 Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-21628b3fe7dso62946895ad.3 for <gdb-patches@sourceware.org>; Sun, 12 Jan 2025 20:45:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736743549; x=1737348349; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=DkuYUpoKNLVa5QG2SmCwuiDpOqIkrGeO3FN2pNsJh10=; b=hcFz+1wnpwZnrDlSqCSUL57gCVK8YIQOvQ4XJnm/Vdo+7ystM/Mne9nyFoFDxexHYo 9Q7ddDn895VDauAf0osZ7OrRLAvZ0mIjB4s0y6WY3tYCzdliN3k5eeHGWzvCSoXUlN3V sOmleQfXJipRnJp9V6eVbcyvVYmhTLW1cNZ/Hpn+VbATU/uTgFqmTg70SBwmaFZXtuiy 6VWDylXOiCH1lm59HgdZBNr45A/l/Th95uRBtIp31ZS9GrwRpxMEXvAaX+EaU/Ex7uwr RmniTk0kFt+JrlrxD93Co6bOvReesf2drkResJNrleCXIPEkLOYUChX9xunATou7T446 euUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736743549; x=1737348349; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DkuYUpoKNLVa5QG2SmCwuiDpOqIkrGeO3FN2pNsJh10=; b=mS3UnZPAyT2ahoDciv11qhQdE7ysnZEqqfCwGLuwDJr3Qf0inJPt4hiSGafGbYq13H kBui+6JrJUZ1FqspZbz0tGAJdZxcabopwyMbaCWhjqkeN/5y6HfBFZ+FpVRkExKN45AV QMqx2EfTpm5OM/RdMSUMeCoL9gHdv/oXAmlUnuoKYzMs01LsL3axm/B/xn6D6ZkVeUTO 08cK9P5DBTZj45+icvZUHebbjy0HlTXKlwH/+xk32aPWcyKuOG7modHBPGB5F6OfML0I aQqy4SuEFMrPeg7qcu/drSG/UOOsfwyII8grZhNADLJQpQ/4aGgUXMGgFcYlGyiQGEXc 1qzQ== X-Gm-Message-State: AOJu0YxZ9jH0Tc0t4aplLJhSmDrnBJ6gBo++1m0D+LcE0AP38PQbmlmr PAgMK39ZyOa/TdWYUfCta6zCzTDAjS+RxmZeKzxBOFAVV3AqunbN X-Gm-Gg: ASbGnctywGIfKqO/x6DEM9oMVLPj+T8EhZN1zEcEMMwxiDxAnTH7mvMDoezkyrEPhSP Jqc1T6wWnG8zSjY+6dAnJlwlbhwH6EyreGr8Zn3LfL9oyhD9sL5dT+ZAqpusFrQGf645yDRemFQ 7drcxkVWNuzDN/F6g/heV2vDev/Y4FdRPes8vsjmjoIXz1MMYiCLxIozjMlSNPnmUeqwLyR2YlB 49HQnRW9SO6oicW2Et6/14bFI76JzoAZCfu6w1TVO0Vvkz9kudTp+TUDns9LXBse7ro5T5dG2ov Eb85NA== X-Google-Smtp-Source: AGHT+IFgnASoqEtbxk39qWf8xi63yDKcwWm0nPwATtoVZ5cH/TrmuydkrtjhCibrT1QthSdZ59gM4Q== X-Received: by 2002:a05:6a00:1152:b0:72a:bcc2:eefb with SMTP id d2e1a72fcca58-72d21f115bfmr25784448b3a.2.1736743548626; Sun, 12 Jan 2025 20:45:48 -0800 (PST) Received: from localhost.localdomain ([122.171.18.176]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72d40548489sm5248777b3a.15.2025.01.12.20.45.46 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 12 Jan 2025 20:45:48 -0800 (PST) From: Aditya Vidyadhar Kamath <akamath996@gmail.com> To: ulrich.weigand@de.ibm.com, tom@tromey.com Cc: gdb-patches@sourceware.org, Aditya.Kamath1@ibm.com, sangamesh.swamy@in.ibm.com Subject: [PATCH] Fix AIX CI build break. Date: Mon, 13 Jan 2025 10:13:52 +0530 Message-Id: <20250113044351.45450-1-akamath996@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_ABUSEAT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=subscribe> Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org |
Series |
Fix AIX CI build break.
|
|
Checks
Context | Check | Description |
---|---|---|
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 | success | Build passed |
linaro-tcwg-bot/tcwg_gdb_build--master-arm | success | Build passed |
linaro-tcwg-bot/tcwg_gdb_check--master-arm | success | Test passed |
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 | success | Test passed |
Commit Message
Aditya Vidyadhar Kamath
Jan. 13, 2025, 4:43 a.m. UTC
From: KamathForAIX <Aditya.Kamath1@ibm.com>
In AIX a recent commit caused a build break with the error as shown below.
In file included from python/py-color.h:23,
from python/python.c:39:
python/python-internal.h:86:10: fatal error: Python.h: No such file or directory
86 | #include <Python.h>
In AIX, we run builds with and without python for our internal CI's.
A feature development made by the recent commit https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=6447969d0ac774b6dec0f95a0d3d27c27d158690
missed to guard Python.h in HAVE_PYTHON macro.
This commit is a fix for the same.
---
gdb/python/python.c | 3 +++
1 file changed, 3 insertions(+)
Comments
>>>>> Aditya Vidyadhar Kamath <akamath996@gmail.com> writes: > A feature development made by the recent commit > https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=6447969d0ac774b6dec0f95a0d3d27c27d158690 > missed to guard Python.h in HAVE_PYTHON macro. > This commit is a fix for the same. Sorry about that. > + > +#ifdef HAVE_PYTHON > #include "py-color.h" > +#endif /* HAVE_PYTHON */ Rather than a new #ifdef, could you just move the #include into the already-existing #ifdef block? Thanks. Tom
Hi Tom, >Rather than a new #ifdef, could you just move the #include into the >already-existing #ifdef block? Thanks. Thank you for noticing. I had missed it. I have made the change and sent a v2 of the patch requesting approval to commit. Have a nice day ahead. Regards, Aditya. From: Tom Tromey <tom@tromey.com> Date: Monday, 13 January 2025 at 2:38 PM To: Aditya Vidyadhar Kamath <akamath996@gmail.com> Cc: Ulrich Weigand <Ulrich.Weigand@de.ibm.com>, tom@tromey.com <tom@tromey.com>, gdb-patches@sourceware.org <gdb-patches@sourceware.org>, Aditya Kamath <Aditya.Kamath1@ibm.com>, SANGAMESH MALLAYYA <sangamesh.swamy@in.ibm.com> Subject: [EXTERNAL] Re: [PATCH] Fix AIX CI build break. >>>>> Aditya Vidyadhar Kamath <akamath996@gmail.com> writes: > A feature development made by the recent commit > https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=6447969d0ac774b6dec0f95a0d3d27c27d158690 > missed to guard Python.h in HAVE_PYTHON macro. > This commit is a fix for the same. Sorry about that. > + > +#ifdef HAVE_PYTHON > #include "py-color.h" > +#endif /* HAVE_PYTHON */ Rather than a new #ifdef, could you just move the #include into the already-existing #ifdef block? Thanks. Tom
diff --git a/gdb/python/python.c b/gdb/python/python.c index 15bb9129739..f647e6aaf4c 100644 --- a/gdb/python/python.c +++ b/gdb/python/python.c @@ -36,7 +36,10 @@ #include "run-on-main-thread.h" #include "observable.h" #include "build-id.h" + +#ifdef HAVE_PYTHON #include "py-color.h" +#endif /* HAVE_PYTHON */ #if GDB_SELF_TEST #include "gdbsupport/selftest.h"