From patchwork Sun Jan 12 12:04:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 104608 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B6EF23857810 for ; Sun, 12 Jan 2025 12:07:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B6EF23857810 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=rD2vOMcu X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id C74B93858432 for ; Sun, 12 Jan 2025 12:04:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C74B93858432 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C74B93858432 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736683448; cv=none; b=u7pf1dQM8koHJRJl6DFLhgDXEwGRGBeQkd/x1PE6ccrL+yKB9WsWOTubAHv+0DcO2iHrkq/ZMRZlHRUqwuybCuFEPanin0fjRJOjhubrU4m5Ypbv+dzSXFOxwKpCdNhAPHL8Stu/Y/+xuYxgjP0vNuatn0SdZvAd2giVRSt/s4c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736683448; c=relaxed/simple; bh=Gsi128RMOxfrjRvAfv0WXpufQf22U26HkWq2qCX8Ka8=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=rTHPV5fJ/c2ntqfiQZHNi8xdjUqVJRm+tznYLr75ocAZcsB3hVAzIHpzTV10Q9eNGQZEcDZ7y7CzWU3vDduDpc174DPD1TG7wiHq0g0PXPVBEVuL5264ytc04UipbvacDZZznYy49pXqdDES3WvjJDyytXKRHv0LRZWl/03lFl0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C74B93858432 Received: from eig-obgw-6008a.ext.cloudfilter.net ([10.0.30.227]) by cmsmtp with ESMTPS id WstAtD74Sdz4NWwhMta5cU; Sun, 12 Jan 2025 12:04:08 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id WwhLtTwgiEzLqWwhLtsilM; Sun, 12 Jan 2025 12:04:07 +0000 X-Authority-Analysis: v=2.4 cv=XrX8O0F9 c=1 sm=1 tr=0 ts=6783afb7 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=VdSt8ZQiCzkA:10 a=ItBw4LHWJt0A:10 a=hSKR3ATKOvzw1NKbuRMA:9 a=QEXdDO2ut3YA:10 a=6Ogn3jAGHLSNbaov7Orx:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Cc:To:In-Reply-To:References:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Y+tIvA8VAWeLYWX512/VzCOTde4/7/OpgeI2YRRku/M=; b=rD2vOMcuLAtofSTSWrTsTRejGS mvYKus/X2JxwH6xueg8hXR/G35jK+3Si+B5NTAOXRHVgpyKv0UdvfkXvqcIrPfLSuvFN9bvo9bdQK aVSmkiLJ8dINsNUcf3xpNLpe7; Received: from 97-118-36-154.hlrn.qwest.net ([97.118.36.154]:46946 helo=prentzel.local) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1tWwhL-00212c-0R; Sun, 12 Jan 2025 05:04:07 -0700 From: Tom Tromey Date: Sun, 12 Jan 2025 05:04:00 -0700 Subject: [PATCH 3/4] Remove "enabled" output from show_index_cache_command MIME-Version: 1.0 Message-Id: <20250112-submit-help-list-style-title-v1-3-9457a2686440@tromey.com> References: <20250112-submit-help-list-style-title-v1-0-9457a2686440@tromey.com> In-Reply-To: <20250112-submit-help-list-style-title-v1-0-9457a2686440@tromey.com> To: gdb-patches@sourceware.org Cc: Tom Tromey X-Mailer: b4 0.14.2 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.36.154 X-Source-L: No X-Exim-ID: 1tWwhL-00212c-0R X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-36-154.hlrn.qwest.net (prentzel.local) [97.118.36.154]:46946 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfGH1ltG3DSoL0dd1LIe9MR+U2X7ypObsCn/QP6NRYkwKlYMQc+qSh0Ry8mbhtOTUPRSfYPFMkGB6podm2ZWOHAo+rRG1nFCHdYCf1o5713RMet5gWxy2 qU40v8ERVBJ5p++Qtz6e+/Xx9IVNXGiVL1dfet2Y9k9w3HeM1dwUA52Urtk9iajj1fnnGWhpZtf8KGc5DbYezxrYhBwDUXXTeTE= X-Spam-Status: No, score=-3019.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org show_index_cache_command prints whether the index-cache is enabled. This text was added back in 2018 in commit 87d6a7aa (Add DWARF index cache). Then in 2021, the enabling option was changed via commit 7bc5c369 (gdb: introduce "set index-cache enabled", deprecate "set index-cache on/off"). This latter change made this output, IMO, redundant. That is, currently gdb will show: (gdb) show index-cache ... index-cache enabled: The index cache is off. ... The index cache is currently disabled. This patch removes the redundant output. --- gdb/dwarf2/index-cache.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/gdb/dwarf2/index-cache.c b/gdb/dwarf2/index-cache.c index a04d5d662d883f582064c7df17e76b8b619d9a58..d34abf373f8a5b15efdcf3c847b27b39b71e4c7b 100644 --- a/gdb/dwarf2/index-cache.c +++ b/gdb/dwarf2/index-cache.c @@ -280,11 +280,6 @@ show_index_cache_command (const char *arg, int from_tty) /* Call all "show index-cache" subcommands. */ cmd_show_list (show_index_cache_prefix_list, from_tty); - - gdb_printf ("\n"); - gdb_printf - (_("The index cache is currently %s.\n"), - global_index_cache.enabled () ? _("enabled") : _("disabled")); } /* "set/show index-cache enabled" set callback. */