From patchwork Fri Jan 10 16:43:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thiago Jung Bauermann X-Patchwork-Id: 104500 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C60D93858289 for ; Fri, 10 Jan 2025 16:45:28 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-vk1-xa36.google.com (mail-vk1-xa36.google.com [IPv6:2607:f8b0:4864:20::a36]) by sourceware.org (Postfix) with ESMTPS id D9E733858401 for ; Fri, 10 Jan 2025 16:44:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D9E733858401 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D9E733858401 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::a36 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736527477; cv=none; b=d7ZEiJCDYm94ghlaPTI8CcATb8SbeFVDQerouTYug1+Rhis8pPt5dVSt0cC/89i8PxP+wMDvUysl6rkdSQtlao940oufuv5Tz/Lb8d/Fav6aReTBIUrKJfHKbWLWd6XnlZsGPD/AALdTb/7Z824AG5qPw41C2dlojEd3BJtGe5g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736527477; c=relaxed/simple; bh=5OY6L6dvILKOBfnwW5jeYggp5U+9ywdRz+OUQlRdXIg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=j2OkFL5HERnhoOkJH+YfOiabe4XTvTcFAxY3W4lOJxGQpoMaPM1/9Ba+T7DduUCrrEWEwrry6+8o5utr86SG9zDXGbGHx9Gfpl2Rwi9Zl8qo1hALpAlvfBdlpRmlzNJepe5xjWRcTi/Du3R2oCUI90oVBgLYlRVXFNxSDkyULGc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-vk1-xa36.google.com with SMTP id 71dfb90a1353d-5188b485988so772539e0c.3 for ; Fri, 10 Jan 2025 08:44:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736527477; x=1737132277; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9WMH9pe8J9opOlrEsZc1XAkeL6cecbx99LA9Ybn3z3U=; b=WHg6fqdHT6pRsX2uM2of1uhA4mD7wm3ZuH5iKsyn0HpidEuqsCG3NJ1apPa0xc1Jew PpjLqnwE6WokrZy9IXIMQUKcd2RJHNFqD08PRVNsWNGKB/0S/IbBBYUmSKZXxnZ25JtF SPxkQL5xiceiOtxYYOwe8d/xVqKX1Z5LVxrrJyOaFmVK8TO5crtDIXepqNfYObo7UZsD H9JVsaAYoCN32U94H6lv7KnT2ZHGa0pX/jJI3AsC7/BDwSy5pQ1kToj0Ce4IbE9U4bjY 1hSEMoKp95vLIYbHJZXTVCR4KaKbZYjAz+oXVDTzm2pIaIi3GzM68JVSh20AApXka6XC ZxAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736527477; x=1737132277; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9WMH9pe8J9opOlrEsZc1XAkeL6cecbx99LA9Ybn3z3U=; b=L7Bqww25oHLQD2D3gezujDqMjpUQVf00es3sYRRS7gI28L7ij0WsAW64/ia4eBIl8O MCs28XV4sAruSsd3V4M63C/5XOqu7JqgMpD4anaHl1ElDdGjuNyXysDycawK0spp/2Vh shClEvdnUY40BKbAsxwlISXpjW/7h0R1onz83jWT76oA57xBi+e4L4shAPg0l2f7nBUj b0SVAHjdUbgRblkj/AL/tWa36pGCQUpXxFiZa8IPfV6mqGf7RzEu/MVc+oaAURMOv3NA 6lPxOKTmU9krmbYwMsiNCpMx6cKl5rCnnZoDzGG9rMkOYvdggtt1zOqoXeWQrgS7O9VH 2igg== X-Gm-Message-State: AOJu0YwMi+b0WxMOAkGZKxpFDVAItE9XsAeVyQvxaRm/fidksPuHn8Jm sKzIwi0W35SEqPIC3X4Y/JFQpSflMZ1HX82D/dkKlFOEqx+XeqkQijDJh7ZXpfhXidkWuNSokiB i X-Gm-Gg: ASbGnculDJK4Fs+KZPwkmgiyINg2sERCjWHpjTadyvgz+Nqx9/lT9ST4WgYmpdfedHy r9ny/9EmSaMg09MYfgtYedueD4FOA3tQVifmhThhBZ6clMjFq2uGOAp5AIBfmCtZnwBPyf1VDv6 +O5xJjtIcRg9vS9X+72tCEpfC41kfOwqZ0A4rQoEbRE191grifjt/4OZJgOKnZy/PRZTWCcpDoA RI/NSp+VtsAqJ3hUXoLrQriNn7/gIdTfkR2Nz+BUVpWfi2f7t1mhKbBPMFHubwSMA== X-Google-Smtp-Source: AGHT+IFbHahnn5Xpvl411z3pjWc/MrNTfvG4nA7b6swKm8fiKpyw23D34NVmwvXF/0nUqy1w/Fcl1Q== X-Received: by 2002:a05:6122:2207:b0:518:d26a:a819 with SMTP id 71dfb90a1353d-51c6c2b7b50mr10666397e0c.0.1736527477128; Fri, 10 Jan 2025 08:44:37 -0800 (PST) Received: from localhost ([2804:14d:7e39:8470:1b99:f53f:5bf8:21c]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-51c7fbfdc39sm2328133e0c.22.2025.01.10.08.44.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jan 2025 08:44:36 -0800 (PST) From: Thiago Jung Bauermann To: gdb-patches@sourceware.org Cc: "Aktemur, Tankut Baris" , Simon Marchi , "Maciej W. Rozycki" Subject: [PATCH 1/2] GDB: frame: Make VALUEP argument optional in frame_register_unwind Date: Fri, 10 Jan 2025 13:43:59 -0300 Message-ID: <20250110164430.3376697-2-thiago.bauermann@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250110164430.3376697-1-thiago.bauermann@linaro.org> References: <20250110164430.3376697-1-thiago.bauermann@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org It already accepts a nullptr value and a couple of places were always calling it that way, so make it possible to omit the argument entirely. --- gdb/frame.c | 4 ++-- gdb/frame.h | 4 ++-- gdb/stack.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/gdb/frame.c b/gdb/frame.c index a6900b280724..ba4a07179f64 100644 --- a/gdb/frame.c +++ b/gdb/frame.c @@ -1447,7 +1447,7 @@ put_frame_register (const frame_info_ptr &next_frame, int regnum, gdb_assert (buf.size () == size); frame_register_unwind (next_frame, regnum, &optim, &unavail, &lval, &addr, - &realnum, nullptr); + &realnum); if (optim) error (_("Attempt to assign to a register that was not saved.")); switch (lval) @@ -2159,7 +2159,7 @@ frame_register_unwind_location (const frame_info_ptr &initial_this_frame, int unavailable; frame_register_unwind (this_frame, regnum, optimizedp, &unavailable, - lvalp, addrp, realnump, NULL); + lvalp, addrp, realnump); if (*optimizedp) break; diff --git a/gdb/frame.h b/gdb/frame.h index 9b41dd958fa4..b265c9bc5bb3 100644 --- a/gdb/frame.h +++ b/gdb/frame.h @@ -685,14 +685,14 @@ const char *unwind_stop_reason_to_string (enum unwind_stop_reason); const char *frame_stop_reason_string (const frame_info_ptr &); /* Unwind the stack frame so that the value of REGNUM, in the previous - (up, older) frame is returned. If VALUEP is NULL, don't + (up, older) frame is returned. If VALUEP is nullptr, don't fetch/compute the value. Instead just return the location of the value. */ extern void frame_register_unwind (const frame_info_ptr &frame, int regnum, int *optimizedp, int *unavailablep, enum lval_type *lvalp, CORE_ADDR *addrp, int *realnump, - gdb_byte *valuep); + gdb_byte *valuep = nullptr); /* Fetch a register from this, or unwind a register from the next frame. Note that the get_frame methods are wrappers to diff --git a/gdb/stack.c b/gdb/stack.c index 73165c801343..2d6712ab16ba 100644 --- a/gdb/stack.c +++ b/gdb/stack.c @@ -1750,7 +1750,7 @@ info_frame_command_core (const frame_info_ptr &fi, bool selected_frame_p) /* Find out the location of the saved register without fetching the corresponding value. */ frame_register_unwind (fi, i, &optimized, &unavailable, - &lval, &addr, &realnum, NULL); + &lval, &addr, &realnum); /* For moment, only display registers that were saved on the stack. */ if (!optimized && !unavailable && lval == lval_memory)