diff mbox series

Make rs6000-tdep.c:variants 'const'

Message ID 20241210195417.1308894-1-tromey@adacore.com
State New
Headers
Series Make rs6000-tdep.c:variants 'const' |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 success Build passed
linaro-tcwg-bot/tcwg_gdb_build--master-arm success Build passed
linaro-tcwg-bot/tcwg_gdb_check--master-arm success Test passed
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 success Test passed

Commit Message

Tom Tromey Dec. 10, 2024, 7:54 p.m. UTC 
  I noticed that rs6000-tdep.c has a global "variants" array that can be
marked "const", moving it into rodata.
---
 gdb/rs6000-tdep.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andrew Burgess Dec. 12, 2024, 10:29 a.m. UTC | #1 
Tom Tromey <tromey@adacore.com> writes:

> I noticed that rs6000-tdep.c has a global "variants" array that can be
> marked "const", moving it into rodata.

Makes sense.

Approved-By: Andrew Burgess <aburgess@redhat.com>

Thanks,
Andrew

> ---
>  gdb/rs6000-tdep.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c
> index a36c337c625..fa4fb50fa7b 100644
> --- a/gdb/rs6000-tdep.c
> +++ b/gdb/rs6000-tdep.c
> @@ -3528,7 +3528,7 @@ struct ppc_variant
>      const struct target_desc **tdesc;
>    };
>  
> -static struct ppc_variant variants[] =
> +static const ppc_variant variants[] =
>  {
>    {"powerpc", "PowerPC user-level", bfd_arch_powerpc,
>     bfd_mach_ppc, &tdesc_powerpc_altivec32},
> -- 
> 2.47.0
diff mbox series

Patch

diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c
index a36c337c625..fa4fb50fa7b 100644
--- a/gdb/rs6000-tdep.c
+++ b/gdb/rs6000-tdep.c
@@ -3528,7 +3528,7 @@  struct ppc_variant
     const struct target_desc **tdesc;
   };
 
-static struct ppc_variant variants[] =
+static const ppc_variant variants[] =
 {
   {"powerpc", "PowerPC user-level", bfd_arch_powerpc,
    bfd_mach_ppc, &tdesc_powerpc_altivec32},