diff mbox series

[v2,2/2] mangle_style: Add new DWARF5 constants

Message ID 20241209162531.657914-2-ahajkova@redhat.com
State New
Headers
Series [v2,1/2] dwarf_lang_to_enum_language: Map new DWARF5 constants |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 fail Patch failed to apply
linaro-tcwg-bot/tcwg_gdb_build--master-arm fail Patch failed to apply

Commit Message

Alexandra Hájková Dec. 9, 2024, 4:25 p.m. UTC 
  Update bfd/dwarf2.c with the new DWARF5 language codes to
make it possible to return the mangling style for the new
language codes for Ada 2005 and 20015, Fortran 18 and 23,
C++ 20 and 23, C 17 and 23 and Assembly.
---
 bfd/dwarf2.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Tom Tromey Dec. 9, 2024, 8 p.m. UTC | #1 
>>>>> Alexandra Hájková <ahajkova@redhat.com> writes:

> Update bfd/dwarf2.c with the new DWARF5 language codes to
> make it possible to return the mangling style for the new
> language codes for Ada 2005 and 20015, Fortran 18 and 23,
> C++ 20 and 23, C 17 and 23 and Assembly.

Patches to BFD should go to the binutils list.
While I think this is fine, I can't approve it.

thanks,
Tom
Andrew Burgess Dec. 10, 2024, 8:37 a.m. UTC | #2 
Alexandra Hájková <ahajkova@redhat.com> writes:

> Update bfd/dwarf2.c with the new DWARF5 language codes to
> make it possible to return the mangling style for the new
> language codes for Ada 2005 and 20015, Fortran 18 and 23,
> C++ 20 and 23, C 17 and 23 and Assembly.

This patch needs to go to: binutils@sourceware.org which is where
changes to bfd/ get approved.  But this looks good to me.

Reviewed-By: Andrew Burgess <aburgess@redhat.com>

Thanks,
Andrew


> ---
>  bfd/dwarf2.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/bfd/dwarf2.c b/bfd/dwarf2.c
> index 151ed0237ca..46f82d4c0f4 100644
> --- a/bfd/dwarf2.c
> +++ b/bfd/dwarf2.c
> @@ -1725,12 +1725,17 @@ mangle_style (int lang)
>      {
>      case DW_LANG_Ada83:
>      case DW_LANG_Ada95:
> +    case DW_LANG_Ada2005:
> +    case DW_LANG_Ada2012:
>        return DMGL_GNAT;
>  
>      case DW_LANG_C_plus_plus:
>      case DW_LANG_C_plus_plus_03:
>      case DW_LANG_C_plus_plus_11:
>      case DW_LANG_C_plus_plus_14:
> +    case DW_LANG_C_plus_plus_17:
> +    case DW_LANG_C_plus_plus_20:
> +    case DW_LANG_C_plus_plus_23:
>        return DMGL_GNU_V3;
>  
>      case DW_LANG_Java:
> @@ -1751,12 +1756,17 @@ mangle_style (int lang)
>      case DW_LANG_Cobol74:
>      case DW_LANG_Cobol85:
>      case DW_LANG_Fortran77:
> +    case DW_LANG_Fortran18:
> +    case DW_LANG_Fortran23:
>      case DW_LANG_Pascal83:
>      case DW_LANG_PLI:
>      case DW_LANG_C99:
>      case DW_LANG_UPC:
>      case DW_LANG_C11:
> +    case DW_LANG_C17:
> +    case DW_LANG_C23:
>      case DW_LANG_Mips_Assembler:
> +    case DW_LANG_Assembly:
>      case DW_LANG_Upc:
>      case DW_LANG_HP_Basic91:
>      case DW_LANG_HP_IMacro:
> -- 
> 2.47.0
diff mbox series

Patch

diff --git a/bfd/dwarf2.c b/bfd/dwarf2.c
index 151ed0237ca..46f82d4c0f4 100644
--- a/bfd/dwarf2.c
+++ b/bfd/dwarf2.c
@@ -1725,12 +1725,17 @@  mangle_style (int lang)
     {
     case DW_LANG_Ada83:
     case DW_LANG_Ada95:
+    case DW_LANG_Ada2005:
+    case DW_LANG_Ada2012:
       return DMGL_GNAT;
 
     case DW_LANG_C_plus_plus:
     case DW_LANG_C_plus_plus_03:
     case DW_LANG_C_plus_plus_11:
     case DW_LANG_C_plus_plus_14:
+    case DW_LANG_C_plus_plus_17:
+    case DW_LANG_C_plus_plus_20:
+    case DW_LANG_C_plus_plus_23:
       return DMGL_GNU_V3;
 
     case DW_LANG_Java:
@@ -1751,12 +1756,17 @@  mangle_style (int lang)
     case DW_LANG_Cobol74:
     case DW_LANG_Cobol85:
     case DW_LANG_Fortran77:
+    case DW_LANG_Fortran18:
+    case DW_LANG_Fortran23:
     case DW_LANG_Pascal83:
     case DW_LANG_PLI:
     case DW_LANG_C99:
     case DW_LANG_UPC:
     case DW_LANG_C11:
+    case DW_LANG_C17:
+    case DW_LANG_C23:
     case DW_LANG_Mips_Assembler:
+    case DW_LANG_Assembly:
     case DW_LANG_Upc:
     case DW_LANG_HP_Basic91:
     case DW_LANG_HP_IMacro: