diff mbox series

[2/2] mangle_style: Add new DWARF5 constants

Message ID 20241209102116.612361-2-ahajkova@redhat.com
State New
Headers
Series [1/2] dwarf_lang_to_enum_language: Map new DWARF5 constants |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 fail Patch failed to apply
linaro-tcwg-bot/tcwg_gdb_build--master-arm fail Patch failed to apply

Commit Message

Alexandra Hájková Dec. 9, 2024, 10:20 a.m. UTC 
  Update bfd/dwarf2.c with the new DWARF5 language codes to
make it possible to return the mangling style for the new
language codes for Ada 2005 and 20015, Fortran 18 and 23,
C++ 20 and 23, C 17 and 23 and Assembly.
---
 bfd/dwarf2.c | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Rohr, Stephan Dec. 9, 2024, 10:51 a.m. UTC | #1 
Hi Alexandra,

just a small nit.

Stephan

> -----Original Message-----
> From: Alexandra Hájková <ahajkova@redhat.com>
> Sent: Monday, 9 December 2024 11:21
> To: gdb-patches@sourceware.org
> Cc: ahajkova@redhat.com
> Subject: [PATCH 2/2] mangle_style: Add new DWARF5 constants
> 
> Update bfd/dwarf2.c with the new DWARF5 language codes to
> make it possible to return the mangling style for the new
> language codes for Ada 2005 and 20015, Fortran 18 and 23,
> C++ 20 and 23, C 17 and 23 and Assembly.
> ---
>  bfd/dwarf2.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/bfd/dwarf2.c b/bfd/dwarf2.c
> index 151ed0237ca..ec298764c8a 100644
> --- a/bfd/dwarf2.c
> +++ b/bfd/dwarf2.c
> @@ -1725,12 +1725,16 @@ mangle_style (int lang)
>      {
>      case DW_LANG_Ada83:
>      case DW_LANG_Ada95:
> +    case DW_LANG_Ada2005:
> +    case DW_LANG_Ada2012:
>        return DMGL_GNAT;
> 
>      case DW_LANG_C_plus_plus:
>      case DW_LANG_C_plus_plus_03:
>      case DW_LANG_C_plus_plus_11:
>      case DW_LANG_C_plus_plus_14:
> +    case DW_LANG_C_plus_plus_20:
> +    case DW_LANG_C_plus_plus_23:
>        return DMGL_GNU_V3;
> 

Should we add `DW_LANG_C_plus_plus_17`, too?

>      case DW_LANG_Java:
> @@ -1751,12 +1755,17 @@ mangle_style (int lang)
>      case DW_LANG_Cobol74:
>      case DW_LANG_Cobol85:
>      case DW_LANG_Fortran77:
> +    case DW_LANG_Fortran18:
> +    case DW_LANG_Fortran23:
>      case DW_LANG_Pascal83:
>      case DW_LANG_PLI:
>      case DW_LANG_C99:
>      case DW_LANG_UPC:
>      case DW_LANG_C11:
> +    case DW_LANG_C17:
> +    case DW_LANG_C23:
>      case DW_LANG_Mips_Assembler:
> +    case DW_LANG_Assembly:
>      case DW_LANG_Upc:
>      case DW_LANG_HP_Basic91:
>      case DW_LANG_HP_IMacro:
> --
> 2.47.0

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
Alexandra Hájková Dec. 9, 2024, 3:37 p.m. UTC | #2 
On Mon, Dec 9, 2024 at 11:51 AM Rohr, Stephan <stephan.rohr@intel.com>
wrote:

> Hi Alexandra,
>
> just a small nit.
>
> Stephan
>
> > -----Original Message-----
> > From: Alexandra Hájková <ahajkova@redhat.com>
> > Sent: Monday, 9 December 2024 11:21
> > To: gdb-patches@sourceware.org
> > Cc: ahajkova@redhat.com
> > Subject: [PATCH 2/2] mangle_style: Add new DWARF5 constants
> >
> > Update bfd/dwarf2.c with the new DWARF5 language codes to
> > make it possible to return the mangling style for the new
> > language codes for Ada 2005 and 20015, Fortran 18 and 23,
> > C++ 20 and 23, C 17 and 23 and Assembly.
> > ---
> >  bfd/dwarf2.c | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> > diff --git a/bfd/dwarf2.c b/bfd/dwarf2.c
> > index 151ed0237ca..ec298764c8a 100644
> > --- a/bfd/dwarf2.c
> > +++ b/bfd/dwarf2.c
> > @@ -1725,12 +1725,16 @@ mangle_style (int lang)
> >      {
> >      case DW_LANG_Ada83:
> >      case DW_LANG_Ada95:
> > +    case DW_LANG_Ada2005:
> > +    case DW_LANG_Ada2012:
> >        return DMGL_GNAT;
> >
> >      case DW_LANG_C_plus_plus:
> >      case DW_LANG_C_plus_plus_03:
> >      case DW_LANG_C_plus_plus_11:
> >      case DW_LANG_C_plus_plus_14:
> > +    case DW_LANG_C_plus_plus_20:
> > +    case DW_LANG_C_plus_plus_23:
> >        return DMGL_GNU_V3;
> >
>
> Should we add `DW_LANG_C_plus_plus_17`, too?
>
> You re absolutely right, I forgot to add it.
>

Thank you!
diff mbox series

Patch

diff --git a/bfd/dwarf2.c b/bfd/dwarf2.c
index 151ed0237ca..ec298764c8a 100644
--- a/bfd/dwarf2.c
+++ b/bfd/dwarf2.c
@@ -1725,12 +1725,16 @@  mangle_style (int lang)
     {
     case DW_LANG_Ada83:
     case DW_LANG_Ada95:
+    case DW_LANG_Ada2005:
+    case DW_LANG_Ada2012:
       return DMGL_GNAT;
 
     case DW_LANG_C_plus_plus:
     case DW_LANG_C_plus_plus_03:
     case DW_LANG_C_plus_plus_11:
     case DW_LANG_C_plus_plus_14:
+    case DW_LANG_C_plus_plus_20:
+    case DW_LANG_C_plus_plus_23:
       return DMGL_GNU_V3;
 
     case DW_LANG_Java:
@@ -1751,12 +1755,17 @@  mangle_style (int lang)
     case DW_LANG_Cobol74:
     case DW_LANG_Cobol85:
     case DW_LANG_Fortran77:
+    case DW_LANG_Fortran18:
+    case DW_LANG_Fortran23:
     case DW_LANG_Pascal83:
     case DW_LANG_PLI:
     case DW_LANG_C99:
     case DW_LANG_UPC:
     case DW_LANG_C11:
+    case DW_LANG_C17:
+    case DW_LANG_C23:
     case DW_LANG_Mips_Assembler:
+    case DW_LANG_Assembly:
     case DW_LANG_Upc:
     case DW_LANG_HP_Basic91:
     case DW_LANG_HP_IMacro: