diff mbox series

[2/2,gdb/testsuite] Fix DUPLICATE in gdb.arch/pr25124.exp

Message ID 20241129160939.24045-3-tdevries@suse.de
State Committed
Headers
Series Two fixes for gdb.arch/pr25124.exp |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 success Build passed
linaro-tcwg-bot/tcwg_gdb_build--master-arm success Build passed
linaro-tcwg-bot/tcwg_gdb_check--master-arm success Test passed
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 success Test passed

Commit Message

Tom de Vries Nov. 29, 2024, 4:09 p.m. UTC 
  With test-case gdb.arch/pr25124.exp, I run into:
...
PASS: gdb.arch/pr25124.exp: disassemble thumb instruction (1st try)
PASS: gdb.arch/pr25124.exp: disassemble thumb instruction (2nd try)
DUPLICATE: gdb.arch/pr25124.exp: disassemble thumb instruction (2nd try)
...

Fix this by using a comma instead of parentheses.

Tested on arm-linux.
---
 gdb/testsuite/gdb.arch/pr25124.exp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Tom Tromey Dec. 3, 2024, 5:34 p.m. UTC | #1 
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> With test-case gdb.arch/pr25124.exp, I run into:
Tom> ...
Tom> PASS: gdb.arch/pr25124.exp: disassemble thumb instruction (1st try)
Tom> PASS: gdb.arch/pr25124.exp: disassemble thumb instruction (2nd try)
Tom> DUPLICATE: gdb.arch/pr25124.exp: disassemble thumb instruction (2nd try)
Tom> ...

Tom> Fix this by using a comma instead of parentheses.

Seems obvious FWIW.
Approved-By: Tom Tromey <tom@tromey.com>

Tom
diff mbox series

Patch

diff --git a/gdb/testsuite/gdb.arch/pr25124.exp b/gdb/testsuite/gdb.arch/pr25124.exp
index 3bf08a178ec..26cfc1368a0 100644
--- a/gdb/testsuite/gdb.arch/pr25124.exp
+++ b/gdb/testsuite/gdb.arch/pr25124.exp
@@ -30,7 +30,7 @@  clean_restart $binfile
 # Check if the disassemble ouput is correct.
 gdb_test "x /i main+8" \
 	"$hex <main\\+8>:\[ \t\]+bx\[ \t\]+lr" \
-	"disassemble thumb instruction (1st try)"
+	"disassemble thumb instruction, 1st try"
 
 # Reload the symbol file to trigger the bug.
 gdb_load ${binfile}
@@ -38,4 +38,4 @@  gdb_load ${binfile}
 # Check if the disassemble output is the same as above.
 gdb_test "x /i main+8" \
 	"$hex <main\\+8>:\[ \t\]+bx\[ \t\]+lr" \
-	"disassemble thumb instruction (2nd try)"
+	"disassemble thumb instruction, 2nd try"