diff mbox series

[v2,3/3] Reuse "title" style for list headers

Message ID 20241127-cli-command-style-v2-3-6dc216226169@tromey.com
State New
Headers
Series Add "command" styling |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 success Build passed
linaro-tcwg-bot/tcwg_gdb_build--master-arm success Build passed
linaro-tcwg-bot/tcwg_gdb_check--master-arm success Test passed
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 success Test passed

Commit Message

Tom Tromey Nov. 28, 2024, 12:20 a.m. UTC 
  This patch reuses the "title" style for titles -- in particular the
header line of a list display.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>
Reviewed-By: Keith Seitz <keiths@redhat.com>
---
 gdb/NEWS                         | 6 ++++++
 gdb/cli-out.c                    | 2 +-
 gdb/doc/gdb.texinfo              | 6 ++----
 gdb/testsuite/gdb.base/style.exp | 3 ++-
 4 files changed, 11 insertions(+), 6 deletions(-)

Comments

Eli Zaretskii Nov. 28, 2024, 7:36 a.m. UTC | #1 
> From: Tom Tromey <tom@tromey.com>
> Date: Wed, 27 Nov 2024 17:20:24 -0700
> Cc: Eli Zaretskii <eliz@gnu.org>, Keith Seitz <keiths@redhat.com>
> 
> This patch reuses the "title" style for titles -- in particular the
> header line of a list display.
> 
> Reviewed-By: Eli Zaretskii <eliz@gnu.org>
> Reviewed-By: Keith Seitz <keiths@redhat.com>
> ---
>  gdb/NEWS                         | 6 ++++++
>  gdb/cli-out.c                    | 2 +-
>  gdb/doc/gdb.texinfo              | 6 ++----
>  gdb/testsuite/gdb.base/style.exp | 3 ++-
>  4 files changed, 11 insertions(+), 6 deletions(-)

OK for the documentation parts, thanks.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>
diff mbox series

Patch

diff --git a/gdb/NEWS b/gdb/NEWS
index 4527a13448868220582f4f7f474129e02de0f092..b30a3b3964158ae376d5f54d3bacdd10dc2a69fb 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -114,6 +114,12 @@  set style command background COLOR
 set style command intensity VALUE
   Control the styling of GDB commands when displayed by GDB.
 
+set style title foreground COLOR
+set style title background COLOR
+set style title intensity VALUE
+  This style now applies to the header line of lists.  Previous uses
+  of this style have been replaced with the new "command" style.
+
 set warn-language-frame-mismatch [on|off]
 show warn-language-frame-mismatch
   Control the warning that is emitted when specifying a language that
diff --git a/gdb/cli-out.c b/gdb/cli-out.c
index d8a542d1b9be1416b87754737e8d64cc4dcf9e08..afa73eba2aed645cdae3eee8bedf2da7a2f00edd 100644
--- a/gdb/cli-out.c
+++ b/gdb/cli-out.c
@@ -73,7 +73,7 @@  cli_ui_out::do_table_header (int width, ui_align alignment,
     return;
 
   do_field_string (0, width, alignment, 0, col_hdr.c_str (),
-		   ui_file_style ());
+		   title_style.style ());
 }
 
 /* Mark beginning of a list */
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 0254b5aa815e3d6fe97d97d79879e13b0ef0cf02..5cbd82abd56e4a90f3df5ff40e8980cc1bff4042 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -27915,10 +27915,8 @@  Files}).
 @item title
 Control the styling of titles.  These are managed with the
 @code{set style title} family of commands.  By default, this style's
-intensity is bold.  Commands are using the title style to improve
-the readability of large output.  For example, the commands
-@command{apropos} and @command{help} are using the title style
-for the command names.
+intensity is bold.  The title style is used when displaying the header
+line of a list.
 
 @item highlight
 Control the styling of highlightings.  These are managed with the
diff --git a/gdb/testsuite/gdb.base/style.exp b/gdb/testsuite/gdb.base/style.exp
index 83e0faeebd07428b08ea311b4b6193547dd350a1..628c6b80570882ed5333fe0bab4d117f161f92d0 100644
--- a/gdb/testsuite/gdb.base/style.exp
+++ b/gdb/testsuite/gdb.base/style.exp
@@ -111,7 +111,8 @@  proc run_style_tests { } {
 	    [multi_line \
 		 "#0\\s+$main_expr\\s+\\($arg_expr=$decimal,\\s+$arg_expr=$hex.*\\)\\s+at\\s+$file_expr" \
 		 "$line_expr\\s+.*return.* break here .*"]
-	gdb_test "info breakpoints" "$main_expr at $file_expr.*"
+	gdb_test "info breakpoints" \
+	    ".*[limited_style What title].*$main_expr at $file_expr.*"
 
 	gdb_test_no_output "set style sources off"
 	gdb_test "frame" \