[2/3] gdb: syscalls: Remove tips for LoongArch xml files

Message ID 20241126085912.30599-3-yangtiezhu@loongson.cn
State New
Headers
Series gdb: Update syscall files for LoongArch |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 success Build passed
linaro-tcwg-bot/tcwg_gdb_build--master-arm success Build passed
linaro-tcwg-bot/tcwg_gdb_check--master-arm success Test passed
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 success Test passed

Commit Message

Tiezhu Yang Nov. 26, 2024, 8:59 a.m. UTC
  For now, there is no need to do special handling when generating xml file
for LoongArch, just remove the tips in the file comment.

Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
 gdb/syscalls/loongarch-linux.xml    | 24 +-----------------------
 gdb/syscalls/loongarch-linux.xml.in | 23 +----------------------
 2 files changed, 2 insertions(+), 45 deletions(-)
  

Comments

Tom de Vries Nov. 26, 2024, 3:21 p.m. UTC | #1
On 11/26/24 09:59, Tiezhu Yang wrote:
> For now, there is no need to do special handling when generating xml file
> for LoongArch, just remove the tips in the file comment.
> 

Could you explain why you say "for now" here?

Anyway, LGTM.

Approved-By: Tom de Vries <tdevries@suse.de>

Thanks,
- Tom

> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
>   gdb/syscalls/loongarch-linux.xml    | 24 +-----------------------
>   gdb/syscalls/loongarch-linux.xml.in | 23 +----------------------
>   2 files changed, 2 insertions(+), 45 deletions(-)
> 
> diff --git a/gdb/syscalls/loongarch-linux.xml b/gdb/syscalls/loongarch-linux.xml
> index 6e85dbd7166..91e7bbc9691 100644
> --- a/gdb/syscalls/loongarch-linux.xml
> +++ b/gdb/syscalls/loongarch-linux.xml
> @@ -9,29 +9,7 @@
>   
>        <sys/syscall.h>
>   
> -     The file mentioned above belongs to the Linux Kernel.
> -
> -     Note that the system header file /usr/include/asm-generic/unistd.h
> -     may be different with the latest upstream Linux kernel uapi header
> -     file include/uapi/asm-generic/unistd.h, it is better to copy the
> -     upstream header file into the system header file when generating
> -     loongarch-linux.xml.in.
> -
> -     There exist some __NR3264_ prefixed syscall numbers, replace them
> -     with digital numbers according to /usr/include/asm-generic/unistd.h
> -     and sort them by syscall number manually, maybe we can modify the
> -     script to do it automatically in the future.
> -
> -     <syscall name="fcntl" number="__NR3264_fcntl"/>
> -     <syscall name="statfs" number="__NR3264_statfs"/>
> -     <syscall name="fstatfs" number="__NR3264_fstatfs"/>
> -     <syscall name="truncate" number="__NR3264_truncate"/>
> -     <syscall name="ftruncate" number="__NR3264_ftruncate"/>
> -     <syscall name="lseek" number="__NR3264_lseek"/>
> -     <syscall name="sendfile" number="__NR3264_sendfile"/>
> -     <syscall name="mmap" number="__NR3264_mmap"/>
> -     <syscall name="fadvise64" number="__NR3264_fadvise64"/>
> --->
> +     The file mentioned above belongs to the Linux Kernel.  -->
>   <syscalls_info>
>     <syscall name="io_setup" number="0" groups="memory"/>
>     <syscall name="io_destroy" number="1" groups="memory"/>
> diff --git a/gdb/syscalls/loongarch-linux.xml.in b/gdb/syscalls/loongarch-linux.xml.in
> index cf38f311abe..e6e17b3f2b6 100644
> --- a/gdb/syscalls/loongarch-linux.xml.in
> +++ b/gdb/syscalls/loongarch-linux.xml.in
> @@ -11,29 +11,8 @@
>   
>        <sys/syscall.h>
>   
> -     The file mentioned above belongs to the Linux Kernel.
> +     The file mentioned above belongs to the Linux Kernel.  -->
>   
> -     Note that the system header file /usr/include/asm-generic/unistd.h
> -     may be different with the latest upstream Linux kernel uapi header
> -     file include/uapi/asm-generic/unistd.h, it is better to copy the
> -     upstream header file into the system header file when generating
> -     loongarch-linux.xml.in.
> -
> -     There exist some __NR3264_ prefixed syscall numbers, replace them
> -     with digital numbers according to /usr/include/asm-generic/unistd.h
> -     and sort them by syscall number manually, maybe we can modify the
> -     script to do it automatically in the future.
> -
> -     <syscall name="fcntl" number="__NR3264_fcntl"/>
> -     <syscall name="statfs" number="__NR3264_statfs"/>
> -     <syscall name="fstatfs" number="__NR3264_fstatfs"/>
> -     <syscall name="truncate" number="__NR3264_truncate"/>
> -     <syscall name="ftruncate" number="__NR3264_ftruncate"/>
> -     <syscall name="lseek" number="__NR3264_lseek"/>
> -     <syscall name="sendfile" number="__NR3264_sendfile"/>
> -     <syscall name="mmap" number="__NR3264_mmap"/>
> -     <syscall name="fadvise64" number="__NR3264_fadvise64"/>
> --->
>   
>   <syscalls_info>
>     <syscall name="io_setup" number="0"/>
  

Patch

diff --git a/gdb/syscalls/loongarch-linux.xml b/gdb/syscalls/loongarch-linux.xml
index 6e85dbd7166..91e7bbc9691 100644
--- a/gdb/syscalls/loongarch-linux.xml
+++ b/gdb/syscalls/loongarch-linux.xml
@@ -9,29 +9,7 @@ 
 
      <sys/syscall.h>
 
-     The file mentioned above belongs to the Linux Kernel.
-
-     Note that the system header file /usr/include/asm-generic/unistd.h
-     may be different with the latest upstream Linux kernel uapi header
-     file include/uapi/asm-generic/unistd.h, it is better to copy the
-     upstream header file into the system header file when generating
-     loongarch-linux.xml.in.
-
-     There exist some __NR3264_ prefixed syscall numbers, replace them
-     with digital numbers according to /usr/include/asm-generic/unistd.h
-     and sort them by syscall number manually, maybe we can modify the
-     script to do it automatically in the future.
-
-     <syscall name="fcntl" number="__NR3264_fcntl"/>
-     <syscall name="statfs" number="__NR3264_statfs"/>
-     <syscall name="fstatfs" number="__NR3264_fstatfs"/>
-     <syscall name="truncate" number="__NR3264_truncate"/>
-     <syscall name="ftruncate" number="__NR3264_ftruncate"/>
-     <syscall name="lseek" number="__NR3264_lseek"/>
-     <syscall name="sendfile" number="__NR3264_sendfile"/>
-     <syscall name="mmap" number="__NR3264_mmap"/>
-     <syscall name="fadvise64" number="__NR3264_fadvise64"/>
--->
+     The file mentioned above belongs to the Linux Kernel.  -->
 <syscalls_info>
   <syscall name="io_setup" number="0" groups="memory"/>
   <syscall name="io_destroy" number="1" groups="memory"/>
diff --git a/gdb/syscalls/loongarch-linux.xml.in b/gdb/syscalls/loongarch-linux.xml.in
index cf38f311abe..e6e17b3f2b6 100644
--- a/gdb/syscalls/loongarch-linux.xml.in
+++ b/gdb/syscalls/loongarch-linux.xml.in
@@ -11,29 +11,8 @@ 
 
      <sys/syscall.h>
 
-     The file mentioned above belongs to the Linux Kernel.
+     The file mentioned above belongs to the Linux Kernel.  -->
 
-     Note that the system header file /usr/include/asm-generic/unistd.h
-     may be different with the latest upstream Linux kernel uapi header
-     file include/uapi/asm-generic/unistd.h, it is better to copy the
-     upstream header file into the system header file when generating
-     loongarch-linux.xml.in.
-
-     There exist some __NR3264_ prefixed syscall numbers, replace them
-     with digital numbers according to /usr/include/asm-generic/unistd.h
-     and sort them by syscall number manually, maybe we can modify the
-     script to do it automatically in the future.
-
-     <syscall name="fcntl" number="__NR3264_fcntl"/>
-     <syscall name="statfs" number="__NR3264_statfs"/>
-     <syscall name="fstatfs" number="__NR3264_fstatfs"/>
-     <syscall name="truncate" number="__NR3264_truncate"/>
-     <syscall name="ftruncate" number="__NR3264_ftruncate"/>
-     <syscall name="lseek" number="__NR3264_lseek"/>
-     <syscall name="sendfile" number="__NR3264_sendfile"/>
-     <syscall name="mmap" number="__NR3264_mmap"/>
-     <syscall name="fadvise64" number="__NR3264_fadvise64"/>
--->
 
 <syscalls_info>
   <syscall name="io_setup" number="0"/>