From patchwork Fri Oct 25 02:26:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Buettner X-Patchwork-Id: 99518 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 766F8385840B for ; Fri, 25 Oct 2024 03:35:45 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id C2B933858D33 for ; Fri, 25 Oct 2024 03:35:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C2B933858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C2B933858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1729827306; cv=none; b=wfKvSsJddYOp3a4x9WWLusTFG4aJWFbE2y+PlQQVTNasp5CH3sVh3KwVfOXqWK+icxV9dCRDOW6yjTZgZlG/XEWfDhEGAla0WwOjNZhVtJdNOPtNGBsx8dNlN6Cwa7Ahgttfvdy2CdCdwYfeJOMHl9vU2LaHRBYOpqA10sJia+0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1729827306; c=relaxed/simple; bh=Tl6MOeGMkfxlNWl06MkA4v24pYKJ0XhjXFpIcIBpI9A=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=seXw8unk+OwsGgymF0PaJwpvxZiDiUVMTdJuKqSzblKBFqyChlImlzkiScjavqkjl38i+oxORkf6sDBfLvvz7ZdRmh/o5oV/NQAV7Wsd0BKSwAZjdhQBHbpTUEEyem26OXw0kmKsvALGvE9D7QsdVFWz6+UDdTnZhXk77kpOzrQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729827302; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9QP3imvLapmnpdzHYQhZbenIeCxzs81N3tWhHWmdeFI=; b=fQzBDYomdz5akB6w1TLxEsNfB+f7TNhcDLU/jbMKx6mBy/Vfg6KS4Edj6ynK2RXtIPCezv A0m5B8RO7zeREmOBFAIrqcvIclIFb8EMgT05U+3yg+D3PYiZHnIQIZv0rdq2/z/qwPgLkD ed/u5x3tlaAMNubTjd0ZEJe5kbIoPRg= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-463-8_216W5YMFCska5gtKGZsg-1; Thu, 24 Oct 2024 23:35:01 -0400 X-MC-Unique: 8_216W5YMFCska5gtKGZsg-1 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7249119560B5 for ; Fri, 25 Oct 2024 03:35:00 +0000 (UTC) Received: from f41-1.lan (unknown [10.22.64.38]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 79AC9300018D; Fri, 25 Oct 2024 03:34:59 +0000 (UTC) From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Kevin Buettner Subject: [PATCH v3 01/11] Don't attempt to find TLS address when target has no registers Date: Thu, 24 Oct 2024 19:26:19 -0700 Message-ID: <20241025033431.36274-2-kevinb@redhat.com> In-Reply-To: <20241025033431.36274-1-kevinb@redhat.com> References: <20241025033431.36274-1-kevinb@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org This commit fixes two bugs, one of which is Bug 25807 - that one is fixed by the change in findvar.c. I found it while testing on aarch64; it turned a KFAIL for gdb.threads/tls.exp: print a_thread_local into a FAIL due to a GDB internal error. In addition to the existing test just noted, I've also added a test to the new test case gdb.base/tls-nothreads.exp. It'll be tested, using different scenarios, up to 8 times: PASS: gdb.base/tls-nothreads.exp: default: force_internal_tls=false: after exit: print tls_tbss_1 PASS: gdb.base/tls-nothreads.exp: default: force_internal_tls=true: after exit: print tls_tbss_1 PASS: gdb.base/tls-nothreads.exp: static: force_internal_tls=false: after exit: print tls_tbss_1 PASS: gdb.base/tls-nothreads.exp: static: force_internal_tls=true: after exit: print tls_tbss_1 PASS: gdb.base/tls-nothreads.exp: pthreads: force_internal_tls=false: after exit: print tls_tbss_1 PASS: gdb.base/tls-nothreads.exp: pthreads: force_internal_tls=true: after exit: print tls_tbss_1 PASS: gdb.base/tls-nothreads.exp: pthreads-static: force_internal_tls=false: after exit: print tls_tbss_1 PASS: gdb.base/tls-nothreads.exp: pthreads-static: force_internal_tls=true: after exit: print tls_tbss_1 There is a related problem that's fixed by the minsyms.c change. It can be observed when debugging a program without debugging symbols when the program is not executing. I've written a new test for this, but it's included in the new test case gdb.base/tls-nothreads.exp, found later in this series. Depending on the target, it'll be run up to 8 times for different targets. E.g., on aarch64, I'm seeing these PASSes, all of which test this change: PASS: gdb.base/tls-nothreads.exp: default: force_internal_tls=false: stripped: after exit: print (int) tls_tbss_1 PASS: gdb.base/tls-nothreads.exp: default: force_internal_tls=true: stripped: after exit: print (int) tls_tbss_1 PASS: gdb.base/tls-nothreads.exp: static: force_internal_tls=false: stripped: after exit: print (int) tls_tbss_1 PASS: gdb.base/tls-nothreads.exp: static: force_internal_tls=true: stripped: after exit: print (int) tls_tbss_1 PASS: gdb.base/tls-nothreads.exp: pthreads: force_internal_tls=false: stripped: after exit: print (int) tls_tbss_1 PASS: gdb.base/tls-nothreads.exp: pthreads: force_internal_tls=true: stripped: after exit: print (int) tls_tbss_1 PASS: gdb.base/tls-nothreads.exp: pthreads-static: force_internal_tls=false: stripped: after exit: print (int) tls_tbss_1 PASS: gdb.base/tls-nothreads.exp: pthreads-static: force_internal_tls=true: stripped: after exit: print (int) tls_tbss_1 Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=25807 --- gdb/findvar.c | 7 ++++++- gdb/minsyms.c | 8 +++++++- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/gdb/findvar.c b/gdb/findvar.c index f7760aa61ca..a530e679c8a 100644 --- a/gdb/findvar.c +++ b/gdb/findvar.c @@ -485,7 +485,12 @@ language_defn::read_var_value (struct symbol *var, /* Determine address of TLS variable. */ if (obj_section && (obj_section->the_bfd_section->flags & SEC_THREAD_LOCAL) != 0) - addr = target_translate_tls_address (obj_section->objfile, addr); + { + if (!target_has_registers ()) + error (_("Cannot read `%s' without registers"), + var->print_name ()); + addr = target_translate_tls_address (obj_section->objfile, addr); + } } break; diff --git a/gdb/minsyms.c b/gdb/minsyms.c index 33eb9072e5f..a904bd96045 100644 --- a/gdb/minsyms.c +++ b/gdb/minsyms.c @@ -1684,7 +1684,13 @@ find_minsym_type_and_address (minimal_symbol *msymbol, { /* Skip translation if caller does not need the address. */ if (address_p != NULL) - *address_p = target_translate_tls_address (objfile, addr); + { + if (!target_has_registers ()) + error (_( + "Cannot determine address of TLS symbol `%s' without registers"), + bound_msym.minsym->print_name ()); + *address_p = target_translate_tls_address (objfile, addr); + } return builtin_type (objfile)->nodebug_tls_symbol; }