[1/2] Use gdb_bfd_get_full_section_contents in auto-load.c
Checks
Context |
Check |
Description |
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 |
success
|
Build passed
|
linaro-tcwg-bot/tcwg_gdb_build--master-arm |
success
|
Build passed
|
linaro-tcwg-bot/tcwg_gdb_check--master-arm |
success
|
Test passed
|
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 |
success
|
Test passed
|
Commit Message
This changes auto-load.c ot use gdb_bfd_get_full_section_contents.
This shouldn't change any behavior, but makes it easier to add locking
in a subsequent patch.
---
gdb/auto-load.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
@@ -1114,25 +1114,22 @@ auto_load_section_scripts (struct objfile *objfile, const char *section_name)
{
bfd *abfd = objfile->obfd.get ();
asection *scripts_sect;
- bfd_byte *data = NULL;
scripts_sect = bfd_get_section_by_name (abfd, section_name);
if (scripts_sect == NULL
|| (bfd_section_flags (scripts_sect) & SEC_HAS_CONTENTS) == 0)
return;
- if (!bfd_get_full_section_contents (abfd, scripts_sect, &data))
+ gdb::byte_vector data;
+ if (!gdb_bfd_get_full_section_contents (abfd, scripts_sect, &data))
warning (_("Couldn't read %s section of %ps"),
section_name,
styled_string (file_name_style.style (),
bfd_get_filename (abfd)));
else
{
- gdb::unique_xmalloc_ptr<bfd_byte> data_holder (data);
-
- char *p = (char *) data;
- source_section_scripts (objfile, section_name, p,
- p + bfd_section_size (scripts_sect));
+ const char *p = (const char *) data.data ();
+ source_section_scripts (objfile, section_name, p, p + data.size ());
}
}