[3/3] Reuse "title" style for list headers
Checks
Context |
Check |
Description |
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 |
success
|
Build passed
|
linaro-tcwg-bot/tcwg_gdb_build--master-arm |
success
|
Build passed
|
linaro-tcwg-bot/tcwg_gdb_check--master-arm |
success
|
Test passed
|
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 |
success
|
Test passed
|
Commit Message
This patch reuses the "title" style for titles -- in particular the
header line of a list display.
---
gdb/NEWS | 6 ++++++
gdb/cli-out.c | 2 +-
gdb/doc/gdb.texinfo | 6 ++----
gdb/testsuite/gdb.base/style.exp | 3 ++-
4 files changed, 11 insertions(+), 6 deletions(-)
Comments
> From: Tom Tromey <tom@tromey.com>
> Date: Fri, 04 Oct 2024 17:31:43 -0600
>
> This patch reuses the "title" style for titles -- in particular the
> header line of a list display.
> ---
> gdb/NEWS | 6 ++++++
> gdb/cli-out.c | 2 +-
> gdb/doc/gdb.texinfo | 6 ++----
> gdb/testsuite/gdb.base/style.exp | 3 ++-
> 4 files changed, 11 insertions(+), 6 deletions(-)
Thanks.
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -112,6 +112,12 @@ maintenance print remote-registers
> which registers were included in the last stop reply packet received by
> GDB.
>
> +set style title foreground COLOR
> +set style title background COLOR
> +set style title intensity VALUE
> + This style now applies to the header line of lists. Previous uses
> + of this style have been replaced with the new "command" style.
I think this could benefit from a couple of examples of what we mean
by "header line of a list".
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -27890,10 +27890,8 @@ Files}).
> @item title
> Control the styling of titles. These are managed with the
> @code{set style title} family of commands. By default, this style's
> -intensity is bold. Commands are using the title style to improve
> -the readability of large output. For example, the commands
> -@command{apropos} and @command{help} are using the title style
> -for the command names.
> +intensity is bold. The title style is used when displaying the header
> +line of a list.
Likewise here, with cross-references to the respective nodes in the
manual.
The documentation parts are okay with these nits fixed.
Reviewed-By: Eli Zaretskii <eliz@gnu.org>
@@ -112,6 +112,12 @@ maintenance print remote-registers
which registers were included in the last stop reply packet received by
GDB.
+set style title foreground COLOR
+set style title background COLOR
+set style title intensity VALUE
+ This style now applies to the header line of lists. Previous uses
+ of this style have been replaced with the new "command" style.
+
* New remote packets
vFile:stat
@@ -73,7 +73,7 @@ cli_ui_out::do_table_header (int width, ui_align alignment,
return;
do_field_string (0, width, alignment, 0, col_hdr.c_str (),
- ui_file_style ());
+ title_style.style ());
}
/* Mark beginning of a list */
@@ -27890,10 +27890,8 @@ Files}).
@item title
Control the styling of titles. These are managed with the
@code{set style title} family of commands. By default, this style's
-intensity is bold. Commands are using the title style to improve
-the readability of large output. For example, the commands
-@command{apropos} and @command{help} are using the title style
-for the command names.
+intensity is bold. The title style is used when displaying the header
+line of a list.
@item highlight
Control the styling of highlightings. These are managed with the
@@ -111,7 +111,8 @@ proc run_style_tests { } {
[multi_line \
"#0\\s+$main_expr\\s+\\($arg_expr=$decimal,\\s+$arg_expr=$hex.*\\)\\s+at\\s+$file_expr" \
"$line_expr\\s+.*return.* break here .*"]
- gdb_test "info breakpoints" "$main_expr at $file_expr.*"
+ gdb_test "info breakpoints" \
+ ".*[limited_style What title].*$main_expr at $file_expr.*"
gdb_test_no_output "set style sources off"
gdb_test "frame" \