From patchwork Thu Aug 22 15:47:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Antonio Rische X-Patchwork-Id: 96322 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 99AE13875452 for ; Thu, 22 Aug 2024 15:49:01 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-4319.protonmail.ch (mail-4319.protonmail.ch [185.70.43.19]) by sourceware.org (Postfix) with ESMTPS id 28E103875440 for ; Thu, 22 Aug 2024 15:48:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 28E103875440 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=protonmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 28E103875440 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=185.70.43.19 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724341695; cv=none; b=S6+YJVyffq365cRJ0BsfY0NuEiZM+eGad+WSxblkGKH1bQ6Nijo6v9RLBhCFG4EViYlLkDFOc5HxsOeb1AhwQiKr6J8gVFY/zOuu4nCs5Gk3jP6pFHDam4xrbRCgtQXrwFsqp6HqPXdwEZeYgAL1YnEKlv8e/GcjU/wdOHJPLZo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724341695; c=relaxed/simple; bh=1+n1GUKsowABhdfPJzNpb/9d0v83AqRJkR14SbWsj8M=; h=DKIM-Signature:Date:To:From:Subject:Message-ID:MIME-Version; b=Bcds6KIdbrPCcbrWXdpeRi0wzVM+mOFYzf5QuWYBFtzORWHEazZlC1eioYJBo4N133RCLH+sx07iKYxA4KwFHU6EspJWVJ7LMzsgrP/EkFYjgc25GHxc55bfeP65dnRYkQZ34NJTYLL1Scc5LBVET1XIOtj0tPTzd7/XEAKHJn4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1724341683; x=1724600883; bh=wKc0eyG8hjBkTxB0m6tkcp5DqlGJrzFtj2qaOzvRSRU=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=B4s2n9rDVxk7yIyIDlhjTNtJ7vL6DdtroJwi2xiQ9J5X5aEdZFVHTgHR+2zsU2Xt2 lc5wCUsA9DP+Hs88f9LTxtsgsJsO7Nq1PgAtfI3W1WQKbtGLmPwtmrMjZJuVQXYsA5 Og8LAWcxRnEqCEvjTnIDms+TtLJLeJ5R2/IT+7OvoOKR9yN+QjR7onDv59b3RV4SIF 4aISOBXg5UiexCCGeQ6oAkhllONBI4ZtRv2clEKdBGpKd7XJQK6i4xCSvRr00FB5K1 kks9jybTr/eBaS/MvVNoZm5RFEwbHKIjTEDL/HhPAB2UgaoIK4Z6lfhO9rkl1wxlUl 1GR+ar6hJAzJg== Date: Thu, 22 Aug 2024 15:47:57 +0000 To: gdb-patches@sourceware.org From: Antonio Rische Cc: Antonio Rische Subject: [PATCH 2/2] gdb: Tab complete internalvars in expressions Message-ID: <20240822154730.1595141-3-nt8r@protonmail.com> In-Reply-To: <20240822154730.1595141-1-nt8r@protonmail.com> References: <20240822154730.1595141-1-nt8r@protonmail.com> Feedback-ID: 21706885:user:proton X-Pm-Message-ID: 9005bf3aca8055571f946f8960cd880f835047c6 MIME-Version: 1.0 X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org For example, 'print $f' after running 'set $foo=0' now tab completes. 'print $_siginf' also now tab completes. --- gdb/completer.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/gdb/completer.c b/gdb/completer.c index 1008ec23b..6476ddf79 100644 --- a/gdb/completer.c +++ b/gdb/completer.c @@ -1099,6 +1099,16 @@ complete_expression (completion_tracker &tracker, && expr_completer->complete (exp.get (), tracker)) return; + if (text[0] == '$') + { + tracker.advance_custom_word_point_by (1); + /* We don't support completion of history indices. */ + if (!isdigit (text[1])) + complete_internalvar (tracker, &text[1]); + tracker.advance_custom_word_point_by (-1); + return; + } + complete_files_symbols (tracker, text, word); }