[gdb/testsuite] Fix regexp in gdb.ada/mi_var_access.exp some more
Checks
| Context |
Check |
Description |
| linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 |
success
|
Build passed
|
| linaro-tcwg-bot/tcwg_gdb_build--master-arm |
success
|
Build passed
|
| linaro-tcwg-bot/tcwg_gdb_check--master-arm |
success
|
Test passed
|
| linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 |
success
|
Test passed
|
Commit Message
When running test-case gdb.ada/mi_var_access.exp on arm-linux (debian trixie),
I run into:
...
Expecting: ^(-var-create A_String_Access \* A_String_Access[
]+)?((\^done,name="A_String_Access",numchild="[0-9]+",.*|\^error,msg="Value out of range.".*)[
]+[(]gdb[)]
[ ]*)
-var-create A_String_Access * A_String_Access
^error,msg="Cannot access memory at address 0x4"
(gdb)
FAIL: gdb.ada/mi_var_access.exp: Create varobj (unexpected output)
...
This is similar to the problem fixed by commit c5a72a8d1c3 ("[gdb/testsuite]
Fix regexp in gdb.ada/mi_var_access.exp").
The problem in both cases is that we're printing an uninitialized variable,
and consequently we can run into various error messages during printing.
Fix this as in the other commit, by accepting the error message.
Tested on arm-linux.
---
gdb/testsuite/gdb.ada/mi_var_access.exp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
base-commit: de5dc49e43574742556868f1ba5032cbe1a0cd73
Comments
On 7/21/24 09:50, Tom de Vries wrote:
> When running test-case gdb.ada/mi_var_access.exp on arm-linux (debian trixie),
> I run into:
> ...
> Expecting: ^(-var-create A_String_Access \* A_String_Access[
> ]+)?((\^done,name="A_String_Access",numchild="[0-9]+",.*|\^error,msg="Value out of range.".*)[
> ]+[(]gdb[)]
> [ ]*)
> -var-create A_String_Access * A_String_Access
> ^error,msg="Cannot access memory at address 0x4"
> (gdb)
> FAIL: gdb.ada/mi_var_access.exp: Create varobj (unexpected output)
> ...
>
> This is similar to the problem fixed by commit c5a72a8d1c3 ("[gdb/testsuite]
> Fix regexp in gdb.ada/mi_var_access.exp").
>
> The problem in both cases is that we're printing an uninitialized variable,
> and consequently we can run into various error messages during printing.
>
> Fix this as in the other commit, by accepting the error message.
>
Pushed.
Thanks,
- Tom
> Tested on arm-linux.
> ---
> gdb/testsuite/gdb.ada/mi_var_access.exp | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/testsuite/gdb.ada/mi_var_access.exp b/gdb/testsuite/gdb.ada/mi_var_access.exp
> index b71c8f32151..e797a1576cb 100644
> --- a/gdb/testsuite/gdb.ada/mi_var_access.exp
> +++ b/gdb/testsuite/gdb.ada/mi_var_access.exp
> @@ -42,8 +42,9 @@ mi_continue_to_line \
> # to match possible values.
> set re_ok "\\^done,name=\"A_String_Access\",numchild=\"$decimal\",.*"
> set re_error "\\^error,msg=\"Value out of range\.\".*"
> +set re_error2 "\\^error,msg=\"Cannot access memory at address $hex\""
> mi_gdb_test "-var-create A_String_Access * A_String_Access" \
> - "($re_ok|$re_error)" \
> + "($re_ok|$re_error|$re_error2)" \
> "Create varobj"
>
> set bp_location [gdb_get_line_number "STOP2" ${testdir}/mi_access.adb]
>
> base-commit: de5dc49e43574742556868f1ba5032cbe1a0cd73
@@ -42,8 +42,9 @@ mi_continue_to_line \
# to match possible values.
set re_ok "\\^done,name=\"A_String_Access\",numchild=\"$decimal\",.*"
set re_error "\\^error,msg=\"Value out of range\.\".*"
+set re_error2 "\\^error,msg=\"Cannot access memory at address $hex\""
mi_gdb_test "-var-create A_String_Access * A_String_Access" \
- "($re_ok|$re_error)" \
+ "($re_ok|$re_error|$re_error2)" \
"Create varobj"
set bp_location [gdb_get_line_number "STOP2" ${testdir}/mi_access.adb]