From patchwork Fri May 17 15:20:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 90384 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4D499384AB75 for ; Fri, 17 May 2024 15:20:53 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-il1-x12d.google.com (mail-il1-x12d.google.com [IPv6:2607:f8b0:4864:20::12d]) by sourceware.org (Postfix) with ESMTPS id 919573858D20 for ; Fri, 17 May 2024 15:20:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 919573858D20 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 919573858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::12d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715959229; cv=none; b=COoqKHRUW6pVOVzUm1fjCAeboi45k0PaB7VRZ1grffb183G9SkeKuA7++3mhs298tLkWHNjAfeRee0TeGII2TRu0hNbgGzG7DRxT2zbBSe4boh481Ohry7laLUquzAvz8Bq+yq6nwJuXCm2GpZ0Xpn/PfNXTsI2etobC1Rf8wV4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715959229; c=relaxed/simple; bh=s9KOJsOhGGINBaUEK7C/yhsFZGAtGBI5o3P9n7ky7l8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=n8t5J1hQCTA3+J2MfarNXQWxGvZKzMPZhlprgxSiM1HPf94l98k8Jkf2zEfmX4MJCEdisbyorkRr2JHB3gQHNneqmpw4ugKiC9c/o0yr7oCh6Zje+zHPyPX6jox+XywqPQ1x2dCWSc1soUEHrCC1M5XfEgMuSzjejZJbhECF4wY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x12d.google.com with SMTP id e9e14a558f8ab-36c7004daecso4573395ab.0 for ; Fri, 17 May 2024 08:20:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1715959227; x=1716564027; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=clrcl9Iob2KB0ez8wllaL3prXG75BPOM2/X4Ofd/AXM=; b=kckv9Pt6tj/DZQcR4zI7vIOxfz80zfsWhXcTlV5298pibakM54ds1dbbdw+yjj8sfA EI8j6+ctmluNn8SdmJFykH/FHCBc/VklvZDnhEtwvAIVMyZCZFF/ted8259gFpTDXYNI e+c4t5gpuR1L/pfbeNZI2AOsfLGViHsomS8/nXwie0MGP+/IQ1MTIIJgAzBPnIEjkulB J3sXsWo684aSIiEiFMRBdFNQZLOviDQHTSVZK2Tf3gbleTfuf6dOJsb51GrsdiJRtUdR w7sJXMIvorue5deD1WGDSPnUJJfxPkwEdqp7G8nWJyqQ7LwjiiTUdOr0LtHUPMpl38lL 9+Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715959227; x=1716564027; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=clrcl9Iob2KB0ez8wllaL3prXG75BPOM2/X4Ofd/AXM=; b=OCsvO/rSHbFm65tvSyEYtmizZlN0qd7Btblb0Uzx3SacCoymHDWvQ95NkGzmYG2hiH gBO2jKuoVJbMqnZL789g62BFRoy7UFiOG2Tn3IKCfV2FsTibLBSBz7xlrBJsd0guMzuD SYk6ZNubtj8pyPxn6l1D1q357OsKDnrhsC0a/7Yd36fMk/4dC7pK+CmDPccqyfEomn8v EXQxsvmqTlqENLob2iHRjln1JeqHlWsEXAqHlFA/I9ZLR3F+6Awn0S/qC0q6RgsM2QNe +sVQ133+4CfcdeM0kFtWoifCGCge+fBc+jWEAoboacmQ1kAuLLX8fRmW8D9brwTBx1Zg ZDpw== X-Gm-Message-State: AOJu0Yz2iWR07jjmLxjAbDjGErEDaHYAG14ZQCVE3GhHUVYIKNQins/j QNNpB4qQ0grBXDHyTKCZAjYVe2Zt1B6AkIuvlhTqMCc/NAHCL1SSLEUm+z2o+YkdHPk9QEtIkCo = X-Google-Smtp-Source: AGHT+IGW0ZtxDrWTRreWkh2D4G6S1p3Y6gKLosYxqNeqd/gJ0jvgGIhcPbY1TU9Lrvr0KPuz6mmgLg== X-Received: by 2002:a05:6e02:1542:b0:36d:b6dc:98 with SMTP id e9e14a558f8ab-36db6dc02c8mr61502935ab.14.1715959226736; Fri, 17 May 2024 08:20:26 -0700 (PDT) Received: from localhost.localdomain (75-166-134-4.hlrn.qwest.net. [75.166.134.4]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-36cb9e09008sm43721405ab.65.2024.05.17.08.20.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 May 2024 08:20:26 -0700 (PDT) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Default dwarf_synchronous to true Date: Fri, 17 May 2024 09:20:14 -0600 Message-ID: <20240517152014.731236-1-tromey@adacore.com> X-Mailer: git-send-email 2.44.0 MIME-Version: 1.0 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Unfortunately the background DWARF reading series introduced a number of races, as repored by thread sanitizer. This patch changes gdb to disable this feature for the time being -- in particular for the gdb 15 release. I've filed a bug and linked all the known races to it. Once those are fixed we can re-enable this feature by default. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31751 --- gdb/dwarf2/read.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index e8416905163..4818da58acb 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -739,7 +739,7 @@ show_dwarf_max_cache_age (struct ui_file *file, int from_tty, } /* When true, wait for DWARF reading to be complete. */ -static bool dwarf_synchronous = false; +static bool dwarf_synchronous = true; /* "Show" callback for "maint set dwarf synchronous". */ static void