diff mbox series

gdb: Add missing single quotation mark in README

Message ID 20240509083510.17570-1-yangtiezhu@loongson.cn
State New
Headers
Series gdb: Add missing single quotation mark in README |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 warning Patch is already merged
linaro-tcwg-bot/tcwg_gdb_build--master-arm warning Patch is already merged

Commit Message

Tiezhu Yang May 9, 2024, 8:35 a.m. UTC 
  Maybe forgot to add a single quotation mark for --with-system-zlib
in commit 7f0bd4202c23 ("Update gdb's configure instructions"), just
add it.

Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
 gdb/README | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Eli Zaretskii May 9, 2024, 9:48 a.m. UTC | #1 
> From: Tiezhu Yang <yangtiezhu@loongson.cn>
> Date: Thu,  9 May 2024 16:35:10 +0800
> 
> Maybe forgot to add a single quotation mark for --with-system-zlib
> in commit 7f0bd4202c23 ("Update gdb's configure instructions"), just
> add it.

Thanks, fixed.
Tom Tromey May 9, 2024, 2:01 p.m. UTC | #2 
>>>>> Tiezhu Yang <yangtiezhu@loongson.cn> writes:

> Maybe forgot to add a single quotation mark for --with-system-zlib
> in commit 7f0bd4202c23 ("Update gdb's configure instructions"), just
> add it.

Thanks.  I think this would qualify as an obvious fix.
Approved-By: Tom Tromey <tom@tromey.com>

Tom
Tiezhu Yang May 10, 2024, 2:03 a.m. UTC | #3 
On 05/09/2024 10:01 PM, Tom Tromey wrote:
>>>>>> Tiezhu Yang <yangtiezhu@loongson.cn> writes:
>
>> Maybe forgot to add a single quotation mark for --with-system-zlib
>> in commit 7f0bd4202c23 ("Update gdb's configure instructions"), just
>> add it.
>
> Thanks.  I think this would qualify as an obvious fix.
> Approved-By: Tom Tromey <tom@tromey.com>

Thanks for your reply and Approved-By, I noticed that this change has
been merged as commit 5021daf30339 ("Fix typo in gdb/README.") by Eli.

---
Fix typo in gdb/README.

Patch from Tiezhu Yang <yangtiezhu@loongson.cn>.
---

So it seems that there is no chance to add your tag and then push it
again.

Thanks,
Tiezhu
diff mbox series

Patch

diff --git a/gdb/README b/gdb/README
index 763089bb02d..d85c37d5d17 100644
--- a/gdb/README
+++ b/gdb/README
@@ -451,7 +451,7 @@  more obscure GDB `configure' options are not listed here.
      library supplied as part of GDB.  Readline 7 or newer is required;
      this is enforced by the build system.
 
-`--with-system-zlib
+`--with-system-zlib'
      Use the zlib library installed on the host, rather than the
      library supplied as part of GDB.