From patchwork Fri Apr 26 16:15:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 89055 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 35F98384AB5C for ; Fri, 26 Apr 2024 16:16:25 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id 74D063858C42 for ; Fri, 26 Apr 2024 16:15:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 74D063858C42 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 74D063858C42 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714148164; cv=none; b=jMyCOcZPMmQwCNfgmLW+yKhtB115b2Vpuc8TAsyqwJHY8jzGDih5kpJGMVTYuFFcEU2/KEhCjQhQL0tsKAi/C0BaX7u36dTYcr8DgQrBvPa8NFUxWvXP3GG5EmYBnMoSa0tK7lCQzA9mhgPnHNZ5oSOnEkOu0CgjbTMwEgNW4d4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714148164; c=relaxed/simple; bh=IDGUupYJaPE9W8npwrDqy1VsC6wX/an2jycPCajielw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=XftYqEuka5B1Xzng3LZa83snYOEpYX6kj/11Bc9TNZA6d49XEpd+5/7GvkWbQN2NZHgm7nJEigVvjLFw6IovbY8LzIh82g3WylQwziyH+v7wTToJ7xiwnhvdp9C+QuKpNE40aAPybkbyKGk2tIUzd5+UOa74NHLt5Sv/Bnwxln4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5004a.ext.cloudfilter.net ([10.0.29.221]) by cmsmtp with ESMTPS id zqnQrcMOLuh6s0OEwswoqa; Fri, 26 Apr 2024 16:15:58 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 0OEwsT2xfGDo00OEwsWMjl; Fri, 26 Apr 2024 16:15:58 +0000 X-Authority-Analysis: v=2.4 cv=I+uuR8gg c=1 sm=1 tr=0 ts=662bd33e a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=raytVjVEu-sA:10 a=Qbun_eYptAEA:10 a=R4s_gpv5NxW-Xxemd8oA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/Qjj0norH22RSgTgGQTK7Sj2peKk3gmMYmrfBQDOszA=; b=mExgvTJL2Gcdj8Cxv0gdT8jNRK tZPcEGXBK5agm84klN7+qLF1ixp2lk4Haxa3D3clOLMzZx7cKADf97PawXBYdfnp656cuMvJVyrKC IeDhfpEJUi/tSbGP03qbRF2rA; Received: from 97-122-86-252.hlrn.qwest.net ([97.122.86.252]:36432 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1s0OEv-002bPC-2a; Fri, 26 Apr 2024 10:15:57 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Remove tui_refresh_all Date: Fri, 26 Apr 2024 10:15:50 -0600 Message-ID: <20240426161550.1120107-1-tom@tromey.com> X-Mailer: git-send-email 2.44.0 MIME-Version: 1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.86.252 X-Source-L: No X-Exim-ID: 1s0OEv-002bPC-2a X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-86-252.hlrn.qwest.net (localhost.localdomain) [97.122.86.252]:36432 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfM7v9G+qpwXKe4TDjTC+E1Yq/dw82TQV1/7e4aD+DTYgQIanSnRvgGQLfVyxhFH0N9dcvXUjnh93NZbEjOeeEV3HPuZSraxxkbAUSCYVwSBWkko2WmuU 6ejWUOtx58rEEbU19FvwAMoQxcFSNXTl3g8mEK/fxUiIEWT1oIN8ZnOam4/5WO+K97abovf3GJF/yXbZ8zt6L7k3oa3geKQ96cM= X-Spam-Status: No, score=-3021.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org This removes tui_refresh_all. There is only a single caller, tui_refresh_all_win, so inlining the code there simplifies gdb at no cost. Reviewed-By: Alexandra Petlanova Hajkova --- gdb/tui/tui-win.c | 6 +++++- gdb/tui/tui-wingeneral.c | 12 ------------ gdb/tui/tui-wingeneral.h | 1 - 3 files changed, 5 insertions(+), 14 deletions(-) diff --git a/gdb/tui/tui-win.c b/gdb/tui/tui-win.c index ced7e254f50..47e33fb60f4 100644 --- a/gdb/tui/tui-win.c +++ b/gdb/tui/tui-win.c @@ -480,7 +480,11 @@ void tui_refresh_all_win (void) { clearok (curscr, TRUE); - tui_refresh_all (); + for (tui_win_info *win_info : all_tui_windows ()) + { + if (win_info->is_visible ()) + win_info->refresh_window (); + } } void diff --git a/gdb/tui/tui-wingeneral.c b/gdb/tui/tui-wingeneral.c index c14ac5a8faf..c56179dc562 100644 --- a/gdb/tui/tui-wingeneral.c +++ b/gdb/tui/tui-wingeneral.c @@ -189,15 +189,3 @@ tui_win_info::make_visible (bool visible) else handle.reset (nullptr); } - -/* Function to refresh all the windows currently displayed. */ - -void -tui_refresh_all () -{ - for (tui_win_info *win_info : all_tui_windows ()) - { - if (win_info->is_visible ()) - win_info->refresh_window (); - } -} diff --git a/gdb/tui/tui-wingeneral.h b/gdb/tui/tui-wingeneral.h index 6bee433689e..652cef95733 100644 --- a/gdb/tui/tui-wingeneral.h +++ b/gdb/tui/tui-wingeneral.h @@ -28,7 +28,6 @@ struct tui_win_info; extern void tui_unhighlight_win (struct tui_win_info *); extern void tui_highlight_win (struct tui_win_info *); -extern void tui_refresh_all (); /* An RAII class that suppresses output on construction (calling wnoutrefresh on the existing windows), and then flushes the output