From patchwork Mon Apr 22 20:10:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 88878 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 971923849ADE for ; Mon, 22 Apr 2024 20:13:36 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 2CC31384AB71 for ; Mon, 22 Apr 2024 20:12:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2CC31384AB71 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2CC31384AB71 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713816723; cv=none; b=RL2tlReGk/e3SMkMeg5hFkmlc5RWM4Q9CNURtSeL6EQLhGUx/KpfsPyo2+Vbn7VNneIdAX02XcnuaGCykMvvjwtzopiNILcYfYfoxMOZL+XcDegZFz2ypQR6wenHE58a4+0rPykROIzzXsyLDRZz/nW9TYKVaddWTRzDI6jGxoA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713816723; c=relaxed/simple; bh=bPC0s5M6us+rcN/ygBWBuXcP1Ka1Y64yWsJhqwbqJj8=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=CIQF2jcqX0JPRBS+zTV9l8yFY+4fPAcGStVxwQ2i04ZAoj9Okbz4FE7kiOqzL9roW/Uc6SSmcPwkM9o6vqvWh5MUn+tLw8Do6RWIgxSgs6EBiJLPR+F2F2JHBb2pdljAZQF2B/yeYTAGAoOxE7cUjKLy5lAVbdB2CisoPVRzgp0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from smarchi-efficios.internal.efficios.com (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 7AE101E0C1; Mon, 22 Apr 2024 16:11:59 -0400 (EDT) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 3/7] gdb: remove extract_long_unsigned_integer Date: Mon, 22 Apr 2024 16:10:13 -0400 Message-ID: <20240422201157.46375-4-simon.marchi@efficios.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240422201157.46375-1-simon.marchi@efficios.com> References: <20240422201157.46375-1-simon.marchi@efficios.com> MIME-Version: 1.0 X-Spam-Status: No, score=-3496.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_NONE, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_SOFTFAIL, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org It is unused. Change-Id: I5d4091368c4dfc29752b12061e38f1df8353ba74 --- gdb/defs.h | 3 --- gdb/findvar.c | 53 --------------------------------------------------- 2 files changed, 56 deletions(-) diff --git a/gdb/defs.h b/gdb/defs.h index 057581d27641..be5c9b7261b6 100644 --- a/gdb/defs.h +++ b/gdb/defs.h @@ -457,9 +457,6 @@ extract_unsigned_integer (const gdb_byte *addr, int len, byte_order); } -extern int extract_long_unsigned_integer (const gdb_byte *, int, - enum bfd_endian, LONGEST *); - extern CORE_ADDR extract_typed_address (const gdb_byte *buf, struct type *type); diff --git a/gdb/findvar.c b/gdb/findvar.c index 71bfebe40a7a..734494961696 100644 --- a/gdb/findvar.c +++ b/gdb/findvar.c @@ -92,59 +92,6 @@ template LONGEST extract_integer (gdb::array_view buf, template ULONGEST extract_integer (gdb::array_view buf, enum bfd_endian byte_order); -/* Sometimes a long long unsigned integer can be extracted as a - LONGEST value. This is done so that we can print these values - better. If this integer can be converted to a LONGEST, this - function returns 1 and sets *PVAL. Otherwise it returns 0. */ - -int -extract_long_unsigned_integer (const gdb_byte *addr, int orig_len, - enum bfd_endian byte_order, LONGEST *pval) -{ - const gdb_byte *p; - const gdb_byte *first_addr; - int len; - - len = orig_len; - if (byte_order == BFD_ENDIAN_BIG) - { - for (p = addr; - len > (int) sizeof (LONGEST) && p < addr + orig_len; - p++) - { - if (*p == 0) - len--; - else - break; - } - first_addr = p; - } - else - { - first_addr = addr; - for (p = addr + orig_len - 1; - len > (int) sizeof (LONGEST) && p >= addr; - p--) - { - if (*p == 0) - len--; - else - break; - } - } - - if (len <= (int) sizeof (LONGEST)) - { - *pval = (LONGEST) extract_unsigned_integer (first_addr, - sizeof (LONGEST), - byte_order); - return 1; - } - - return 0; -} - - /* Treat the bytes at BUF as a pointer of type TYPE, and return the address it represents. */ CORE_ADDR