From patchwork Sun Apr 21 17:00:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 88814 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A22943858C33 for ; Sun, 21 Apr 2024 17:01:11 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id C14EA3858C52 for ; Sun, 21 Apr 2024 17:00:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C14EA3858C52 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C14EA3858C52 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713718811; cv=none; b=vA5TDgLW7d8Dm3/hP76uU9QPMNMOQ7oQLIE6Gr+mYeba/SsZlDcat2HmYwDRUFu0ta2+OqOzxaEM2YL+WqunJoYKbari7YvheQkQvhLmqBcCMq8zPRToXHvxHiQ4M5TbMYUFQShiI/iA26fcQ5VP+8Gije6Ec8SX/3QoLqHLb18= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713718811; c=relaxed/simple; bh=jk09xPBomjNMBohbC8LQX13fRS7MCcpe6jRuhlDJgWI=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=rrRsoKPLC65fJmXXDITTX4VeJ0xrEiGE4Aj/gtQFgmmwG3MOQ65mvGl935Mbrf64uRpXWQHrloLaId25hOSiAr3T8zg1qzI/OnMlVuCATRxCv1eKEnxsQrAZQp3s2cBU+Abf2vHaYDS/y1gXSd1CYxbHobpZuBZaLt+A0NiJc9Q= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6007a.ext.cloudfilter.net ([10.0.30.247]) by cmsmtp with ESMTPS id yZz3rER6eQr4SyaXtrn4uI; Sun, 21 Apr 2024 17:00:05 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id yaXsrRZebVdenyaXsrOcUU; Sun, 21 Apr 2024 17:00:04 +0000 X-Authority-Analysis: v=2.4 cv=M4FLKTws c=1 sm=1 tr=0 ts=66254614 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=raytVjVEu-sA:10 a=Qbun_eYptAEA:10 a=lfCki52Dxz4U2axuugIA:9 a=QEXdDO2ut3YA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=2q+c9an4fwKkMQZ7rEfu+HiQVY7UAtBG3rPdVKXedKQ=; b=sRO62RMJ0TChoV9BiW2/XwiOco kID5w+Mlee6KnqqSwpfpcLc2CMM6Nv0kUC+kveqVLQWLA/s242riHS4c3XCarBjrXhPfl/i3D8EeT 2GHZ4NcSRc9h4ZMzph4USJBvr; Received: from 97-122-86-252.hlrn.qwest.net ([97.122.86.252]:53968 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1ryaXr-003wVC-2j for gdb-patches@sourceware.org; Sun, 21 Apr 2024 11:00:03 -0600 From: Tom Tromey Date: Sun, 21 Apr 2024 11:00:06 -0600 Subject: [PATCH 06/10] Remove some unnecessary allocations from cpname_state::parse_number MIME-Version: 1.0 Message-Id: <20240421-canon-fixes-v1-6-4dc4791d270d@tromey.com> References: <20240421-canon-fixes-v1-0-4dc4791d270d@tromey.com> In-Reply-To: <20240421-canon-fixes-v1-0-4dc4791d270d@tromey.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.13.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.86.252 X-Source-L: No X-Exim-ID: 1ryaXr-003wVC-2j X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-86-252.hlrn.qwest.net ([192.168.0.21]) [97.122.86.252]:53968 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfBRZcqDqTeTqawFLPCHOk5ku7eeo0w10sNxZRMjoVTC+CyPy1qPfBgUFozZOrqFJdAhKFMU0Hdd/oOny/oCi6a1yVTN/1/1XjMg0eZApd5rq6QwFGqLQ n8ADwrNPvCMACKvmZA+7T5zwhBbaYXeGrPnmJ5Qod4WescxC1Hse5hnl8lCvkAtmVjawAaugZHChAQ5WWfpuKaqLy35PmF8vVUc= X-Spam-Status: No, score=-3021.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org cpname_state::parse_number allocates nodes for various types and then only uses one of them. This patch reduces the number of allocations by not performing the unnecessary ones. --- gdb/cp-name-parser.y | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/gdb/cp-name-parser.y b/gdb/cp-name-parser.y index 6590194545f..692fe84071c 100644 --- a/gdb/cp-name-parser.y +++ b/gdb/cp-name-parser.y @@ -1290,8 +1290,6 @@ cpname_state::parse_number (const char *p, int len, int parsed_float, /* Number of "L" suffixes encountered. */ int long_p = 0; - struct demangle_component *signed_type; - struct demangle_component *unsigned_type; struct demangle_component *type, *name; enum demangle_component_type literal_type; @@ -1362,25 +1360,26 @@ cpname_state::parse_number (const char *p, int len, int parsed_float, if (long_p == 0) { - unsigned_type = make_builtin_type ("unsigned int"); - signed_type = make_builtin_type ("int"); + if (unsigned_p) + type = make_builtin_type ("unsigned int"); + else + type = make_builtin_type ("int"); } else if (long_p == 1) { - unsigned_type = make_builtin_type ("unsigned long"); - signed_type = make_builtin_type ("long"); + if (unsigned_p) + type = make_builtin_type ("unsigned long"); + else + type = make_builtin_type ("long"); } else { - unsigned_type = make_builtin_type ("unsigned long long"); - signed_type = make_builtin_type ("long long"); + if (unsigned_p) + type = make_builtin_type ("unsigned long long"); + else + type = make_builtin_type ("long long"); } - if (unsigned_p) - type = unsigned_type; - else - type = signed_type; - name = make_name (p, len); lvalp->comp = fill_comp (literal_type, type, name);