From patchwork Wed Apr 17 21:04:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gustavo Romero X-Patchwork-Id: 88625 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 67A843849AFF for ; Wed, 17 Apr 2024 21:05:26 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id 0427E3858D37 for ; Wed, 17 Apr 2024 21:04:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0427E3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0427E3858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::635 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713387893; cv=none; b=aqkicKjF2t/Wam9+qcW3tVLaPSYn69OW7Qv5dq2dp6xpBbybLpXVuoQfK+gJ4eUJKDtg0NHxy2cgM71FTFLpcyR4ZG3loQCmXje4RPY+2lJ4ZSy43P0cok3jS20P9jMJ4selZFiSOLXFnMneYaS0wcG5cEJSawA/29x68ref5/M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713387893; c=relaxed/simple; bh=zn4DbmTot8VHmhi87qT4JPigPp9gYVtGLVN1Tzseteg=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=fy5iPYBXNAidLzQlETlRIJj9eBqjYhusJbHNqxZg3KHlgcxks9oKJNKb6tVPdrzzt9kOYd1/DFS/kVRRHcSBuW4FXiXs5rMKEaa7y15q4gp0E0iP1LHzoVo9C5navYIHZzTx7iKXsVfP/rOC8Ybbh/1dg0/o4o9pdtFJf1INQmo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1e5aa82d1f6so8344985ad.0 for ; Wed, 17 Apr 2024 14:04:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713387887; x=1713992687; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tYCk/P1xjalYBJuMqLUvPVXaT9Bbd2Fw6xG3npnM6gg=; b=GKMIqRQ8onIow4RmI7RQpr8vvNay95FxehIN5fo8pmZvdO9mflQiULdws/PxUwTiI4 D+p/FyMbTpeBAhijbdTegtH/trK9ZU3SqIzpgu8wM9snSkFxo4WkS/js/9PAOaeDjrIK fAFSpNwsOPhA4r63l1ceMeHgddvhqj5V0PPYvg9/JpDvmyGF7+9FdiN6MRLIrgRqmYnN sEibrC4BgF/C6qn6JNctJwr1CiOtQfY+l6BecJpk6pUEC8ERNvKQE/JaCp4eWAz80IRo iv9XmY2o8kt6OyFA3TzrL+7DQCaR9Q8g7/rbs/25U6kOLJmTbdP6rLaUVhG4hBmh7Arx hH8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713387887; x=1713992687; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tYCk/P1xjalYBJuMqLUvPVXaT9Bbd2Fw6xG3npnM6gg=; b=aZeKYz5qs1otlhRIsFgyrrlWouLSoOW+ZzXQ/YMBWlWsarjeRv55CgWHzlIdGhFM2p cQ1dBOlYCviSIMPd7Ren1rql/fWqXH2QIHwBWE8Nz+61Is4EtIlWbo72UcwnxvYl5ZXE cwV5+yaxUNwR1layxjG5iIDd48JGStXdvFLCYmZJCYAxX/Kc2hJ4QNJeJLti6ipAwdE8 BZmgQ3aX56sswhgBu4cKDSGBKZjR0yLgaulEcp3IkqRqF1AGzc6qKoC2R89uoQfMp6Z4 TNn2DdpTdQTIJdE2k5migCwVFRimgUYrKwVsM3OrHpfZGP69u6Ehmi49NhYBdwDGAmam ZEuQ== X-Gm-Message-State: AOJu0YzTQAw0STxiAazkinia2HLY0qbvDhTfr3nN2BRSyQCSSgR5fxtO KzKrPc4U+OIWD2aXNGFjJQSHhpftzJCGzUfvOnndGA2VOhiK0spHwqyOduKunL4/lpY5xFvO++9 X X-Google-Smtp-Source: AGHT+IEFSrziVS6/cMyY/h61iseUNoJ9WIdmMllnXYThsChWM57PbhUfF/xlU3bxGMosZmOpSEyKbQ== X-Received: by 2002:a17:902:c403:b0:1e8:1488:2f9a with SMTP id k3-20020a170902c40300b001e814882f9amr326189plk.30.1713387886721; Wed, 17 Apr 2024 14:04:46 -0700 (PDT) Received: from amd.. ([2804:7f0:b403:ad57:3e7c:3fff:fe7a:e83b]) by smtp.gmail.com with ESMTPSA id l9-20020a170903120900b001e3e0aa9776sm80494plh.27.2024.04.17.14.04.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Apr 2024 14:04:46 -0700 (PDT) From: Gustavo Romero To: gdb-patches@sourceware.org Cc: luis.machado@arm.com, thiago.bauermann@linaro.org, eliz@gnu.org, tom@tromey.com, gustavo.romero@linaro.org Subject: [PATCH v5 1/8] gdb: aarch64: Remove MTE address checking from get_memtag Date: Wed, 17 Apr 2024 21:04:17 +0000 Message-Id: <20240417210424.216374-2-gustavo.romero@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240417210424.216374-1-gustavo.romero@linaro.org> References: <20240417210424.216374-1-gustavo.romero@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org This commit removes aarch64_linux_tagged_address_p from aarch64_linux_get_memtag. aarch64_linux_tagged_address_p checks if an address is tagged (MTE) or not. The check is redundant because aarch64_linux_get_memtag is always called from the upper layers (i.e. from printcmd.c via gdbarch hook gdbarch_get_memtag) after either gdbarch_tagged_address_p (that already points to aarch64_linux_tagged_address_p) has been called or after should_validate_memtags (that calls gdbarch_tagged_address_p at the end) has been called, so the address is already checked. Hence: a) in print_command_1, aarch64_linux_get_memtag (via gdbarch_get_memtag hook) is called but only after should_validate_memtags, which calls gdbarch_tagged_address_p; b) in do_examine, aarch64_linux_get_memtag is also called only after gdbarch_tagged_address_p is directly called; c) in memory_tag_check_command, gdbarch_get_memtag is called -- tags matching or not -- after the initial check via direct call to gdbarch_tagged_address_p; d) in memory_tag_print_tag_command, address is checked directly via gdbarch_tagged_address_p before gdbarch_get_memtag is called. Also, because after this change the address checking only happens at the upper layer it now allows the address checking to be specialized easily per target, via a target hook. Signed-off-by: Gustavo Romero Reviewed-by: Thiago Jung Bauermann Approved-By: Luis Machado Tested-By: Luis Machado --- gdb/aarch64-linux-tdep.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c index 0b9784f38e4..50055ac3f48 100644 --- a/gdb/aarch64-linux-tdep.c +++ b/gdb/aarch64-linux-tdep.c @@ -2575,10 +2575,6 @@ aarch64_linux_get_memtag (struct gdbarch *gdbarch, struct value *address, tag = aarch64_mte_get_ltag (addr); else { - /* Make sure we are dealing with a tagged address to begin with. */ - if (!aarch64_linux_tagged_address_p (gdbarch, address)) - return nullptr; - /* Remove the top byte. */ addr = gdbarch_remove_non_address_bits (gdbarch, addr); std::optional atag = aarch64_mte_get_atag (addr);