From patchwork Tue Apr 16 14:07:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gustavo Romero X-Patchwork-Id: 88547 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E24FF3849AFA for ; Tue, 16 Apr 2024 14:09:38 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by sourceware.org (Postfix) with ESMTPS id 01F103858D37 for ; Tue, 16 Apr 2024 14:07:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 01F103858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 01F103858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::42d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713276487; cv=none; b=Lijd5vq1ClNb8H1+lj3nWAvrZYBsMNYemx9ziHe/o2Ya8Of4LTd+Xf6KkPpUQmJ3jnS/ccfcnNA055rONPWCXevCn1vzvofDkkf6It0ohQcOzVanQU3LN3A+yH3agVhPTwWJuiV5JR3x+79o34LvKui/2/BKLVI6kzjftvQdSJg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713276487; c=relaxed/simple; bh=5sDr5g7U2ywTRYm1e6GUiteL43TzBcSbyiTAO8R27Z8=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=Cs6cA7JSiR/p3+fTc2AjAX7kxvElbvOUf5rzcCyMus07Si2hKPn+OPlhq6N5HZJHeWCjVHVmfVkbZeM+yLSz1K8ufjdn7H2W7qjiW0MXDoMH+NfZDph85S52bRMIKiOoFfGVAEqEfD4aNRTx4X8btyXWOlnRIISWEZQZCUmqnkc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-6ecf1bb7f38so4049169b3a.0 for ; Tue, 16 Apr 2024 07:07:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713276471; x=1713881271; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+Udz0sOQRKXAm5kiKFSTNh5JUUjk+Jni+c5SH40tgmE=; b=VvmZsVm1kxcTn3RoWQk3gxw7w2kS280W/KuyR4q4+jQH7faleB9NFwmia1VlRGIIQp y6Iup/NtHRyWffHdHheGLe/uegTTDUmFqohLtU/6jQV8e9uVwJCqxUQxd48d2lmALKwU Hv+SvmgYLdJ7ruBQEoedib5X9sMUbFmpDbyw8axSyBabIiBbN1oxSnqUldWul/ubIgw9 FcbhSz6a68WYNw0OQr6xZXmMkl6hQvi9yfjC13gUtDCLVpzOlzezCPYD15cbelfgb+4f KlWXguZg0p187IG4Kgv4/MVzwTN61WzriDbWHIDxQLlI+ND16WwhVO2pJixXTVjGdMwI wYLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713276471; x=1713881271; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+Udz0sOQRKXAm5kiKFSTNh5JUUjk+Jni+c5SH40tgmE=; b=vroSjCwSmlikCAP7p8EoEzsXO/n49856EivtlwMAoGhkout2M3ROOf5n0Zsk2JBVg+ xq+unBsaJ5USzpSR/apHOvRtIpsCa+CarIevW6BLnsff8wy0SbQ+d9i3AnbwWWgDmg0I ATqP7bKPkpunwkr4Uzym77HlG/oNUYtJlfm9B6c87S5sB1N7luEMK2ZPujsq7U6FQ9ED lWpVXFcNoL1vlhY+IGaoB/5elMbRtTeY/rWR7SB/74q7uS7HCZpto4j19P0iyTkSTIgC KqzbcH83eDrNaxegjTmsMWmw9pNEj4hHBAI5KIGPj1C+pcMBK3yP2Kwtom1lZdrPz+v7 a7hA== X-Gm-Message-State: AOJu0Yy52lF3T/r8Pw5Tlp5hu+2CAk6urPxwHu/t5wqxT+1DnWWCObb4 WNLFtZER+Avwq4D+wChsa1M7ShxdiLIB8ziuutPzufltEfDVYCir8pGA56/6D0AuLGLMw8SnVXp dozY= X-Google-Smtp-Source: AGHT+IFdnkR+Z3JVyEHwjLEokMq5p2msGq0lSvpj0iqDv5dKVv17/x4U6jmKCh0y8OGBt1Ucf1T1/w== X-Received: by 2002:a05:6a20:9f4d:b0:1aa:584f:31b1 with SMTP id ml13-20020a056a209f4d00b001aa584f31b1mr1245938pzb.17.1713276471674; Tue, 16 Apr 2024 07:07:51 -0700 (PDT) Received: from amd.. ([2804:7f0:b403:ad57:3e7c:3fff:fe7a:e83b]) by smtp.gmail.com with ESMTPSA id o3-20020a63e343000000b005f3d54c0a57sm8937473pgj.49.2024.04.16.07.07.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 07:07:51 -0700 (PDT) From: Gustavo Romero To: gdb-patches@sourceware.org Cc: luis.machado@arm.com, thiago.bauermann@linaro.org, eliz@gnu.org, tom@tromey.com, gustavo.romero@linaro.org Subject: [PATCH v4 4/8] gdb: Use passed gdbarch instead of calling current_inferior Date: Tue, 16 Apr 2024 14:07:24 +0000 Message-Id: <20240416140728.198163-5-gustavo.romero@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240416140728.198163-1-gustavo.romero@linaro.org> References: <20240416140728.198163-1-gustavo.romero@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org In do_examine function, use passed gdbarch when checking if an address is tagged instead of calling current_inferior()->arch() to make the code more localized and help modularity by not calling a current_* function, which disguises the use of a global state/variable. There is no change in the code behavior. Signed-off-by: Gustavo Romero Suggested-by: Thiago Jung Bauermann Approved-By: Luis Machado Tested-By: Luis Machado --- gdb/printcmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/printcmd.c b/gdb/printcmd.c index 5635f605314..4edbd458e4d 100644 --- a/gdb/printcmd.c +++ b/gdb/printcmd.c @@ -1132,7 +1132,7 @@ do_examine (struct format_data fmt, struct gdbarch *gdbarch, CORE_ADDR addr) = value_from_ulongest (builtin_type (gdbarch)->builtin_data_ptr, tag_laddr); - if (gdbarch_tagged_address_p (current_inferior ()->arch (), v_addr)) + if (gdbarch_tagged_address_p (gdbarch, v_addr)) { /* Fetch the allocation tag. */ struct value *tag