From patchwork Tue Apr 16 17:05:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 88558 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E558E385841C for ; Tue, 16 Apr 2024 17:06:48 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id ABBDF3858CDB for ; Tue, 16 Apr 2024 17:05:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ABBDF3858CDB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org ABBDF3858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713287139; cv=none; b=hqQyuVQM7Sox/ZdZuS6MDtaaimD/q2v3moGVVi6ecRFYZLz9TrFkcpxBJ7N1vDa0Cps+MkfnDx2zv1Rfk1JrncaLL1/AKGpQWgoREchq8JCx5rKqvmpZWDF0orv1Cqs5mDBDjqbAP1x5k07CPY1vNtBi3frHFmNkx55eVuMskVI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713287139; c=relaxed/simple; bh=wS3b425Qa7bI23grTbVzZqdK7J8ax+tpzAGwMDQItkU=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=riu3VYzDmaNuwiLKgsVarT2JBxKZCNmZPLbL6V/I0MLAM6qz6WnIhvX+V853+ZBafoiTZ79H5I/zw8SBi8DEoHkhajpeTbykDEbo5Ean4gfKpFWfB0urr3Flrq+IhFvdu8IKZi5LmiBVHS5iju0Kq86YLPjFBkhGgJQ8dmMTYM8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6007a.ext.cloudfilter.net ([10.0.30.247]) by cmsmtp with ESMTPS id wkqBrEzGgDI6fwmFJrR5Zn; Tue, 16 Apr 2024 17:05:25 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id wmFIrQr7FVdenwmFJrUKLW; Tue, 16 Apr 2024 17:05:25 +0000 X-Authority-Analysis: v=2.4 cv=M4FLKTws c=1 sm=1 tr=0 ts=661eafd5 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=raytVjVEu-sA:10 a=Qbun_eYptAEA:10 a=QCgq-TmAIhwAw3cZ9foA:9 a=QEXdDO2ut3YA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=6qVnF0Zaqf6br03iu0EDSUKxuZdwoGjA7fUX6G7PHCc=; b=kKyvHH030Quy2r8cehia+l8mBV cJe/zeagWd3yoa20QijfLQZmWjFjuHFZn8Wf4p06tML7UHmgLAVQ32P1jWnh0QRTmcbq/0MM5o5Rw AnjB0duHF7bsGZqbZWXJhjDEc; Received: from 97-122-82-115.hlrn.qwest.net ([97.122.82.115]:36636 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rwmFI-002fVU-26 for gdb-patches@sourceware.org; Tue, 16 Apr 2024 11:05:24 -0600 From: Tom Tromey Date: Tue, 16 Apr 2024 11:05:26 -0600 Subject: [PATCH 4/5] Remove call to dwarf2_per_objfile::adjust from read_attribute_value MIME-Version: 1.0 Message-Id: <20240416-dwarf-race-relocate-2-v1-4-1fc912e95e87@tromey.com> References: <20240416-dwarf-race-relocate-2-v1-0-1fc912e95e87@tromey.com> In-Reply-To: <20240416-dwarf-race-relocate-2-v1-0-1fc912e95e87@tromey.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.13.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.82.115 X-Source-L: No X-Exim-ID: 1rwmFI-002fVU-26 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-82-115.hlrn.qwest.net ([192.168.0.21]) [97.122.82.115]:36636 X-Source-Auth: tom+tromey.com X-Email-Count: 9 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfMapM5gqygUgHzDuaQCHp2uGGY/u/tHdcYsr2NdGrrlVqdqu6gICShuqQsTRw+VsqhoSJCNw96w51ecJsx6Yt84ZDOsoCSrR+ynhiYVxV70zuQbbRhZU kcKRDHEVCZoyF806qQpQ/qe6zwkR3C6lUOVyfPCCMJ+L870LeYuZcBdVHDFfltfekoAm1yWoa0GM5rB1QRQfc5KHLlnMBiTXz0Q= X-Spam-Status: No, score=-3021.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Currently, read_attribute_value calls dwarf2_per_objfile::adjust on any address. This seems wrong, because the address may not even be in the text section. Luckily, this call is also not needed, because read_func_scope calls 'relocate', which does the same work. --- gdb/dwarf2/read.c | 1 - 1 file changed, 1 deletion(-) diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index 4168cec5c1a..731a645442d 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -17024,7 +17024,6 @@ read_attribute_value (const struct die_reader_specs *reader, { unrelocated_addr addr = cu_header->read_address (abfd, info_ptr, &bytes_read); - addr = per_objfile->adjust (addr); attr->set_address (addr); info_ptr += bytes_read; }