From patchwork Tue Apr 16 17:05:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 88556 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D72C43849AFC for ; Tue, 16 Apr 2024 17:06:29 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id 393F03858C78 for ; Tue, 16 Apr 2024 17:05:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 393F03858C78 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 393F03858C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713287132; cv=none; b=Mx87gcwS8/0AEbe2jZSGzAlzr9kl4z6HsE2wO2Yn+cL161tV8T0QOmLvqczWSvDmdBpFWaqxPzpmFZ8gi1mwL+mm6qkOXBwBzUsklM5DTxBfn2ncav7Dw7tpdndO1uDJVit9H8knlMG3N2Y962NYI4folx1rDC/ayXR82v1aIu4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713287132; c=relaxed/simple; bh=pUfAqImSoCiqA3cy6jbpg9RcKfYvv4B/eGsrLpFRH4s=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=SxzWk59SEhjFg18qKS/afp8xJzO+7OGQrwxxSP9PLxsMVpLhI4O1fZzHjUBB4KbrXepuVterxkvV5Vs3pUmMDCtCtEKkyzgSC1aGmLnYHvemBdYi+m2GMaBlg9edjjYfcN24xNaiC40fbWGaBZyftGBeiptQ9PPL5O9rO1r/1AY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6002a.ext.cloudfilter.net ([10.0.30.222]) by cmsmtp with ESMTPS id wEFUrfl6bQr4SwmFJrwggT; Tue, 16 Apr 2024 17:05:25 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id wmFIrP8zJiKqRwmFJr4Rgs; Tue, 16 Apr 2024 17:05:25 +0000 X-Authority-Analysis: v=2.4 cv=I9quR8gg c=1 sm=1 tr=0 ts=661eafd5 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=raytVjVEu-sA:10 a=Qbun_eYptAEA:10 a=nEAM0GPSK8r6wnO3_FgA:9 a=QEXdDO2ut3YA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ACYXjXY/seMjXXqMT8PwV40oSkBZKxe1yb+pgB9Xa6w=; b=N0PVMn01t2GC73wyBlit0IeGxe VxE9k5mSBw2m6PXXTim6hzgSmgDlK0nFw+TzQZ8BN/9XnF8esFKZzV6szPbE0TzYc4BlJ3f8/GQ5a tFvn9IRfwRMSN/1+2j3UcRmpY; Received: from 97-122-82-115.hlrn.qwest.net ([97.122.82.115]:36636 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rwmFI-002fVU-1h for gdb-patches@sourceware.org; Tue, 16 Apr 2024 11:05:24 -0600 From: Tom Tromey Date: Tue, 16 Apr 2024 11:05:25 -0600 Subject: [PATCH 3/5] Remove call to dwarf2_per_objfile::adjust from read_call_site_scope MIME-Version: 1.0 Message-Id: <20240416-dwarf-race-relocate-2-v1-3-1fc912e95e87@tromey.com> References: <20240416-dwarf-race-relocate-2-v1-0-1fc912e95e87@tromey.com> In-Reply-To: <20240416-dwarf-race-relocate-2-v1-0-1fc912e95e87@tromey.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.13.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.82.115 X-Source-L: No X-Exim-ID: 1rwmFI-002fVU-1h X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-82-115.hlrn.qwest.net ([192.168.0.21]) [97.122.82.115]:36636 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfKegnQDJRrFYzQXpAzBq+4vXRfT/qJDoJpMMB+ADp7oeae0elINIHlLyTBgBcUYfvwRZXU9jFHK7yN9dwvoaR6GaHtEl9vwfPT11yXiUtzrJUTEhdC6C urs5ZkRVetwiUwMyXldW5GMqAq3RR761TKy53TlmyLmkxxrIPiPY9ErPp1UcTx1Vlb+fgfJmBWaG97JBnvckXyn7n+q+XEW1/hQ= X-Spam-Status: No, score=-3021.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org read_call_site_scope does not need to call 'adjust', because in general the call site is not a symbol address, but rather just the address of some particular call. --- gdb/dwarf2/read.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index 9670f232f05..4168cec5c1a 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -10242,7 +10242,7 @@ read_call_site_scope (struct die_info *die, struct dwarf2_cu *cu) sect_offset_str (die->sect_off), objfile_name (objfile)); return; } - unrelocated_addr pc = per_objfile->adjust (attr->as_address ()); + unrelocated_addr pc = attr->as_address (); if (cu->call_site_htab == NULL) cu->call_site_htab = htab_create_alloc_ex (16, call_site::hash, @@ -10417,10 +10417,7 @@ read_call_site_scope (struct die_info *die, struct dwarf2_cu *cu) "low pc, for referencing DIE %s [in module %s]"), sect_offset_str (die->sect_off), objfile_name (objfile)); else - { - lowpc = per_objfile->adjust (lowpc); - call_site->target.set_loc_physaddr (lowpc); - } + call_site->target.set_loc_physaddr (lowpc); } } else