From patchwork Tue Apr 16 17:05:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 88554 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BE43B3846047 for ; Tue, 16 Apr 2024 17:06:14 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id 76CA4385842D for ; Tue, 16 Apr 2024 17:05:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 76CA4385842D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 76CA4385842D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713287132; cv=none; b=lpTOIuTO06BpSjj8YbyAga4cqkWD+eueu28JAvCBM3ed8bXOytDUVkhbGyfW3USv5d+gv1mbG0TQLXLnK6Lg/N11DHeKxmO4PR933dWQHINa+9xmrCWEyi+aFONCpJtEn7dEYzmkCZqtGgaJmkSOO3WHMDHl2mAgfHRHFQjwoy0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713287132; c=relaxed/simple; bh=dIWZxPXXiyew1tlbAcWpeqOWVo5h52yhxLaEjaQUJ/Y=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=FQoGWLwIkkbRG2UA70xP6gjT+MwLtuQ0tqcSdRSp1IQgmA4lmj55uz1OXE5mBEmndXLM0vIf1nvCgICf9FN/i0cWvbpoYwqEyxj2HEn7yT5tTekDKpl2DBUi1y+X/m49tI0qDrNVcZXMzzgAloXqFuOvD3mgPq6uFG2DuXozZ+M= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5004a.ext.cloudfilter.net ([10.0.29.221]) by cmsmtp with ESMTPS id wbOLrU0wrPM1hwmFJrACRG; Tue, 16 Apr 2024 17:05:25 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id wmFIrMwSkGDo0wmFIrhH9i; Tue, 16 Apr 2024 17:05:25 +0000 X-Authority-Analysis: v=2.4 cv=I+uuR8gg c=1 sm=1 tr=0 ts=661eafd5 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=raytVjVEu-sA:10 a=Qbun_eYptAEA:10 a=KXjF9NO_zwr-w4fy9k4A:9 a=QEXdDO2ut3YA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5nViKh2T4bREK0qPMxlEJCiJ8wIfdbuSNYwYBrYTlRg=; b=g7y0nTInypVHfpKCYyqaALzbTX d+puRiDXNiKsd87J+PEFBXj6GfLbtpEjcjST/8PznlMWe7fsLmRX41jQSTmc2OEx5nlF5jVP5XzlF q4AZfS1VJpDtpVwci+tIiiYKD; Received: from 97-122-82-115.hlrn.qwest.net ([97.122.82.115]:36636 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rwmFI-002fVU-0s for gdb-patches@sourceware.org; Tue, 16 Apr 2024 11:05:24 -0600 From: Tom Tromey Date: Tue, 16 Apr 2024 11:05:23 -0600 Subject: [PATCH 1/5] Remove call to dwarf2_per_objfile::adjust from ranges readers MIME-Version: 1.0 Message-Id: <20240416-dwarf-race-relocate-2-v1-1-1fc912e95e87@tromey.com> References: <20240416-dwarf-race-relocate-2-v1-0-1fc912e95e87@tromey.com> In-Reply-To: <20240416-dwarf-race-relocate-2-v1-0-1fc912e95e87@tromey.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.13.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.82.115 X-Source-L: No X-Exim-ID: 1rwmFI-002fVU-0s X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-82-115.hlrn.qwest.net ([192.168.0.21]) [97.122.82.115]:36636 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfHLgAGA0TT7ii44m7+4IXtmOUzIosdiZ1/EwqMEXZmPYiXCkr4yLIJiQ8kC2O3vubBFewfl7oTr9MYIBAGNAXowg+g4bD554b8qFtxDvw+b+CH/OKgoe qnkkgYpnCVIEjtOZpJq4d0n+40FxSg70LJgGmk2G2VUdsBk56RNnIp95RtBNmUWxQ/YvunE5C7SvCezgkMoBQ1im/YBxeoSXGiw= X-Spam-Status: No, score=-3021.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org dwarf2_per_objfile::adjust applies gdbarch_adjust_dwarf2_addr to an address, leaving the result unrelocated. However, this adjustment is only needed for text-section symbols -- it isn't needed for any sort of address mapping. Therefore, these calls can be removed from read_addrmap_from_aranges and create_addrmap_from_gdb_index. --- gdb/dwarf2/aranges.c | 2 -- gdb/dwarf2/read-gdb-index.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/gdb/dwarf2/aranges.c b/gdb/dwarf2/aranges.c index d577db62726..0d1dc11e27a 100644 --- a/gdb/dwarf2/aranges.c +++ b/gdb/dwarf2/aranges.c @@ -190,8 +190,6 @@ read_addrmap_from_aranges (dwarf2_per_objfile *per_objfile, continue; } ULONGEST end = start + length; - start = (ULONGEST) per_objfile->adjust ((unrelocated_addr) start); - end = (ULONGEST) per_objfile->adjust ((unrelocated_addr) end); mutable_map->set_empty (start, end - 1, per_cu); } diff --git a/gdb/dwarf2/read-gdb-index.c b/gdb/dwarf2/read-gdb-index.c index 8c0895b9639..cc6361674e8 100644 --- a/gdb/dwarf2/read-gdb-index.c +++ b/gdb/dwarf2/read-gdb-index.c @@ -566,8 +566,6 @@ create_addrmap_from_gdb_index (dwarf2_per_objfile *per_objfile, continue; } - lo = (ULONGEST) per_objfile->adjust ((unrelocated_addr) lo); - hi = (ULONGEST) per_objfile->adjust ((unrelocated_addr) hi); mutable_map.set_empty (lo, hi - 1, per_bfd->get_cu (cu_index)); }