From patchwork Tue Mar 19 07:44:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 87338 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EDE0D3858410 for ; Tue, 19 Mar 2024 07:44:06 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id F41ED3858CD1 for ; Tue, 19 Mar 2024 07:43:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F41ED3858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F41ED3858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710834225; cv=none; b=Tarer3bE2u2sYeE1QhhWK5AnOllFRugSJij/sqghPYr2fqgYGLKSRFqqqxKuWdOFk2zhIPN1ZLKilWDOgyvYjW0z0uPig0Wf/lQzjF1cCL12YkvDgusNoPfL0mSKRatwcs0a4QouevnxXQkPsUnGxbHNsZaJ8FjiZ2eFOcif8D4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710834225; c=relaxed/simple; bh=BaGYK/1f6CurnYMYIm6sIXXevkrwyDOU9f1RBMRpGcY=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-Id:MIME-Version; b=RvDPc1IImt6wUoRE8D3q3yPxoZpwsiDyNwr4KEh1xVTMAD70FAymOaNFHB/J4mtqh8ixs6GavJk/bNUZvOnBXAxLcdHpWi1AaCJbUjCWuUcDwYxQdRH27lh3SxpaWHu+gQGht0IMftz0lJNv7VaCq27asJgQwwpxtXGdoDSh5bQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C9E2B37498 for ; Tue, 19 Mar 2024 07:43:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1710834222; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=uEjxdh4sjp1OLSatle3sTF3bJ7FASlKGvqe4DkkDdqY=; b=wfpTQBlCcffl0flhCSsUkgirJu2JevDPGMNijvxLk7cJ6QL+Z1XIoI0aH+sDfHtpOxNg/n tU8r46wiVFHRWhrUi99T7J0RvWzHn5XVs7AKnXnfcJ86P/zzTWaw9nNZYANQGLVktDmFEC yspc+dzHPxol8+WG+qRZHbxkOVor1l0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1710834222; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=uEjxdh4sjp1OLSatle3sTF3bJ7FASlKGvqe4DkkDdqY=; b=SiPGIJHDZu+hEAFCi+wsoTRS4NQxBCv3iu3uFz/YMZwdLXFCRytVJoXBw/a0x1hDZ/ZTRM PnmaBaMV1gM8ROBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1710834222; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=uEjxdh4sjp1OLSatle3sTF3bJ7FASlKGvqe4DkkDdqY=; b=wfpTQBlCcffl0flhCSsUkgirJu2JevDPGMNijvxLk7cJ6QL+Z1XIoI0aH+sDfHtpOxNg/n tU8r46wiVFHRWhrUi99T7J0RvWzHn5XVs7AKnXnfcJ86P/zzTWaw9nNZYANQGLVktDmFEC yspc+dzHPxol8+WG+qRZHbxkOVor1l0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1710834222; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=uEjxdh4sjp1OLSatle3sTF3bJ7FASlKGvqe4DkkDdqY=; b=SiPGIJHDZu+hEAFCi+wsoTRS4NQxBCv3iu3uFz/YMZwdLXFCRytVJoXBw/a0x1hDZ/ZTRM PnmaBaMV1gM8ROBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B26D0136A5 for ; Tue, 19 Mar 2024 07:43:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id nR8cKi5C+WUCbgAAD6G6ig (envelope-from ) for ; Tue, 19 Mar 2024 07:43:42 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH] [gdb/testsuite] Add PR gdb/26967 KFAIL in two more test-cases Date: Tue, 19 Mar 2024 08:44:49 +0100 Message-Id: <20240319074449.10361-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 X-Spam-Score: -0.51 Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=wfpTQBlC; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=SiPGIJHD X-Spamd-Bar: / X-Spamd-Result: default: False [-0.51 / 50.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_MISSING_CHARSET(2.50)[]; TO_DN_NONE(0.00)[]; BROKEN_CONTENT_TYPE(1.50)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[suse.de:+]; MX_GOOD(-0.01)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-3.00)[100.00%]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCPT_COUNT_ONE(0.00)[1]; DWL_DNSWL_LOW(-1.00)[suse.de:dkim]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MID_CONTAINS_FROM(1.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from] X-Spam-Level: X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: C9E2B37498 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org On aarch64-linux (debian 12), when running test-case gdb.base/longjmp-until-in-main.exp, I run into: ... (gdb) until 33^M warning: Breakpoint address adjusted from 0x70f727c678928489 to 0xfff727c678928489.^M Warning:^M Cannot insert breakpoint 0.^M Cannot access memory at address 0xfff727c678928489^M ^M 0x0000fffff7e3a580 in siglongjmp () from /lib/aarch64-linux-gnu/libc.so.6^M (gdb) FAIL: gdb.base/longjmp-until-in-main.exp: until $line, in main ... This is PR gdb/26967: no longjmp probe is available: ... (gdb) info probes stap libc ^longjmp$^M No probes matched.^M ... and glibc applies pointer mangling which makes it fairly difficult for gdb to get the longjmp target. There's a KFAIL for this in test-case gdb.base/longjmp.exp, added in commit b5e7cd5cd3d ("[gdb/testsuite] Add KFAILs in gdb.base/longjmp.exp"). Likewise, add a KFAIL in this and one more test-case. Tested on aarch64-linux. --- .../gdb.base/longjmp-until-in-main.exp | 33 +++++++++++++++++-- .../premature-dummy-frame-removal.exp | 31 ++++++++++++++++- 2 files changed, 60 insertions(+), 4 deletions(-) base-commit: a8354784a88cab5ddc212d9d2b9d51a4abd1d12d diff --git a/gdb/testsuite/gdb.base/longjmp-until-in-main.exp b/gdb/testsuite/gdb.base/longjmp-until-in-main.exp index d755c86ed88..2a28b78d412 100644 --- a/gdb/testsuite/gdb.base/longjmp-until-in-main.exp +++ b/gdb/testsuite/gdb.base/longjmp-until-in-main.exp @@ -35,10 +35,37 @@ if {![runto_main]} { return } +set have_longjmp_probe 0 +gdb_test_multiple "info probes stap libc ^longjmp$" "" { + -re -wrap "No probes matched\\." { + pass $gdb_test_name + } + -re -wrap "\r\nstap\[ \t\]+libc\[ \t\]+longjmp\[ \t\]+.*" { + pass $gdb_test_name + set have_longjmp_probe 1 + } +} + delete_breakpoints set until_to_line [gdb_get_line_number "until to here"] -gdb_test "until $until_to_line" \ - " until to here .*" \ - "until \$line, in main" +set re_cannot_insert_bp \ + [multi_line \ + "Warning:" \ + "Cannot insert breakpoint $::decimal\\." \ + "Cannot access memory at address $::hex"] + +set test "until \$line, in main" +gdb_test_multiple "until $until_to_line" $test { + -re -wrap "\r\n$re_cannot_insert_bp\r\n.*" { + if { $have_longjmp_probe } { + fail $gdb_test_name + } else { + kfail gdb/26967 $gdb_test_name + } + } + -re -wrap " until to here .*" { + pass $gdb_test_name + } +} diff --git a/gdb/testsuite/gdb.base/premature-dummy-frame-removal.exp b/gdb/testsuite/gdb.base/premature-dummy-frame-removal.exp index 100c24aae20..a641fd66c06 100644 --- a/gdb/testsuite/gdb.base/premature-dummy-frame-removal.exp +++ b/gdb/testsuite/gdb.base/premature-dummy-frame-removal.exp @@ -49,7 +49,36 @@ if {![runto_main]} { set pyfile [gdb_remote_download host ${srcdir}/${subdir}/${testfile}.py] gdb_test_no_output "source ${pyfile}" "load python file" -gdb_test "p some_func ()" " = 0" +set have_longjmp_probe 0 +gdb_test_multiple "info probes stap libc ^longjmp$" "" { + -re -wrap "No probes matched\\." { + pass $gdb_test_name + } + -re -wrap "\r\nstap\[ \t\]+libc\[ \t\]+longjmp\[ \t\]+.*" { + pass $gdb_test_name + set have_longjmp_probe 1 + } +} + +set re_cannot_insert_bp \ + [multi_line \ + "Warning:" \ + "Cannot insert breakpoint $::decimal\\." \ + "Cannot access memory at address $::hex"] + +gdb_test_multiple "p some_func ()" "" { + -re -wrap "\r\n$re_cannot_insert_bp\r\n.*" { + if { $have_longjmp_probe } { + fail $gdb_test_name + } else { + kfail gdb/26967 $gdb_test_name + return 0 + } + } + -re -wrap " = 0" { + pass $gdb_test_name + } +} # When frame debugging is turned on, this test has (previously) # revealed some crashes due to the Python frame unwinder trying to