From patchwork Mon Feb 26 20:52:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 86402 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C02293858C35 for ; Mon, 26 Feb 2024 20:52:32 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-io1-xd31.google.com (mail-io1-xd31.google.com [IPv6:2607:f8b0:4864:20::d31]) by sourceware.org (Postfix) with ESMTPS id 9D9643858C98 for ; Mon, 26 Feb 2024 20:52:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9D9643858C98 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9D9643858C98 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d31 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708980732; cv=none; b=j5bU11jWG37g0eqtxu41vyLECh63iDYvSbJmwDBqVImUkyLxSz5E5YNd2kQoQz3HFyNqXv3xurQyr6vnIHQ28YxpMiOyr4MoviyCKWJJUGBXmKAKbWu0b0vRjneA0Pk8sSs0UsVFZcsRhmiDFF1GXf5ELOMAKQHCSVmcZpfdrCg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708980732; c=relaxed/simple; bh=jBLj837IWCL14xiuW0vnBsASNrtc3RZZwxWk5x5Lh2I=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ot+eTBztLdkVaKnQwPackhxKLyk9fRtq7E4Mmfi5X7FYJ2uzV0Ge/HQ2L9dGu8cbVXltl9Ti58AKAa9M6MrY1uSseJaDlJ6GKJi3Y6xSpyo+GsQNjkUfoa0F6x0/Jtf+x1NuS4MJ+W4BEeC08P+pLzJfy6+6oCyEFOdYgx7lWPQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd31.google.com with SMTP id ca18e2360f4ac-7c785dda899so168996939f.2 for ; Mon, 26 Feb 2024 12:52:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1708980730; x=1709585530; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=OHhEUHgZ2nCHV+7cw2syV3seXJcJHJH2AabSKk/DePE=; b=RxumAJL05EYYGMBLqLb0YCs4WdpDHfm4tJluySSz9ZpeGYg6JADECNsrPR9VaXIMC0 KovO5gDQhZcfU+aMSHKhSm/JJRYGPqMgq3LSlqreWimOQ0lW4Rkztw5UBu5khuz1Z2S9 lrJbBG4S9JbX9cAZ5K+V7jbq7rDBGL/72kvTeLhyQPM9edUSYqucy8Qlw1q5jpQ33Kbs NwHEisW+3sT071PcKEydeAmL2fLltMqVHnnXLdTijNwZoEYnvn6EieWq2p5atfjrutQq QnRWVFvKNU63yeP+lbqzelBykl9TeIAFhWZI8fwW74mmyqNnlYQ6nZ0BxWjAG0w/k+Ie gKLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708980730; x=1709585530; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OHhEUHgZ2nCHV+7cw2syV3seXJcJHJH2AabSKk/DePE=; b=j4OnAChOUWjFpsKCOikYZunfC0wN9FNpR6d7BPwAQ3UgiGx/T9+jpQj9wCk9S1PpBc NDBRNp/EvEPEgaSOzRtgj0rfaeTUcJYXPSdgnIpmKjb8QmJlCPdJD8X3P9OmaPrSlVlT r6NxmBaerU9+NZsrnksU2OTWx6iM4XoLJyTkjS5vXFdcli1DSaWYjXc3nah4Q9bivwRB rPEDK6QdMFt/bw3RsWGVf0F5Wcdc5QEsvdkEZc7kdZ5SiVlaXDWEXn+1z1nroExC2dko MoVUiwE5zjlDRj4pDG2FGtK+0k4MsxNLP7x8Jh7fCllBDwISrU46ecgb5M6hVkj4guFX r6dw== X-Gm-Message-State: AOJu0Yw0XK6P6HXD1OoNkXzcaWKbysz70FVnzTy3MXM4x5qGQkNlgGFt fQNFx6KOla8DhzXiIDG6ckzhrvoNA1Q7qin3iZRMD+QlmFhnNcsumH1JQBZyI3nhLhnBx6VCr2A = X-Google-Smtp-Source: AGHT+IHsfEYHe4+eoqMZU3j0TrBhMCBk/aCJ/pd0o3q8ujV1PIQhM/o5DhVaeZH0zzx+5HCT6Dg0CQ== X-Received: by 2002:a5e:8617:0:b0:7c7:8747:19f1 with SMTP id z23-20020a5e8617000000b007c7874719f1mr8490845ioj.21.1708980729857; Mon, 26 Feb 2024 12:52:09 -0800 (PST) Received: from localhost.localdomain (71-211-170-195.hlrn.qwest.net. [71.211.170.195]) by smtp.gmail.com with ESMTPSA id s20-20020a6bd314000000b007c45ab3dc34sm1435005iob.29.2024.02.26.12.52.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 12:52:09 -0800 (PST) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [pushed] Remove two unnecessary casts Date: Mon, 26 Feb 2024 13:52:02 -0700 Message-ID: <20240226205202.509729-1-tromey@adacore.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org I noticed a spot in ada-lang.c where the return value of value_as_address was cast to CORE_ADDR -- a no-op cast. I searched and found another. This patch fixes both. --- gdb/ada-lang.c | 2 +- gdb/eval.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c index 3f398540010..1c26ebf7b30 100644 --- a/gdb/ada-lang.c +++ b/gdb/ada-lang.c @@ -10993,7 +10993,7 @@ ada_unop_ind_operation::evaluate (struct type *expect_type, arg1)); else return value_at_lazy (builtin_type (exp->gdbarch)->builtin_int, - (CORE_ADDR) value_as_address (arg1)); + value_as_address (arg1)); } if (ada_is_array_descriptor_type (type)) diff --git a/gdb/eval.c b/gdb/eval.c index 4c438f927c0..2759b46a5df 100644 --- a/gdb/eval.c +++ b/gdb/eval.c @@ -1685,7 +1685,7 @@ eval_op_ind (struct type *expect_type, struct expression *exp, BUILTIN_TYPE_LONGEST would seem to be a mistake. */ if (type->code () == TYPE_CODE_INT) return value_at_lazy (builtin_type (exp->gdbarch)->builtin_int, - (CORE_ADDR) value_as_address (arg1)); + value_as_address (arg1)); return value_ind (arg1); }