From patchwork Sat Feb 24 09:48:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 86326 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5EC61385828A for ; Sat, 24 Feb 2024 09:49:23 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id F1029385841A for ; Sat, 24 Feb 2024 09:48:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F1029385841A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F1029385841A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708768136; cv=none; b=JPE3lvtFvGX0myly/y8oozhhgd0Be80E1llteWqAFdIncfDfWL1krHB4eBFANOMjxv0gTEomLvnVzBdm9w77TxG/B7EOvR3axjmZcneqsqthKAFu2bRmhwow46vgEGo5Sn1aVU/RJZ1tPA2JsnH8kejvrbbz2fOibk6RkV9a9Fw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708768136; c=relaxed/simple; bh=r0nkVuQKVv5gtvg853eVeJBhfSi7RxkCc21+Jo4shZ0=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-Id:MIME-Version; b=hYTG0sMzlup0FPq3zxmbVwzCezLClQzIKiczQbxsMUrUL4Qwzc4ew1emU4CcEkmpEVt8XSbHK0VhV9boXPcm5izYmwuGjdizfNvNpAWkCEKlng/Y1YBYSAegaHPuft1YV1IQqcA2how8XGvMJCxfnPLlLnjMba61nB4y6hhQykc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C608D21FFC; Sat, 24 Feb 2024 09:48:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708768132; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=W6DSJwYJaq3V5/triAu8jgFZq+QACr0UF36l1CULFl8=; b=x1vyrvs5SkAke5lNHoVbuY0wFlZSYvthjaGhlehlaTgklERyoMz5G3U8foqEQjr6n6/8ED /9kPEjrWjLE1B7ocn2cSviDp+fybvpIsbtbhfa4TMaEmuNlV9YOBbVt84XrtUHYlWMRnsj GIPSh5HmhojrcdJcpXONC86J5bBCNpg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708768132; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=W6DSJwYJaq3V5/triAu8jgFZq+QACr0UF36l1CULFl8=; b=09+FhzjC9SijRj4xCnQcxw6TNwoK1BRurW3/pktybzmrprc4ugPe0gdkU/2BcXVBtzizSo k9FbenMQWjv8VkAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708768132; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=W6DSJwYJaq3V5/triAu8jgFZq+QACr0UF36l1CULFl8=; b=x1vyrvs5SkAke5lNHoVbuY0wFlZSYvthjaGhlehlaTgklERyoMz5G3U8foqEQjr6n6/8ED /9kPEjrWjLE1B7ocn2cSviDp+fybvpIsbtbhfa4TMaEmuNlV9YOBbVt84XrtUHYlWMRnsj GIPSh5HmhojrcdJcpXONC86J5bBCNpg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708768132; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=W6DSJwYJaq3V5/triAu8jgFZq+QACr0UF36l1CULFl8=; b=09+FhzjC9SijRj4xCnQcxw6TNwoK1BRurW3/pktybzmrprc4ugPe0gdkU/2BcXVBtzizSo k9FbenMQWjv8VkAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9D80613A5C; Sat, 24 Feb 2024 09:48:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id N1ShJIS72WUKfwAAD6G6ig (envelope-from ); Sat, 24 Feb 2024 09:48:52 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] [gdb/testsuite] Dump dap.log.$n to gdb.log when exceptions found Date: Sat, 24 Feb 2024 10:48:55 +0100 Message-Id: <20240224094855.14072-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Authentication-Results: smtp-out1.suse.de; none X-Spam-Score: 3.80 X-Spamd-Result: default: False [3.80 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_MISSING_CHARSET(2.50)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; SUBJECT_HAS_CURRENCY(1.00)[]; BROKEN_CONTENT_TYPE(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; RCPT_COUNT_TWO(0.00)[2]; MID_CONTAINS_FROM(1.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-0.90)[85.99%] X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org For a patch I submitted, the Linaro CI reported a failure: ... FAIL: gdb.dap/attach.exp: exceptions in log file ... I ran the test-case locally, and observed the same FAIL in the gdb.sum file. I then wanted to confirm that I reproduced the exact same problem, but realized that I couldn't because there's no way for me to know what exception occurred, and where, because that information is logged in the dap.log.$n file, and the Linaro CI only saves the gdb.sum and gdb.log files. This issue is even worse if only the CI can reproduce a FAIL. Fix this in dap_check_log_file by dumping dap.log.$n to gdb.log when exceptions are found. Tested on x86_64-linux. --- gdb/testsuite/lib/dap-support.exp | 3 +++ 1 file changed, 3 insertions(+) base-commit: 086c8f406d82ce171d5867eed93f1308e07252c5 diff --git a/gdb/testsuite/lib/dap-support.exp b/gdb/testsuite/lib/dap-support.exp index 72c22d00711..89a4b0e0f6d 100644 --- a/gdb/testsuite/lib/dap-support.exp +++ b/gdb/testsuite/lib/dap-support.exp @@ -381,6 +381,9 @@ proc dap_check_log_file {} { if {$ok} { pass "exceptions in log file" } else { + verbose -log -- "--- DAP LOG START ---" + verbose -log -- $contents + verbose -log -- "--- DAP LOG END ---" fail "exceptions in log file" } }