From patchwork Sat Jan 20 18:23:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 84488 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id ED09238582AD for ; Sat, 20 Jan 2024 18:24:03 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id 309043858C5F for ; Sat, 20 Jan 2024 18:23:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 309043858C5F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 309043858C5F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705775001; cv=none; b=R1LYQGLtpRdljkiZn6VbXNXKXSclV+n37Qcdg40EuRmn+XOwv/MBiM3LcidB+mT7uDTOT+MXdltZVGGuMfi7R73HdGlKsxwaIdGooCNHu/He+LXggQjyvAZ77NWoY7G5FfW32/kKyvME5UMYAiGo0wOu1xSEffKjsVURQNMhku4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705775001; c=relaxed/simple; bh=8JZ4EtHcisYpGFJMAyYrXfEP/QW2FKlH+OeHFK/JnvY=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=tsGYaPvjEEyb+vxCcGnAMO5DsQndxh3EPLlGGv/xyE38UA8qfFwKgqpInftiRAvF0jrbhXAr4yo2iPWWhMS8ojxOEFp1Fu9ACIou7uEbEeVN3tbCHKKe6NAXvoVqz4N3AdAnpDnsOZ+SxTRrA6i9cyDhn3YDWNH6zExuq4da3As= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5004a.ext.cloudfilter.net ([10.0.29.221]) by cmsmtp with ESMTPS id R8iwrZf9m9gG6RG00rvSXJ; Sat, 20 Jan 2024 18:23:20 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id RFzyrd2e0KleDRFzzruI2B; Sat, 20 Jan 2024 18:23:19 +0000 X-Authority-Analysis: v=2.4 cv=KcbBDCUD c=1 sm=1 tr=0 ts=65ac0f97 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=dEuoMetlWLkA:10 a=Qbun_eYptAEA:10 a=20KFwNOVAAAA:8 a=VVPYQnLNjAP3haWqGDwA:9 a=QEXdDO2ut3YA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Cc:To:In-Reply-To:References:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ojblsao8yw0wxPva62j27lALlyV9UcrY/hYo5kPrL/s=; b=dgX+dL93MRj3MFFeu+XRBLShGI WJfh65KtHgjRRNuUNs2mYxB3iJ5NekuxNayIVsM320QJM9we+zJJSG5nZy+ZNHtWu4vlHQVxhciEu 8uEFLm3AUdV5gveipmP4HriNW; Received: from 97-122-68-157.hlrn.qwest.net ([97.122.68.157]:47898 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rRFzy-0049D4-0y; Sat, 20 Jan 2024 11:23:18 -0700 From: Tom Tromey Date: Sat, 20 Jan 2024 11:23:13 -0700 Subject: [PATCH v2 02/14] Minor C++ cleanups in tui-regs.c MIME-Version: 1.0 Message-Id: <20240120-tui-regs-cleanup-v2-2-a3cccc6a3573@tromey.com> References: <20240120-tui-regs-cleanup-v2-0-a3cccc6a3573@tromey.com> In-Reply-To: <20240120-tui-regs-cleanup-v2-0-a3cccc6a3573@tromey.com> To: gdb-patches@sourceware.org Cc: Tom de Vries , Andrew Burgess X-Mailer: b4 0.12.4 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.68.157 X-Source-L: No X-Exim-ID: 1rRFzy-0049D4-0y X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-68-157.hlrn.qwest.net ([192.168.0.21]) [97.122.68.157]:47898 X-Source-Auth: tom+tromey.com X-Email-Count: 10 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfHYUhWwCysiKeWCSKwTU2GxE2/UU01sreGvlD70kmIZ8hpjTXYyTv1sb9it+VKWAL5AHS6jjPb6t468e/aKKb9YNW3ML8JGFDaSIL70mTLKlAViZcaHc xQmuX9E5L272G5uZIVKy8TESU3EJ7nk4OXRZuKqWtGuIYZsWp7HOh1b2+LticisXKerkCR1MhOokPea7/HW9vPJNFpkoJGq2JK0= X-Spam-Status: No, score=-3022.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org This changes a couple of spots to use nullptr rather than 0, and changes an int to a bool. Tested-By: Tom de Vries Reviewed-By: Andrew Burgess --- gdb/tui/tui-regs.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/gdb/tui/tui-regs.c b/gdb/tui/tui-regs.c index 590e9e81317..f1c3e2ed9d4 100644 --- a/gdb/tui/tui-regs.c +++ b/gdb/tui/tui-regs.c @@ -173,7 +173,7 @@ tui_data_window::first_reg_element_no_inline (int line_no) const void tui_data_window::show_registers (const reggroup *group) { - if (group == 0) + if (group == nullptr) group = general_reggroup; if (target_has_registers () && target_has_stack () && target_has_memory ()) @@ -188,7 +188,7 @@ tui_data_window::show_registers (const reggroup *group) } else { - m_current_group = 0; + m_current_group = nullptr; m_regs_content.clear (); } @@ -472,9 +472,7 @@ tui_data_window::check_register_values (frame_info_ptr frame) { for (auto &&data_item_win : m_regs_content) { - int was_hilighted; - - was_hilighted = data_item_win.highlight; + bool was_hilighted = data_item_win.highlight; tui_get_register (frame, &data_item_win, data_item_win.regno,