From patchwork Sat Jan 20 18:23:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 84499 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 925F53858427 for ; Sat, 20 Jan 2024 18:25:54 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id CC11F3858431 for ; Sat, 20 Jan 2024 18:23:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CC11F3858431 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CC11F3858431 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705775005; cv=none; b=oDUqVg1Xjk9s0hja/3/s1D/lpwXloW2XWiiXKcSTOlQBYiM+CwPIS3pJUXqs8Vzc1zGwX4VDvGsrDemU1wKRSX0RndfBTyGASokoAl5dHTmp5uchEX4dT7bUOZ4OO/0ollL/myCeBCeAwSxsmKgPB6tf9dq2B+EGMSULwStbkwk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705775005; c=relaxed/simple; bh=ZnkqniglN35VfKkjHPN3LRAldptTelVQEGKfWm2o2Lk=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=C4y4/RN95ICT6WIWwinf74ReWygEqJwRAdc/XJ9sFQ5MP90C5hVqkxCCSmSar2xqLH/A++bqkjqEaYDF5pMTR9iVRJZOfjoAzKOtgHdeK6JmP/TCSTXljdhl3T0U0GVZD+ZsXJjXvBY31hHo431mzWI93JFFEHT4B9QygdDwuuU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6004a.ext.cloudfilter.net ([10.0.30.197]) by cmsmtp with ESMTPS id R8hHrXSR8MVQiRG03rUyiH; Sat, 20 Jan 2024 18:23:23 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id RG02rkWOe55BJRG02rhhky; Sat, 20 Jan 2024 18:23:22 +0000 X-Authority-Analysis: v=2.4 cv=QcR1A+Xv c=1 sm=1 tr=0 ts=65ac0f9a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=dEuoMetlWLkA:10 a=Qbun_eYptAEA:10 a=20KFwNOVAAAA:8 a=MICBDP_JAT3s7KRlVekA:9 a=QEXdDO2ut3YA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Cc:To:In-Reply-To:References:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=pTaiC1UXuDKukFUuMedD4yGukWXKKtiOLWddRflHDns=; b=kmAHdNnMHbqHU7LBg12a7HBcHk 37p1e+THuuKavcQNJA4khk0ahLSYOxL+Q96YfcsiOOvPMcdO6NMB/COvU/ySkUQ2bWc5Yk+LRLguz tS96j1N+RLc5YDbHrGXACScJk; Received: from 97-122-68-157.hlrn.qwest.net ([97.122.68.157]:47898 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rRG02-0049D4-0b; Sat, 20 Jan 2024 11:23:22 -0700 From: Tom Tromey Date: Sat, 20 Jan 2024 11:23:22 -0700 Subject: [PATCH v2 11/14] Remove redundant check from tui_refresh_frame_and_register_information MIME-Version: 1.0 Message-Id: <20240120-tui-regs-cleanup-v2-11-a3cccc6a3573@tromey.com> References: <20240120-tui-regs-cleanup-v2-0-a3cccc6a3573@tromey.com> In-Reply-To: <20240120-tui-regs-cleanup-v2-0-a3cccc6a3573@tromey.com> To: gdb-patches@sourceware.org Cc: Tom de Vries , Andrew Burgess X-Mailer: b4 0.12.4 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.68.157 X-Source-L: No X-Exim-ID: 1rRG02-0049D4-0b X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-68-157.hlrn.qwest.net ([192.168.0.21]) [97.122.68.157]:47898 X-Source-Auth: tom+tromey.com X-Email-Count: 35 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfF/aQSf6oz0t6tvE3OG7fiE0bC0RsuWfaZY4+jdoEwrQNga6Tq4JyHWeyxtoMjyvNRY+dE+cAIwmHmb2qgILMzgumxQyltXriCSdnSqSQ2czVjT7msDL vxczti/kyS7DlNgl1Wk4sQp9flUaTYuA/evB7r/cwLpMibfoyC+uitohlTU8spEk3yKdW7S1kSktgQYsMlLAh1EUyAzdmS8qqNY= X-Spam-Status: No, score=-3022.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org tui_refresh_frame_and_register_information checks 'from_stack' in a block that's already guarded by a 'from_stack' check. This patch removes the redundant check. Tested-By: Tom de Vries Reviewed-By: Andrew Burgess --- gdb/tui/tui-hooks.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/gdb/tui/tui-hooks.c b/gdb/tui/tui-hooks.c index 3a4eda91aa3..fc7ffb4f202 100644 --- a/gdb/tui/tui-hooks.c +++ b/gdb/tui/tui-hooks.c @@ -132,11 +132,10 @@ tui_refresh_frame_and_register_information () /* Display the frame position (even if there is no symbols or the PC is not known). */ - bool frame_info_changed_p = tui_show_frame_info (fi); + tui_show_frame_info (fi); /* Refresh the register window if it's visible. */ - if (tui_is_window_visible (DATA_WIN) - && (frame_info_changed_p || from_stack)) + if (tui_is_window_visible (DATA_WIN)) TUI_DATA_WIN->check_register_values (fi); } else if (!from_stack)