From patchwork Sat Jan 20 18:23:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 84494 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A8EBE3858408 for ; Sat, 20 Jan 2024 18:25:09 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id F3A8C3858419 for ; Sat, 20 Jan 2024 18:23:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F3A8C3858419 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F3A8C3858419 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705775005; cv=none; b=XA7cP0fw5POXyYig2QlHA8nzh2AM3X99Cpi9qxuf7+ODrXLKuCcsAIVLjRuGSPPm0FhpQi9jVzI+IUXjDbxK947Waj7/eKHS4iqL+q8g5x5J9uBoWKodCLqSQWiur9HoZNDzlnqi1QB4csjDM2VRAzzGCYBUKfvriWegtAwyWMI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705775005; c=relaxed/simple; bh=+HnYirxrXyYUkHIezhpl7y0Cv5XVqB7U4fsOlo9zoHw=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=Epi6QTfj7z5Ja8gfKvq+Hk+t8FABAdJeRBQlTw46/jhjAXe2JAHEqpcl5ppA428dz0KtkEx38iUBPVmkUnEj5nGPvpDJUoYGeev+vnywvkz7GXqHkn8w2qKVzAPl5F7inFaTIOO6jqyAffy+A696UuTNoDeFG++1eoZY/VOkJ64= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6007a.ext.cloudfilter.net ([10.0.30.247]) by cmsmtp with ESMTPS id QymJra2s0THHuRG02rPtvv; Sat, 20 Jan 2024 18:23:22 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id RG02rChT0yxR5RG02rjHxL; Sat, 20 Jan 2024 18:23:22 +0000 X-Authority-Analysis: v=2.4 cv=JYOvEGGV c=1 sm=1 tr=0 ts=65ac0f9a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=dEuoMetlWLkA:10 a=Qbun_eYptAEA:10 a=20KFwNOVAAAA:8 a=RIfyzMFPzM5F-XPammcA:9 a=QEXdDO2ut3YA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Cc:To:In-Reply-To:References:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4h73+NrBmJRB3LheF/+pqZ4XXurwMsQNcUazyQqIbcU=; b=Z335z0wml1LKc33KRn5i7FpQx4 EjiI2k0UNScnVmnsYRcLw7GhcGcd9gqh0sVPv8rKMODCClUeMsX0TEl5+FdJ6Y2QUjRBlrf8pKwDm QrCy+C6ZoWzDem8HX72a8/4aP; Received: from 97-122-68-157.hlrn.qwest.net ([97.122.68.157]:47898 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rRG01-0049D4-2M; Sat, 20 Jan 2024 11:23:21 -0700 From: Tom Tromey Date: Sat, 20 Jan 2024 11:23:21 -0700 Subject: [PATCH v2 10/14] Remove tui_refreshing_registers MIME-Version: 1.0 Message-Id: <20240120-tui-regs-cleanup-v2-10-a3cccc6a3573@tromey.com> References: <20240120-tui-regs-cleanup-v2-0-a3cccc6a3573@tromey.com> In-Reply-To: <20240120-tui-regs-cleanup-v2-0-a3cccc6a3573@tromey.com> To: gdb-patches@sourceware.org Cc: Tom de Vries , Andrew Burgess X-Mailer: b4 0.12.4 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.68.157 X-Source-L: No X-Exim-ID: 1rRG01-0049D4-2M X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-68-157.hlrn.qwest.net ([192.168.0.21]) [97.122.68.157]:47898 X-Source-Auth: tom+tromey.com X-Email-Count: 32 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfCVKHeURaQYMgDUGiF4WhChg5lDy68NbR4b3ELflv86UzveEQDWi3ALV70XRhzHODW+k2ERmJxEWY1dUBuzTHJtb/yHvIBdUc3sZlsLqmrrGuFc1ThZS jxFsHdi+MRBPiDCeUmUSuNWmJ4ME5eVdB92lH/31W37t1hRFaEaRsl8+H40K735acXgqd9f9njjKxTnSQPXxVaNf0QuEc8xYBIo= X-Spam-Status: No, score=-3022.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org The comment by tui_refreshing_registers mentions a hook that no longer exists. However, maybe the comment is wrong. The code paths touching tui_refreshing_registers can only be called in two places: 1. From the before_prompt observer. This is only called when a prompt is about to be displayed. 2. From the register_changed observer. This is only called when value_assign changes a register value. From this it seems clear that the recursion case here cannot in fact occur. This patch removes the variable. Tested-By: Tom de Vries Reviewed-By: Andrew Burgess --- gdb/tui/tui-hooks.c | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/gdb/tui/tui-hooks.c b/gdb/tui/tui-hooks.c index bd8f99b786b..3a4eda91aa3 100644 --- a/gdb/tui/tui-hooks.c +++ b/gdb/tui/tui-hooks.c @@ -63,9 +63,6 @@ static void tui_all_objfiles_removed (program_space *pspace) { tui_on_objfiles_changed (); } -/* Prevent recursion of deprecated_register_changed_hook(). */ -static bool tui_refreshing_registers = false; - /* Observer for the register_changed notification. */ static void @@ -82,12 +79,7 @@ tui_register_changed (frame_info_ptr frame, int regno) up in the other. So we always use the selected frame here, and ignore FRAME. */ fi = get_selected_frame (NULL); - if (!tui_refreshing_registers) - { - tui_refreshing_registers = true; - TUI_DATA_WIN->check_register_values (fi); - tui_refreshing_registers = false; - } + TUI_DATA_WIN->check_register_values (fi); } /* Breakpoint creation hook. @@ -145,11 +137,7 @@ tui_refresh_frame_and_register_information () /* Refresh the register window if it's visible. */ if (tui_is_window_visible (DATA_WIN) && (frame_info_changed_p || from_stack)) - { - tui_refreshing_registers = true; - TUI_DATA_WIN->check_register_values (fi); - tui_refreshing_registers = false; - } + TUI_DATA_WIN->check_register_values (fi); } else if (!from_stack) {