Message ID | 20240118-submit-domain-hacks-2-v2-5-aecab29fa104@tromey.com |
---|---|
State | New |
Headers |
Return-Path: <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3C9FC385829B for <patchwork@sourceware.org>; Thu, 18 Jan 2024 20:33:04 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id 9F7153858C74 for <gdb-patches@sourceware.org>; Thu, 18 Jan 2024 20:32:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9F7153858C74 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9F7153858C74 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705609933; cv=none; b=B6KZIfFGaLaaWShDKheUIGqN4c8Tu63pfdTxZKpCMDSkknZkEDEzDm5u7ZngG6t/WBatDgPadrbUCdNh8dnR5U7poEaW/iQZIx9Pv4XLQ4dqWdhpLt8gwmP6t7rTfKDFxsoCWng99uGmt/0MFwS8FmYxG8Z3xzFj3TZfv2ux5Sg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705609933; c=relaxed/simple; bh=hQEhJrKqm9rN6UI+KYwAw+5024426lrNfdE3DVggwEU=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=bEkZuZdSsoTcvjBb/QBcCYUiFKye5UfPYt9CX3KIeoBYA2SOj2VXCqRM+mt5mIU8tjy5BWcPFlb/0fhyMBB1QQwJ1MbaHQLjWstZC5xYpHC5dxJMVeXxMSv0ELC2CqWcq/ptOcmRR/yQdOv12VcP+LGoK9jQ5zD9muKKwqD/BLY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6006a.ext.cloudfilter.net ([10.0.30.182]) by cmsmtp with ESMTPS id QS04rGmNt8uLRQZ3Zrw3AD; Thu, 18 Jan 2024 20:32:09 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id QZ3YrG48xYjq0QZ3YrfHaE; Thu, 18 Jan 2024 20:32:08 +0000 X-Authority-Analysis: v=2.4 cv=afxyIDkt c=1 sm=1 tr=0 ts=65a98ac8 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=dEuoMetlWLkA:10 a=Qbun_eYptAEA:10 a=pfhLtNyfPs45aFG1YTEA:9 a=QEXdDO2ut3YA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=cy3tp7beAVodUpmYjflV0cYVItki3TESwl0+ZHwFNws=; b=A5CxqoUkxzJG6KLoe4qPqGSKjR Q+8Acv9HL43JZZEQi0y2ieOeBb5ze41iyVcY9WoYNxFy8L92sPXXqjEhAmlYTL4uR5pwGhxCvMhxE oyDVih+/p0vojWKuBmt6tx5Ll; Received: from 97-122-68-157.hlrn.qwest.net ([97.122.68.157]:50746 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from <tom@tromey.com>) id 1rQZ3Y-002DCj-0V for gdb-patches@sourceware.org; Thu, 18 Jan 2024 13:32:08 -0700 From: Tom Tromey <tom@tromey.com> Date: Thu, 18 Jan 2024 13:32:03 -0700 Subject: [PATCH v2 05/30] Fix latent bug in mdebugread.c MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240118-submit-domain-hacks-2-v2-5-aecab29fa104@tromey.com> References: <20240118-submit-domain-hacks-2-v2-0-aecab29fa104@tromey.com> In-Reply-To: <20240118-submit-domain-hacks-2-v2-0-aecab29fa104@tromey.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.4 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.68.157 X-Source-L: No X-Exim-ID: 1rQZ3Y-002DCj-0V X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-68-157.hlrn.qwest.net ([192.168.0.21]) [97.122.68.157]:50746 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfPtBgB/fgCQmvn9so8JKbS4v52r7toqOcsnK0hVmdp/3WdpKrUvOBCgNz96knccz/ZAZXf76HoCVGH7n6UZ2+7KwLQv2N/rirkiwuSKN97UMye5fVVHM VAMmlEX0XdRs3CLdRIcEM9oAwL3k+LApsoKG4HOUyvDPKePlT90DpIJXxInHCggc+gi/4irnqpZ2XVZHt3R8kpQeqXy+enZykls= X-Spam-Status: No, score=-3022.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=subscribe> Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org |
Series |
Restructure symbol domains
|
|
Commit Message
Tom Tromey
Jan. 18, 2024, 8:32 p.m. UTC
mdebugread.c makes a label symbol but puts it into VAR_DOMAIN. I think LABEL_DOMAIN is more appropriate. I don't have a way to test this. --- gdb/mdebugread.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/mdebugread.c b/gdb/mdebugread.c index 73df0ed8165..13c9401d171 100644 --- a/gdb/mdebugread.c +++ b/gdb/mdebugread.c @@ -711,7 +711,7 @@ parse_symbol (SYMR *sh, union aux_ext *ax, char *ext_sh, int bigend, case stLabel: /* label, goes into current block. */ s = new_symbol (name); - s->set_domain (VAR_DOMAIN); /* So that it can be used */ + s->set_domain (LABEL_DOMAIN); /* So that it can be used */ s->set_aclass_index (LOC_LABEL); /* but not misused. */ s->set_section_index (section_index); s->set_value_address (sh->value);