[v2,14/30] Remove a check of VAR_DOMAIN

Message ID 20240118-submit-domain-hacks-2-v2-14-aecab29fa104@tromey.com
State New
Headers
Series Restructure symbol domains |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 fail Patch failed to apply
linaro-tcwg-bot/tcwg_gdb_build--master-arm fail Patch failed to apply

Commit Message

Tom Tromey Jan. 18, 2024, 8:32 p.m. UTC
  completion_list_add_symbol checks that the returned symbol has
VAR_DOMAIN, but also checks that its address class is LOC_BLOCK.  The
domain check is redundant -- only functions can possibly be LOC_BLOCK
-- and leaving this in place will cause a regression when combined
with a later patch in this series.  This patch preemptively removes
the redundant check.
---
 gdb/symtab.c | 1 -
 1 file changed, 1 deletion(-)
  

Patch

diff --git a/gdb/symtab.c b/gdb/symtab.c
index 7c56dbadf8c..76a771b1166 100644
--- a/gdb/symtab.c
+++ b/gdb/symtab.c
@@ -5631,7 +5631,6 @@  completion_list_add_symbol (completion_tracker &tracker,
      the msymbol name and removes the msymbol name from the completion
      tracker.  */
   if (sym->language () == language_cplus
-      && sym->domain () == VAR_DOMAIN
       && sym->aclass () == LOC_BLOCK)
     {
       /* The call to canonicalize returns the empty string if the input