From patchwork Wed Dec 20 15:52:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 82596 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 92877385F028 for ; Wed, 20 Dec 2023 15:52:31 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 55E7B3858CD1 for ; Wed, 20 Dec 2023 15:52:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 55E7B3858CD1 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 55E7B3858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703087538; cv=none; b=HnHv/iFlP5pI8gFsmFibckOlbJQcUUKYCbQN+T7s3YG/qZLM1Y98eodgwidtcfbRep/3FmMEO622SGzLvUUAYbzLbA+7l2lc0Qx82CsO2eKvh5FZd1dT8VQn2K1qbk4dnYXhvvD5DI7jp7F5busH/du0AUy22CvngopqxLjTjaY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703087538; c=relaxed/simple; bh=KWHErrf5jpvH7/fPVh8CWJsZnUMO7jTLC74iZRgS6lA=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=ijZqZSQoxlWBbmUkRujJJV3NbCjuXiSfZuk+EtPu3LC5z+lkxK0GyBeBcofx666i7HEq3CMGt9lBfzpvou50WM6PfW5s/Dt5ZMWmtkjeUdmkdd+T/V9Ma0CUY8B4o2VO8PXgK53p007MnWMVDTwDYXI2faK7ay6+doHaYjwKZiY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from smarchi-efficios.internal.efficios.com (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 6D5011E0AC; Wed, 20 Dec 2023 10:52:15 -0500 (EST) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [pushed] gdb: remove stale comment and ctor in gdbarch_info Date: Wed, 20 Dec 2023 10:52:13 -0500 Message-ID: <20231220155214.199283-1-simon.marchi@efficios.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Spam-Status: No, score=-3496.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_NONE, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_SOFTFAIL, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org tdesc_data is not part of a union, since commit 4f3681cc3361 ("Fix thread's gdbarch when SVE vector length changes"). Remove the stale comment and constructor. Change-Id: Ie895ce36614930e8bd9c4967174c8bf1b321c503 --- gdb/gdbarch.h | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) base-commit: 1c354ebcbacada00db94e8563eca2c73df2096b4 diff --git a/gdb/gdbarch.h b/gdb/gdbarch.h index 82d42c9d2208..cc0be16c0417 100644 --- a/gdb/gdbarch.h +++ b/gdb/gdbarch.h @@ -232,12 +232,6 @@ struct gdbarch_list struct gdbarch_info { - gdbarch_info () - /* Ensure the union is zero-initialized. Relies on the fact that there's - no member larger than TDESC_DATA. */ - : tdesc_data () - {} - const struct bfd_arch_info *bfd_arch_info = nullptr; enum bfd_endian byte_order = BFD_ENDIAN_UNKNOWN; @@ -247,7 +241,7 @@ struct gdbarch_info bfd *abfd = nullptr; /* Architecture-specific target description data. */ - struct tdesc_arch_data *tdesc_data; + struct tdesc_arch_data *tdesc_data = nullptr; enum gdb_osabi osabi = GDB_OSABI_UNKNOWN;