From patchwork Tue Nov 21 03:53:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 80393 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C63973858436 for ; Tue, 21 Nov 2023 03:53:46 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id 2362C3858D39 for ; Tue, 21 Nov 2023 03:53:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2362C3858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2362C3858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700538802; cv=none; b=aDmkanlPIkr90/xMe0t28ExyMhgUrgiifaBAk6YOfbDRMltkhf5bqd8JLsPS2yXAHK+nBCie6dN6KlibgBHSWzgPBgoN2g8travVJbp3IcfxebwDP38ql82YGWZaCZtpFbgVyQhTPW/ymdRh+JVcV+ivN/CLfqsWX9CPhKp0ARc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700538802; c=relaxed/simple; bh=cUcCYzXzQ0XfeNhyFLGLoJeKK5ZdRW+wdskIfFAdJec=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=W6uHCdTzyioBQhr8Gz3MClrEH3dOKAl34cbGCGm11AMJq+acnoJAPlv0/D43eMAYB6BYBlJC3AhofAfJc9Zc7uQx++8QNJHpxxWHFvXR1X/xkZcvK2FVodnZlHY51O3jKhGl4vzR/RfXgFaJ4rPSp5ZqSHS4H4ymW0RG45lr4+k= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5001a.ext.cloudfilter.net ([10.0.29.139]) by cmsmtp with ESMTPS id 5BpyrnKQ7WcCI5Hp9rZVLH; Tue, 21 Nov 2023 03:53:19 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 5Hp9rCu7skTVW5Hp9r6qRx; Tue, 21 Nov 2023 03:53:19 +0000 X-Authority-Analysis: v=2.4 cv=a58jSGeF c=1 sm=1 tr=0 ts=655c29af a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=BNY50KLci1gA:10 a=Qbun_eYptAEA:10 a=1fc2yS3rMq-BXBd_2S0A:9 a=QEXdDO2ut3YA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=wABP52SOZiYBYYmWsUAT2+kuWPqwpduV2EHG3hmDDFo=; b=SbYujns2X3F1RP25xSzalPMeeN MzYSj3xB9zrN2f0wJ0Tm/wDlV5YzFUQJGjFNfTcoqF9v7Nt2tuM/I5/8VfAeZcCxITXv+gQWbcKlg 3SIAynGvn3DORQK0b67cR4gQq; Received: from 97-122-77-73.hlrn.qwest.net ([97.122.77.73]:47856 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1r5Hp9-0040be-00 for gdb-patches@sourceware.org; Mon, 20 Nov 2023 20:53:19 -0700 From: Tom Tromey Date: Mon, 20 Nov 2023 20:53:36 -0700 Subject: [PATCH 05/29] Give names to unspecified types MIME-Version: 1.0 Message-Id: <20231120-submit-domain-hacks-2-v1-5-29650d01b198@tromey.com> References: <20231120-submit-domain-hacks-2-v1-0-29650d01b198@tromey.com> In-Reply-To: <20231120-submit-domain-hacks-2-v1-0-29650d01b198@tromey.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.4 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.77.73 X-Source-L: No X-Exim-ID: 1r5Hp9-0040be-00 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-77-73.hlrn.qwest.net ([192.168.0.21]) [97.122.77.73]:47856 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfOZw1r9TPullGFA6yDiVfNWHH0HtsiCJrs9bOJRp8z8969CDaCScYGGqSK2PJhDafkwaGKIl6DE0CFQQTSuaYIroPXfu+8tgbzgvMDekcXooYVohaOvz tAOun3XGaO/+vkn6/Rt9itbcKSwllnMs9NTn4HgTq1/fQJnq2zT7CaYjlFRllD/txD+4hnz1S/Lgu/IY99xnxRLIONPIksU3h6Q= X-Spam-Status: No, score=-3024.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org A patch later in this series will change check_typedef to also look in the type domain. This change by itself caused a regression, but one that revealed some peculiar behavior. The regression is in nullptr_t.exp, where examining a std::nullptr_t will change from the correct: typedef decltype(nullptr) std::nullptr_t; to typedef void std::nullptr_t; Right now, the DWARF reader marks all unspecified types as stub types. However, this interacts weirdly with check_typedef, which currently does not try to resolve types -- only struct-domain objects. My first attempt here was to fix this by changing void types not to be stub types, as I didn't see what value that provided. However, this caused another regression, because call_function_by_hand_dummy checks for stub-ness: if (values_type == NULL || values_type->is_stub ()) values_type = default_return_type; I'm not really sure why it does this rather than check for TYPE_CODE_VOID. While looking into this, I found another oddity: the DWARF reader correctly creates a type named 'decltype(nullptr)' when it seems a DW_TAG_unspecified_type -- but it creates a symbol named "void" instead. This patch changes the DWARF reader to give the symbol the correct name. This avoids the regression. --- gdb/dwarf2/read.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index d0c21967809..aa44d19b517 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -6541,6 +6541,7 @@ process_die (struct die_info *die, struct dwarf2_cu *cu) case DW_TAG_subrange_type: case DW_TAG_generic_subrange: case DW_TAG_typedef: + case DW_TAG_unspecified_type: /* Add a typedef symbol for the type definition, if it has a DW_AT_name. */ new_symbol (die, read_type_die (die, cu), cu);