From patchwork Tue Nov 21 03:53:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 80396 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AC049385843B for ; Tue, 21 Nov 2023 03:54:16 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id F39B13858C42 for ; Tue, 21 Nov 2023 03:53:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F39B13858C42 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F39B13858C42 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700538804; cv=none; b=NDfqx6iA+8fdPEeNwilldllcCBx1a3RUWIVVHu3/lJ6E6po8jCvX+20u7VdLd8RgtZogzo32TxNyEV8XUR3zBoSusJ7LRCj1ZmoSTrQ3HXRBjAShXjEqaONYV2WW0ebXYrJ6Qft6oCcdPQWX5Wrwp1wKBHGCdFyWBObxAUKrOOo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700538804; c=relaxed/simple; bh=q9NqVWLXihYZkZRj1EFgSeyEC6EJrhnOd/kcsP6Ho9s=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=pFlZbDZ6XHnC6rpDNn7+jBHAu7mb1Q6uS03eGijQL1Owtlq+HmAtUxHcrGuLsasrM9XXK3Sdzkc6sjSaUI5kv6lbzPe5Fwr+rmqkrB/NhCAjlvIm1KVpBVBjkPq6owdFZC6ru50noexxCJMIqUN8UHl0NMgIo+Z0PIgq9EwSD7o= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5003a.ext.cloudfilter.net ([10.0.29.159]) by cmsmtp with ESMTPS id 5BpmrSOJM8Hte5Hp9rHZWA; Tue, 21 Nov 2023 03:53:19 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 5Hp8rBK9GnCfv5Hp9rIOMC; Tue, 21 Nov 2023 03:53:19 +0000 X-Authority-Analysis: v=2.4 cv=KKpJsXJo c=1 sm=1 tr=0 ts=655c29af a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=BNY50KLci1gA:10 a=Qbun_eYptAEA:10 a=B_Tv2JfvxkIVyvo0GuEA:9 a=QEXdDO2ut3YA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=lXSv5FX6HR2vHVE7LSOct9FQnlLcuLQwyVC3I9CG6KI=; b=juSgEIOONxcSdClGo+SaUNzPHX H6wREyFKTV9pVfxpD5/eYAM3DarSqMRwaM7A2kVxnjzK1zTK29c8KulOavOcfqzgiKGhQfh6Q+aoY n/7QPzFyu7wVAgrR1EgTJ9zwj; Received: from 97-122-77-73.hlrn.qwest.net ([97.122.77.73]:47856 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1r5Hp8-0040be-1r for gdb-patches@sourceware.org; Mon, 20 Nov 2023 20:53:18 -0700 From: Tom Tromey Date: Mon, 20 Nov 2023 20:53:33 -0700 Subject: [PATCH 02/29] Small cleanup in DWARF reader MIME-Version: 1.0 Message-Id: <20231120-submit-domain-hacks-2-v1-2-29650d01b198@tromey.com> References: <20231120-submit-domain-hacks-2-v1-0-29650d01b198@tromey.com> In-Reply-To: <20231120-submit-domain-hacks-2-v1-0-29650d01b198@tromey.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.4 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.77.73 X-Source-L: No X-Exim-ID: 1r5Hp8-0040be-1r X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-77-73.hlrn.qwest.net ([192.168.0.21]) [97.122.77.73]:47856 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfH1GAvlYAvLr6qxhVgmJvJ3lw/HwV0sI2dy+Z4Vq65lCWElMX5x0jxf/c7NWSyJ5OmuKT6jd/ivoJtNidGaG5Jd5DR8P+Vrqx5uxfX8I0ItIQVPkjWCf OGjw/kMKJAazAskR6inOOz6BPpiiEu//Zx2O4cXq9AlQrxrtIJ5kuqfxPuMAvEXFVKo2kaJVRMQ0YwY4fg34Vk0PxjTwPdphvg0= X-Spam-Status: No, score=-3023.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_STOCKGEN, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org I noticed a couple of spots in the dwarf/read.c:new_symbol that call add_symbol_to_list. However, this function is generally written to set list_to_add, and then have a single call to add_symbol_to_list at the end. This patch cleans up this discrepancy. Note that new_symbol is overlong and should probably be split up. --- gdb/dwarf2/read.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index 1aca36e6179..d0c21967809 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -18968,7 +18968,7 @@ new_symbol (struct die_info *die, struct type *type, struct dwarf2_cu *cu, sym->set_aclass_index (LOC_OPTIMIZED_OUT); sym->set_type (builtin_type (objfile)->builtin_core_addr); sym->set_domain (LABEL_DOMAIN); - add_symbol_to_list (sym, cu->list_in_scope); + list_to_add = cu->list_in_scope; break; case DW_TAG_subprogram: /* SYMBOL_BLOCK_VALUE (sym) will be filled in later by @@ -19293,7 +19293,7 @@ new_symbol (struct die_info *die, struct type *type, struct dwarf2_cu *cu, case DW_TAG_common_block: sym->set_aclass_index (LOC_COMMON_BLOCK); sym->set_domain (COMMON_BLOCK_DOMAIN); - add_symbol_to_list (sym, cu->list_in_scope); + list_to_add = cu->list_in_scope; break; default: /* Not a tag we recognize. Hopefully we aren't processing