From patchwork Mon Nov 13 15:04:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pedro Alves X-Patchwork-Id: 79749 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DCEC53845178 for ; Mon, 13 Nov 2023 15:06:29 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by sourceware.org (Postfix) with ESMTPS id 135C83834169 for ; Mon, 13 Nov 2023 15:05:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 135C83834169 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 135C83834169 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699887906; cv=none; b=VVBpTb9l/iCGDsltVrY0apiOYoiOI3tWy5fLK8jEUDv9YcioJMJCJty1SaEYHMtMJsG7tGyX3hOsKLecoD5CJ/gz7NHde59a2V/tTi8KudXrfyhsdQmcKnc6oZDY32k8aqebX0XVMatUNPKR95oIAHvt/32FF2vk++CfCPFy2pU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699887906; c=relaxed/simple; bh=/DB77xX9WU0HYfvdnmo2MIbtev5VHGauvS4tyrJqMZU=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=tS//PE5ijsN1IvicAWpjG9mb6tm5E55VO/3hFbCeXKbRrxNIh5VTKu6t+N3PFJ3BPXmi6wusI/4zyoiZTs1LLh0me5zzlbVWfMwOtitk0wmJzBAZKPhNET6LyJ+njy2LVi+8+HIQf7IoPwiXO0rIcDEUJnCl3PxxPJFbXWylk24= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-408382da7f0so37691245e9.0 for ; Mon, 13 Nov 2023 07:05:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699887903; x=1700492703; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1zfj53tnf+H/INhyIo+41v1Nl2BdIWQtApzJ6lWoIQA=; b=GZsN52Cmm12LiJ80eQ3QAaJeUXyFM2CrhB1NGwzzAs81xa+E3hMam6M0O5bIOMJaou 4q4M5XwWzYvdB2TqfI2Br8dhEqbYfGAL1lurdMeow2DTkcDyHg1FcQOQJ/e3gjMuYv7n by4bovl/9DO7JnkEealhs3orFQOH60UrMPGfHBuCK2zXL/sbCUwe5nz4V494NLP3Tzxv KFQx/7rwMkcHm+0dcGTbo9PaQreU7AXhl7YEIIO32RhXKpmK01FNG3Pai3Fg4wzCa7o0 VOyKbmWzABNGtdKKsYuwMfSt5ZoxwtOZ1Z/V/FgXw3jTOFUSFfqcdiYNezpYjGAhSyaH wpWg== X-Gm-Message-State: AOJu0YxC9Q0LYvwfmccEYEuDptCLJoVyjp1nsi4QWeq1uN/FW7iY0EgJ bEE+qA91DnzxPY+Sx4oCowRZhkRwxCo= X-Google-Smtp-Source: AGHT+IHTf3XltLN2ZDAI/hwaF/ezgBDssM7psSlaeF9i56IBUaEFOyLKEuZz8oKvagzSE5PfdU1uug== X-Received: by 2002:a05:600c:4fc5:b0:408:2b:3ae with SMTP id o5-20020a05600c4fc500b00408002b03aemr4953685wmq.6.1699887902435; Mon, 13 Nov 2023 07:05:02 -0800 (PST) Received: from localhost ([2001:8a0:f91e:1a00:8060:1e54:fb28:9635]) by smtp.gmail.com with UTF8SMTPSA id n35-20020a05600c3ba300b0040772934b12sm14269670wms.7.2023.11.13.07.05.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Nov 2023 07:05:01 -0800 (PST) From: Pedro Alves To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [FYI/pushed v4 05/25] Avoid duplicate QThreadEvents packets Date: Mon, 13 Nov 2023 15:04:07 +0000 Message-Id: <20231113150427.477431-6-pedro@palves.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231113150427.477431-1-pedro@palves.net> References: <20231113150427.477431-1-pedro@palves.net> MIME-Version: 1.0 X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Similarly to QProgramSignals and QPassSignals, avoid sending duplicate QThreadEvents packets. Approved-By: Andrew Burgess Change-Id: Iaf5babb0b64e1527ba4db31aac8674d82b17e8b4 --- gdb/remote.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/gdb/remote.c b/gdb/remote.c index 8c7979ce6a6..2a460f6f57a 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -529,6 +529,10 @@ class remote_state the target know about program signals list changes. */ char *last_program_signals_packet = nullptr; + /* Similarly, the last QThreadEvents state we sent to the + target. */ + bool last_thread_events = false; + gdb_signal last_sent_signal = GDB_SIGNAL_0; bool last_sent_step = false; @@ -15010,6 +15014,9 @@ remote_target::thread_events (int enable) if (m_features.packet_support (PACKET_QThreadEvents) == PACKET_DISABLE) return; + if (rs->last_thread_events == enable) + return; + xsnprintf (rs->buf.data (), size, "QThreadEvents:%x", enable ? 1 : 0); putpkt (rs->buf); getpkt (&rs->buf); @@ -15019,6 +15026,7 @@ remote_target::thread_events (int enable) case PACKET_OK: if (strcmp (rs->buf.data (), "OK") != 0) error (_("Remote refused setting thread events: %s"), rs->buf.data ()); + rs->last_thread_events = enable; break; case PACKET_ERROR: warning (_("Remote failure reply: %s"), rs->buf.data ());