From patchwork Fri Oct 20 19:15:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 78287 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 362CC3852764 for ; Fri, 20 Oct 2023 19:16:39 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by sourceware.org (Postfix) with ESMTPS id C35B13857031 for ; Fri, 20 Oct 2023 19:16:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C35B13857031 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C35B13857031 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d2d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697829364; cv=none; b=K21BgBlEKrjDqG00k9TSc+Hynno4SpuEc0943h5D3BsgTFoDmaBQSvhE9azlD6EpfPyJ75HH8Zo8ltXXnUckEcE9DMe51H4OJ70TYKl/43l88WAljqVeQkvGUc1HE6hOabjFRpaYCLSDxlpKzEnZiYr0P1/QbUGWUKIjV1jBg5Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697829364; c=relaxed/simple; bh=UlXyaUB6KcHspkqM5i7e4y3JdK7k1Sn6JwTUXshvgDM=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=o1gMU/nb67oqO0M3WZ5wxHFqdAVvdJohX5S6a1Ma5IQ+1iiQO7RuAQRauCupQkjwo21K/Ld/EOUa4D6sZBFtS+CKje/XSI6g1s7VQ2p8UBsZJPxM7ZPnSIE/gAV/z7Hh/q/1KWUeWRPDQEhav7meeBIuM4puqGy/IcjwuUQZutE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd2d.google.com with SMTP id ca18e2360f4ac-7a696f358bbso42054439f.2 for ; Fri, 20 Oct 2023 12:16:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1697829362; x=1698434162; darn=sourceware.org; h=to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ZVy3x+Yx0c/AClGDDaFX3+f93DT1qFSojepfkUE0VqU=; b=E6FmX2AGBlGqCTgggrrgLbabficrjRwK4J8Qeo3jLovo84ivyNN/8X0xTYndQTt0Sg GwSd35bjZbvJtua/TWI6uDjyEHBH24Omhihl6klaxrCuQxGlIn85l917SFlY83Q3m8YT Q77ATEWufuGdCNkyaXYG+UKpvCoQ11HndiXh7P6A3QkDwVPpbKyJbWHeQ9wRf648XhQ/ ziOG1JWuhGAwS/AzQLgOeglI1htrSdouRdD06D3nMhFTzxMnCrhHmfZ0U7LjxWwDbsB/ +6ztRf7yrEjM2+9SQf4CZKoSYZrRo12jk432d1uzPRatyIP/o3LUPFkNkpFKwYPEAJxx UJjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697829362; x=1698434162; h=to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZVy3x+Yx0c/AClGDDaFX3+f93DT1qFSojepfkUE0VqU=; b=YotfJuyDcvcEQ+l2y8DgPIJCox7mD4QBgjnqUHsjc+hNSYXCSXQt4hDQ8kQz3ZKgTt eMWJpnRcLrYBSm3xuxjOrdNU2C/e4feWuVztQ73VNVh5FUa4XOq2YRBYfDR4Ay4SCWXl 1E2sOgg6kq0YqP7lpONEJMdOFGH1z/hv8uKsyjFj3qzOJd67Lp4gQHS+U++hFuur+aIU DVIXcNgByn+nGvzmaEAjlb5wv7Bj/kom/MjJDo1PQ1yhjGpAtrf6YhiWv2jgGLBM6C81 zjQo1xx7bI1R3PvyDZtzGheW3CbSngWSXf+cZ4HXrwpRpJeTfRWED5o3+uCjcm2R+efF Z1ug== X-Gm-Message-State: AOJu0YwCuM/GpM9z2Ss/MngEJHdb8UvFcYVAreee56NaR0CaAyW04otA K8/5DzBWU6eY7XNS3THfIGZIoBR43p4dzEiC1dQ/Tg== X-Google-Smtp-Source: AGHT+IGh4YmLhS2EsbStXx3sB67NNpj4HpnssougaGDWNbnVcR+RqVG5FVQva0YxhPk6ojDRjqYbmg== X-Received: by 2002:a05:6602:2dc5:b0:786:cc36:360c with SMTP id l5-20020a0566022dc500b00786cc36360cmr3615324iow.8.1697829361929; Fri, 20 Oct 2023 12:16:01 -0700 (PDT) Received: from localhost.localdomain (97-122-77-73.hlrn.qwest.net. [97.122.77.73]) by smtp.gmail.com with ESMTPSA id q15-20020a0566380ecf00b00430bb70004dsm701765jas.103.2023.10.20.12.16.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 12:16:01 -0700 (PDT) From: Tom Tromey Date: Fri, 20 Oct 2023 13:15:56 -0600 Subject: [PATCH 5/5] Fix fixed-point "return" on ARM MIME-Version: 1.0 Message-Id: <20231020-arm-params-v1-5-19d4c89c11b6@adacore.com> References: <20231020-arm-params-v1-0-19d4c89c11b6@adacore.com> In-Reply-To: <20231020-arm-params-v1-0-19d4c89c11b6@adacore.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.3 X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org On a big-endian ARM machine, the "return" command resulted in the wrong value being returned when the function had a fixed-point return type. This patch fixes the problem by unpacking and repacking the fixed-point type appropriately. --- gdb/arm-tdep.c | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c index 62412d92f85..a9c43b27265 100644 --- a/gdb/arm-tdep.c +++ b/gdb/arm-tdep.c @@ -9170,16 +9170,28 @@ arm_store_return_value (struct type *type, struct regcache *regs, || type->code () == TYPE_CODE_BOOL || type->code () == TYPE_CODE_PTR || TYPE_IS_REFERENCE (type) - || type->code () == TYPE_CODE_ENUM) + || type->code () == TYPE_CODE_ENUM + || is_fixed_point_type (type)) { if (type->length () <= 4) { /* Values of one word or less are zero/sign-extended and returned in r0. */ bfd_byte tmpbuf[ARM_INT_REGISTER_SIZE]; - LONGEST val = unpack_long (type, valbuf); - store_signed_integer (tmpbuf, ARM_INT_REGISTER_SIZE, byte_order, val); + if (is_fixed_point_type (type)) + { + gdb_mpz unscaled; + unscaled.read (gdb::make_array_view (valbuf, type->length ()), + byte_order, type->is_unsigned ()); + unscaled.write (gdb::make_array_view (tmpbuf, sizeof (tmpbuf)), + byte_order, type->is_unsigned ()); + } + else + { + LONGEST val = unpack_long (type, valbuf); + store_signed_integer (tmpbuf, ARM_INT_REGISTER_SIZE, byte_order, val); + } regs->cooked_write (ARM_A1_REGNUM, tmpbuf); } else