From patchwork Fri Oct 20 19:15:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 78284 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 13BA6387103E for ; Fri, 20 Oct 2023 19:16:20 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-io1-xd2c.google.com (mail-io1-xd2c.google.com [IPv6:2607:f8b0:4864:20::d2c]) by sourceware.org (Postfix) with ESMTPS id 3035838582A3 for ; Fri, 20 Oct 2023 19:16:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3035838582A3 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3035838582A3 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d2c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697829362; cv=none; b=VcRCT199dWiNKvMED2BNzMqRQpdsn/og6Z2V9yDEfklENdPmfqRVmRCIFduADQs9FpkxHhXse4jghaAQzWlAIqWI2NDhYOoHR59qWyeGy/iFxyoDdzigULitwlm5sl8TuDvwzzEwOTTSkdt9dU3k8DZ6SInAQCHKNe+dFr6X62A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697829362; c=relaxed/simple; bh=CBjjn/CRwuTUlnWGUbusOzATsGI6Lwd9q7/fRx4KVRY=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=AD1IUJ40DMEw2BNXQnX+mVOX0ZwOKuXuSUZmahFlIJ2pkGlE8GDVFMwoqAWfV5mpwoxSt2eumUrfKC61388om10BS03+pxhv+2QjRFw3ZWHvmPIGf5eSfrTxKiunzI6KLCBFFFo8q5bGOsolWc6fQeZ94r295RGaf/0UDsKHvGI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd2c.google.com with SMTP id ca18e2360f4ac-7a66a7fc2d4so42755039f.0 for ; Fri, 20 Oct 2023 12:16:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1697829360; x=1698434160; darn=sourceware.org; h=to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=SHYP4gHBmXnTpYc3bMI7qzPcd8sBeTuFZparPOWEPRs=; b=aGpxiLkoqDRjvaGafLSG5FAFsPAtGmp98fibXzWNDcDiB6BZLfOeqFH9kDGiSXLg/g oAWFy4GiMTaZZ7lPschqKqwTFhLcjgD1ZnrH1MvLC6HdMz079G15OYxOQmRNH9RX41ce +8Vt7aW5+04pkx/t0uHVttNsgLaEDIZVNC18byPnd3fchGvlrAqtZ2hs02BIyRU+vMh7 31ePQ2tVQ1N9baCv8HhtKN9+7OjIP1AdJKZTUKN/UxkwuSl/5fSxEmA4dbwk/fNAFZsE 18LDhQrtAzguDl3zMcwomzO79jFv4or4PNS7y+DmXd+LVPUflGLm1HofibWdYuoBkGmv Z2NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697829360; x=1698434160; h=to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SHYP4gHBmXnTpYc3bMI7qzPcd8sBeTuFZparPOWEPRs=; b=klgaSYVvV4wfz5xhRhFB1IZUoEmhmi48uo2mzXtjKyz4luPVGCAO3gTvmljnuw8unC kJIYkzAZz9OddYLpuYx9vb4bq3iPE4hDSz9HEZusR5NtzlEa+htYSToC2EImkiNGb8qV w3hnxjto5I8URVMAUOOkdIHW2GFM3jM9qLhnOxVqUlbR2xDxqaP5R4zmnoA7O7SQiSFu SA758+DM6ZK558SEG0dXipxmzhZpsI2L6bLMjBJlyVDXTHKfJ7evVhuNepEvxWWumC1z 90GGJ1gGaRFl2YHDz6kG/elIPJOJZ2HqXM8vnIEtmnjEIi7iLQYLx4i7+6ncgJ5h3CJR wEIw== X-Gm-Message-State: AOJu0YweJPWYdZP07xQVzMXryENDP3PADMDozfLlWJaOUf6hfq1NcS97 v9+nEdu4NDfJqxqwsThEvU9VvkkEBEJvrlQswO42lg== X-Google-Smtp-Source: AGHT+IEv2sh/1zs2zo+1lvgaQaNZ7RAAzr9tL1m84P/susFFv9eFtRg7Rp4tm0/vFMMIn+P5xnh/hw== X-Received: by 2002:a05:6602:15c2:b0:791:1e87:b47e with SMTP id f2-20020a05660215c200b007911e87b47emr3654850iow.15.1697829360084; Fri, 20 Oct 2023 12:16:00 -0700 (PDT) Received: from localhost.localdomain (97-122-77-73.hlrn.qwest.net. [97.122.77.73]) by smtp.gmail.com with ESMTPSA id q15-20020a0566380ecf00b00430bb70004dsm701765jas.103.2023.10.20.12.15.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 12:15:59 -0700 (PDT) From: Tom Tromey Date: Fri, 20 Oct 2023 13:15:53 -0600 Subject: [PATCH 2/5] Fix "finish" with range types on ARM MIME-Version: 1.0 Message-Id: <20231020-arm-params-v1-2-19d4c89c11b6@adacore.com> References: <20231020-arm-params-v1-0-19d4c89c11b6@adacore.com> In-Reply-To: <20231020-arm-params-v1-0-19d4c89c11b6@adacore.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.3 X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org On ARM (I tested big-endian but it may not matter), "finish" can sometimes print the wrong result when the return type is a range type. Range types should really be treated as their underlying type (normally integer, but sometimes fixed-point). This patch implements this. --- gdb/arm-tdep.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c index 97d7c5140d2..ab0df0f16a8 100644 --- a/gdb/arm-tdep.c +++ b/gdb/arm-tdep.c @@ -8915,6 +8915,9 @@ arm_extract_return_value (struct type *type, struct regcache *regs, enum bfd_endian byte_order = gdbarch_byte_order (gdbarch); arm_gdbarch_tdep *tdep = gdbarch_tdep (gdbarch); + while (type->code () == TYPE_CODE_RANGE) + type = check_typedef (type->target_type ()); + if (TYPE_CODE_FLT == type->code ()) { switch (tdep->fp_model)