From patchwork Fri Jul 28 12:33:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 73325 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 526293856089 for ; Fri, 28 Jul 2023 12:34:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 526293856089 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1690547648; bh=OZa5RP96j2jLqyw1LidXKgygeRHX03LGR6DSGKxW1SI=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=flna9Q+3zwxwKLksaDB22lFyql4i3oESnLDsaFlhT9H6Mal/FUxTSif95VVxY9x52 lh2jM/psMcLGkM9TT6fjHIYZLhVO1g5NmJx+DnwfqMI0L1zA0Jcpqr0eIelPSKtK/b qwbfCmAPhPphaHlU5cHGZK76ku2lPSuwaoWuFj84= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) by sourceware.org (Postfix) with ESMTPS id 4502A3858D20 for ; Fri, 28 Jul 2023 12:33:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4502A3858D20 Received: by mail-io1-xd35.google.com with SMTP id ca18e2360f4ac-7836272f36eso83804139f.1 for ; Fri, 28 Jul 2023 05:33:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690547620; x=1691152420; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OZa5RP96j2jLqyw1LidXKgygeRHX03LGR6DSGKxW1SI=; b=BdIy0yrjpxt3n6VsqrkPUGHATa4gve710r7OX/kMAsrLzaaBtNfWonfQqoViXTACxA JCMlmlgkO7m3/mzQNDQFPooG+arBBLHEvSto6YJT/rJgDCFcSsNvAWgQaU8RMP9QaACD bBt3SDwc/2+a6Z/zfRx42Pdfhg2/sCkBtyogsvFlnm8k67jVrYwwsO+QtPUGlq2urI/i MaH4Ww3AHuCn9V1izvxrc4JUeVD5kGTqSd4O1flxx+/+PPETKoEZucPOnLbHQcJQzmLq PNeWMpUPTM8es7xeZSiZLFJ+fxK8vslPJhdL85mYLEzTEdVYQ3dR6f7Cc0wNT9yi4bSK m+1A== X-Gm-Message-State: ABy/qLayDdjhELTbrec370UD5bk3pYMOreaqZYG0hy6omSUpLQclhZ0O hA4PVi66NCijUZYnQtnSSHOfLo5gqnD64MdCRwNVdw== X-Google-Smtp-Source: APBJJlEXUN4dthHTPRQKFdxMaDodQxnOqCcGBgZqtwr8QV3js5CqAxWiuzDyb/aSLn+bhO+sELFNZA== X-Received: by 2002:a6b:db05:0:b0:787:8cf:fd8e with SMTP id t5-20020a6bdb05000000b0078708cffd8emr2904046ioc.11.1690547620385; Fri, 28 Jul 2023 05:33:40 -0700 (PDT) Received: from localhost.localdomain (75-166-135-140.hlrn.qwest.net. [75.166.135.140]) by smtp.gmail.com with ESMTPSA id ee5-20020a056638292500b0042b279bb086sm1076392jab.66.2023.07.28.05.33.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jul 2023 05:33:40 -0700 (PDT) To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Set PYTHONMALLOC in the test suite Date: Fri, 28 Jul 2023 06:33:32 -0600 Message-Id: <20230728123332.2521239-1-tromey@adacore.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tom Tromey via Gdb-patches From: Tom Tromey Reply-To: Tom Tromey Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Setting PYTHONMALLOC helped me locate an earlier bug. It seems to me that there aren't big downsides to always setting this during testing, and it might help find other bugs in the future. --- gdb/testsuite/lib/gdb.exp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 66c04a2efe2..12a9c59dece 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -6437,6 +6437,10 @@ proc default_gdb_init { test_file_name } { # tests. setenv TERM "dumb" + # This setting helps detect bugs in the Python code and doesn't + # seem to have a significant downside for the tests. + setenv PYTHONMALLOC malloc_debug + # If DEBUGINFOD_URLS is set, gdb will try to download sources and # debug info for f.i. system libraries. Prevent this. if { [is_remote host] } {