diff mbox series

[v1,gdb/dap] Add thread exited event

Message ID 20230605125907.76835-1-simon.farre.cx@gmail.com
State New
Headers
Series [v1,gdb/dap] Add thread exited event |

Commit Message

Simon Farre June 5, 2023, 12:59 p.m. UTC 
  Reports a thread exit according to the DAP spec:
https://microsoft.github.io/debug-adapter-protocol/specification#Events_Thread

This patch requires the ThreadExitedEvent to be checked in,
in order to work. That patch is found here https://sourceware.org/pipermail/gdb-patches/2023-June/200071.html
---
 gdb/python/lib/gdb/dap/events.py | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

Comments

Tom Tromey June 5, 2023, 1:48 p.m. UTC | #1 
>>>>> "Simon" == Simon Farre via Gdb-patches <gdb-patches@sourceware.org> writes:

Simon> Reports a thread exit according to the DAP spec:
Simon> https://microsoft.github.io/debug-adapter-protocol/specification#Events_Thread

We discussed on irc but FTR this commit message should have a trailer
like:

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30474

(and then close the bug & mark it target-milestone:14.1 when the patch
lands)

Simon> +@in_gdb_thread
Simon> +def _new_thread(event):
Simon> +    thread_event(event, "started")
Simon> +
Simon> +@in_gdb_thread
Simon> +def _thread_exited(event):
Simon> +    thread_event(event, "exited")
 
Not sure but you probably need to run 'black' on the file.

The patch looks good to me, once the prerequisite lands.  It would be
nice to have a test case, though I see I neglected to write one for the
thread-creation event.

Tom
diff mbox series

Patch

diff --git a/gdb/python/lib/gdb/dap/events.py b/gdb/python/lib/gdb/dap/events.py
index d9ae603dfa4..1618f9cd6ac 100644
--- a/gdb/python/lib/gdb/dap/events.py
+++ b/gdb/python/lib/gdb/dap/events.py
@@ -66,17 +66,23 @@  def _bp_deleted(event):
         },
     )
 
-
 @in_gdb_thread
-def _new_thread(event):
+def thread_event(event, reason):
     send_event(
         "thread",
         {
-            "reason": "started",
+            "reason": reason,
             "threadId": event.inferior_thread.global_num,
         },
     )
 
+@in_gdb_thread
+def _new_thread(event):
+    thread_event(event, "started")
+
+@in_gdb_thread
+def _thread_exited(event):
+    thread_event(event, "exited")
 
 _suppress_cont = False
 
@@ -160,4 +166,5 @@  gdb.events.breakpoint_created.connect(_bp_created)
 gdb.events.breakpoint_modified.connect(_bp_modified)
 gdb.events.breakpoint_deleted.connect(_bp_deleted)
 gdb.events.new_thread.connect(_new_thread)
+gdb.events.thread_exited.connect(_thread_exited)
 gdb.events.cont.connect(_cont)