diff mbox series

[AArch64] Fix architecture debug version constant thinkos

Message ID 20230602054328.24695-1-luis.machado@arm.com
State New
Headers
Series [AArch64] Fix architecture debug version constant thinkos |

Commit Message

Luis Machado June 2, 2023, 5:43 a.m. UTC 
  Caught this during emulator testing.

Fix the constants. They should be 0xa and 0xb as opposed to 0x10 and
0x11.  There was a thinko while defining them.

Obvious enough.

Tested on aarch64-linux Ubuntu 20.04/22.04.
---
 gdb/nat/aarch64-hw-point.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Andrew Burgess June 7, 2023, 8:46 a.m. UTC | #1 
Luis Machado via Gdb-patches <gdb-patches@sourceware.org> writes:

> Caught this during emulator testing.
>
> Fix the constants. They should be 0xa and 0xb as opposed to 0x10 and
> 0x11.  There was a thinko while defining them.
>
> Obvious enough.

I agree.

Approved-By: Andrew Burgess <aburgess@redhat.com>

Thanks,
Andrew


>
> Tested on aarch64-linux Ubuntu 20.04/22.04.
> ---
>  gdb/nat/aarch64-hw-point.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/nat/aarch64-hw-point.h b/gdb/nat/aarch64-hw-point.h
> index c19681422da..2ff9ccb5c1c 100644
> --- a/gdb/nat/aarch64-hw-point.h
> +++ b/gdb/nat/aarch64-hw-point.h
> @@ -58,9 +58,9 @@
>  #define AARCH64_DEBUG_ARCH_V8_1 0x7
>  #define AARCH64_DEBUG_ARCH_V8_2 0x8
>  #define AARCH64_DEBUG_ARCH_V8_4 0x9
> -#define AARCH64_DEBUG_ARCH_V8_8 0x10
> +#define AARCH64_DEBUG_ARCH_V8_8 0xa
>  /* Armv8.9 debug architecture.  */
> -#define AARCH64_DEBUG_ARCH_V8_9 0x11
> +#define AARCH64_DEBUG_ARCH_V8_9 0xb
>  
>  /* ptrace expects control registers to be formatted as follows:
>  
> -- 
> 2.25.1
Luis Machado June 7, 2023, 8:48 a.m. UTC | #2 
On 6/7/23 09:46, Andrew Burgess wrote:
> Luis Machado via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
>> Caught this during emulator testing.
>>
>> Fix the constants. They should be 0xa and 0xb as opposed to 0x10 and
>> 0x11.  There was a thinko while defining them.
>>
>> Obvious enough.
> 
> I agree.
> 
> Approved-By: Andrew Burgess <aburgess@redhat.com>
> 
> Thanks,
> Andrew
> 
> 

Thanks. I should've said I pushed this right after posting. Sorry about that.

>>
>> Tested on aarch64-linux Ubuntu 20.04/22.04.
>> ---
>>   gdb/nat/aarch64-hw-point.h | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/gdb/nat/aarch64-hw-point.h b/gdb/nat/aarch64-hw-point.h
>> index c19681422da..2ff9ccb5c1c 100644
>> --- a/gdb/nat/aarch64-hw-point.h
>> +++ b/gdb/nat/aarch64-hw-point.h
>> @@ -58,9 +58,9 @@
>>   #define AARCH64_DEBUG_ARCH_V8_1 0x7
>>   #define AARCH64_DEBUG_ARCH_V8_2 0x8
>>   #define AARCH64_DEBUG_ARCH_V8_4 0x9
>> -#define AARCH64_DEBUG_ARCH_V8_8 0x10
>> +#define AARCH64_DEBUG_ARCH_V8_8 0xa
>>   /* Armv8.9 debug architecture.  */
>> -#define AARCH64_DEBUG_ARCH_V8_9 0x11
>> +#define AARCH64_DEBUG_ARCH_V8_9 0xb
>>   
>>   /* ptrace expects control registers to be formatted as follows:
>>   
>> -- 
>> 2.25.1
>
diff mbox series

Patch

diff --git a/gdb/nat/aarch64-hw-point.h b/gdb/nat/aarch64-hw-point.h
index c19681422da..2ff9ccb5c1c 100644
--- a/gdb/nat/aarch64-hw-point.h
+++ b/gdb/nat/aarch64-hw-point.h
@@ -58,9 +58,9 @@ 
 #define AARCH64_DEBUG_ARCH_V8_1 0x7
 #define AARCH64_DEBUG_ARCH_V8_2 0x8
 #define AARCH64_DEBUG_ARCH_V8_4 0x9
-#define AARCH64_DEBUG_ARCH_V8_8 0x10
+#define AARCH64_DEBUG_ARCH_V8_8 0xa
 /* Armv8.9 debug architecture.  */
-#define AARCH64_DEBUG_ARCH_V8_9 0x11
+#define AARCH64_DEBUG_ARCH_V8_9 0xb
 
 /* ptrace expects control registers to be formatted as follows: