From patchwork Wed Apr 19 19:30:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sandra Loosemore X-Patchwork-Id: 68042 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 42C92385B51E for ; Wed, 19 Apr 2023 19:31:38 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 1B5FE3857716 for ; Wed, 19 Apr 2023 19:31:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1B5FE3857716 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.99,210,1677571200"; d="scan'208";a="3288416" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa2.mentor.iphmx.com with ESMTP; 19 Apr 2023 11:31:13 -0800 IronPort-SDR: cmNC+Rvaf7Yq0q03h764ZZLSfSFekKOGv4qLe/XZoxXJAZZZoPpqJy+i5AFQ3zOYxI5oM0eRDa ZaUr3xdAEhsll26ipepOyTSnllTF9UCD4N+zJqwK5wC29tyEa6iDu87K0DsdzmW5ZNGgkr8uhZ SFdlUT6Zm0GgtyBjNj5fZdEZp2E+yd5PAYPShj4yryZ1qly9IN4duRIgElGqZ2cZwLP83HLelb Oj/lkqpBMJtcjNKv0wF9nxhxhqDBtf6wtw3Mc+O1VnABLhSmuJMG4EV8pKwYDQBMpRFPkjfw1u o7Y= From: Sandra Loosemore To: Subject: [PATCH 4/5] gdb/testsuite: Disable some tests that are broken on remote Windows host Date: Wed, 19 Apr 2023 13:30:45 -0600 Message-ID: <20230419193046.548783-5-sandra@codesourcery.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230419193046.548783-1-sandra@codesourcery.com> References: <20230419193046.548783-1-sandra@codesourcery.com> MIME-Version: 1.0 X-ClientProxiedBy: svr-orw-mbx-14.mgc.mentorg.com (147.34.90.214) To svr-orw-mbx-13.mgc.mentorg.com (147.34.90.213) X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_SHORT, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" These testcases assume host==build or that the remote host has a Posix shell to run commands in. Don't try to run them if that's not the case. --- gdb/testsuite/gdb.base/bad-file.exp | 6 ++++++ gdb/testsuite/gdb.base/early-init-file.exp | 6 ++++++ gdb/testsuite/gdb.base/empty-host-env-vars.exp | 6 ++++++ 3 files changed, 18 insertions(+) diff --git a/gdb/testsuite/gdb.base/bad-file.exp b/gdb/testsuite/gdb.base/bad-file.exp index 5d8dfee8fea..98101d9e15a 100644 --- a/gdb/testsuite/gdb.base/bad-file.exp +++ b/gdb/testsuite/gdb.base/bad-file.exp @@ -20,6 +20,12 @@ # print different text then the plan is to update the expected text # instead of making this test linux-only or some such. +# The pathnames and shell commands in this test don't work on Windows host. +if { [is_remote host] && [ishost *-*-mingw*] } { + untested "does not work on remote Windows host" + return 0 +} + # There is no such file, but we still use the normal mechanism to pick # its name and path. standard_testfile diff --git a/gdb/testsuite/gdb.base/early-init-file.exp b/gdb/testsuite/gdb.base/early-init-file.exp index fcd1ff041a1..0bb2c456a3e 100644 --- a/gdb/testsuite/gdb.base/early-init-file.exp +++ b/gdb/testsuite/gdb.base/early-init-file.exp @@ -15,6 +15,12 @@ # Test GDB's early init file mechanism. +# Test assumes host == build. +if {[is_remote host]} { + untested "does not work on remote host" + return 0 +} + standard_testfile # Compile the test executable. diff --git a/gdb/testsuite/gdb.base/empty-host-env-vars.exp b/gdb/testsuite/gdb.base/empty-host-env-vars.exp index 96240311c24..a28798ff69a 100644 --- a/gdb/testsuite/gdb.base/empty-host-env-vars.exp +++ b/gdb/testsuite/gdb.base/empty-host-env-vars.exp @@ -13,6 +13,12 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see . +# This test assumes host == build. +if {[is_remote host]} { + untested "does not work on remote host" + return 0 +} + # GDB reads some environment variables on startup, make sure it behaves # correctly if these variables are defined but empty.