From patchwork Wed Apr 19 18:16:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: orbea X-Patchwork-Id: 68038 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7A1FF385771D for ; Wed, 19 Apr 2023 18:17:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7A1FF385771D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1681928233; bh=NjZWy8xjqgfRlGC7kqU9XE8dblRjBBgohTAqjL3o45k=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=Y2zHCq+3FiNJ7urcWaxvQlwDkFr/EqC4lhvW0D6R8BjEgpi7aOcHBn59l3rNzrwdh yo5iaDP4hGYiOZC3rCdi+MnxgIg30+QvvTIHdb3V0Rxz31S1spqyo+niFme2jnQHzp uX6C8yuJRxnxs92NerzP227WczOr+0FF/sQG+uUU= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mx0.riseup.net (mx0.riseup.net [198.252.153.6]) by sourceware.org (Postfix) with ESMTPS id 1A8703858CDA for ; Wed, 19 Apr 2023 18:16:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1A8703858CDA Received: from fews02-sea.riseup.net (unknown [10.0.1.112]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.riseup.net", Issuer "R3" (not verified)) by mx0.riseup.net (Postfix) with ESMTPS id 4Q1psF2JCzz9sSR for ; Wed, 19 Apr 2023 18:16:49 +0000 (UTC) X-Riseup-User-ID: 3E934C228139FB6237B46822F019EEAB0E26A1F9C1E80D55AB104AB4CBD85205 Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews02-sea.riseup.net (Postfix) with ESMTPSA id 4Q1psF0XHdzFsKG for ; Wed, 19 Apr 2023 18:16:49 +0000 (UTC) Date: Wed, 19 Apr 2023 11:16:28 -0700 To: gdb-patches@sourceware.org Subject: [PATCH] gdb: Don't overwrite CC when checking for BFD support Message-ID: <20230419111628.0e1f33f0@Akita> MIME-Version: 1.0 X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: orbea via Gdb-patches From: orbea Reply-To: orbea Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" In gdb/acinclude.m4 'libtool' is hard coded within the provided custom CC variable which results in a failure when using slibtool instead of GNU libtool where the two different libtool implementations are incompatible when both are used during the same build process at once. This can be solved by using the default value for CC instead where autotools is capable of providing an adequate value by default. I attached a patch doing this. A bug report was issued here: https://sourceware.org/bugzilla/show_bug.cgi?id=30295 Please see comment 3 with the explanation where before I was missing the real issue. commit 31245fcf4fc31e732f05205f739317e9c8922da3 Author: orbea Date: Fri Mar 31 09:46:51 2023 -0700 gdb: Don't overwrite CC when checking for BFD support When building with an alternative libtool implementation such as slibtool the configure check for BFD features will fail in gdb/configure.ac because './libtool' was hardcoded. Simply removing the line allows the configure check to work correctly. diff --git a/gdb/acinclude.m4 b/gdb/acinclude.m4 index 173e40b440..5f7589f9f6 100644 --- a/gdb/acinclude.m4 +++ b/gdb/acinclude.m4 @@ -237,7 +237,6 @@ AC_DEFUN([GDB_AC_CHECK_BFD], [ LDFLAGS="-L../bfd -L../libiberty $LDFLAGS" intl=`echo $LIBINTL | sed 's,${top_builddir}/,,g'` LIBS="-lbfd -liberty $intl $LIBS" - CC="./libtool --quiet --mode=link $CC" AC_CACHE_CHECK( [$1], [$2],