diff mbox series

gdb: boolify 'should_print_thread'

Message ID 20230404191222.3408219-1-tankut.baris.aktemur@intel.com
State New
Headers
Series gdb: boolify 'should_print_thread' |

Commit Message

Aktemur, Tankut Baris April 4, 2023, 7:12 p.m. UTC 
  Convert the return type of 'should_print_thread' from int to bool.
---
 gdb/thread.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Tom Tromey April 4, 2023, 7:28 p.m. UTC | #1 
>>>>> Tankut Baris Aktemur via Gdb-patches <gdb-patches@sourceware.org> writes:

> Convert the return type of 'should_print_thread' from int to bool.

Thank you, this is ok.
Reviewed-By: Tom Tromey <tom@tromey.com>

Tom
diff mbox series

Patch

diff --git a/gdb/thread.c b/gdb/thread.c
index 25d97cd6072..5d5298331bf 100644
--- a/gdb/thread.c
+++ b/gdb/thread.c
@@ -986,7 +986,7 @@  pc_in_thread_step_range (CORE_ADDR pc, struct thread_info *thread)
    and PID is not -1, then the thread is printed if it belongs to the
    specified process.  Otherwise, an error is raised.  */
 
-static int
+static bool
 should_print_thread (const char *requested_threads, int default_inf_num,
 		     int global_ids, int pid, struct thread_info *thr)
 {
@@ -1000,20 +1000,20 @@  should_print_thread (const char *requested_threads, int default_inf_num,
 	in_list = tid_is_in_list (requested_threads, default_inf_num,
 				  thr->inf->num, thr->per_inf_num);
       if (!in_list)
-	return 0;
+	return false;
     }
 
   if (pid != -1 && thr->ptid.pid () != pid)
     {
       if (requested_threads != NULL && *requested_threads != '\0')
 	error (_("Requested thread not found in requested process"));
-      return 0;
+      return false;
     }
 
   if (thr->state == THREAD_EXITED)
-    return 0;
+    return false;
 
-  return 1;
+  return true;
 }
 
 /* Return the string to display in "info threads"'s "Target Id"