From patchwork Wed Mar 22 19:23:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 66770 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 66A8A385B50D for ; Wed, 22 Mar 2023 19:23:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 66A8A385B50D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1679513020; bh=eU7dj6qDSts37iiKxQy0+zx5nRsLQXoJ3d4TpQ817jo=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=Z4byCQqyoKRYlcL0cVoXGZD45Qp3rjNwC5XwYV2hdJzgpaONTBldVFKuc3VsA3KGk XTgIymRRU3x8Rf3J8y4Tmdg/RX1kgRjyK68S0ZEvSp1lgfr7GBdtRctb7rli4ZLCRi QoEwRwyNZLtkSbIu315J3R41G2nbdUGEEkesmkAA= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [IPv6:2607:f8b0:4864:20::d2e]) by sourceware.org (Postfix) with ESMTPS id BF8903858433 for ; Wed, 22 Mar 2023 19:23:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BF8903858433 Received: by mail-io1-xd2e.google.com with SMTP id o14so8978475ioa.3 for ; Wed, 22 Mar 2023 12:23:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679512996; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eU7dj6qDSts37iiKxQy0+zx5nRsLQXoJ3d4TpQ817jo=; b=mMdA15Ukx7LrvZE89VySByU1cQYc0RMwDDwO4tiFImafsWpd+C5g6aRF8RjktpAkac lsxGEiVmCKHN5KCK1wOYrcbhbE0qLpdRHsyxZ25YS3vrtVMAczYBUAq8oHVVKlA5ares CIMP214hoYbNqgadPDS4jS/ca/UJH6NQHb1reCYZBuJ6qDkNqE0XbH3JdWxA8F3gME9X ocCrCim2b0l/Sgdh2KdlGibUA32iDfpHr3Z9SlT+ZIQJrKZz3w51gJ1BOQWMMT14GQIR Nd4EWA7qiHnOj8vD4l2jGtW4p/doiHNN1ghLp6xfG/H3nbsfBkanMEsVnOcD7vx/2138 KXPQ== X-Gm-Message-State: AO0yUKVuRFCCgAPb3zsGpUtaezh1t5FBv+n5h9Ud5S7uO65SUYOKXCeC 23PZoju5zauoWBsGrQkOzamdd84HpFshca2Wtz0ZHQ== X-Google-Smtp-Source: AK7set/T96YT0k2o5ldFWzFOe7Uls1NZZvLhQ6l6dWKdlSlOWzn59YzmyWH/+oiZPUWmgU5KMdp4Cw== X-Received: by 2002:a05:6602:218c:b0:753:786a:c003 with SMTP id b12-20020a056602218c00b00753786ac003mr5238085iob.3.1679512996029; Wed, 22 Mar 2023 12:23:16 -0700 (PDT) Received: from localhost.localdomain (71-211-185-113.hlrn.qwest.net. [71.211.185.113]) by smtp.gmail.com with ESMTPSA id g8-20020a6b7608000000b0074c7db1470dsm4512992iom.20.2023.03.22.12.23.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Mar 2023 12:23:15 -0700 (PDT) To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [pushed] Remove unnecessary cast Date: Wed, 22 Mar 2023 13:23:04 -0600 Message-Id: <20230322192304.2053047-1-tromey@adacore.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tom Tromey via Gdb-patches From: Tom Tromey Reply-To: Tom Tromey Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" I found an upcast from template_symbol to symbol. This was necessary long ago, but since symbols use inheritance now, it is not. This patch removes it. Tested by rebuilding. --- gdb/dwarf2/read.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index 3fc23e2d43f..c9208a097bf 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -10083,8 +10083,7 @@ read_func_scope (struct die_info *die, struct dwarf2_cu *cu) gdb_assert (cu->get_builder () != nullptr); newobj = cu->get_builder ()->push_context (0, lowpc); - newobj->name = new_symbol (die, read_type_die (die, cu), cu, - (struct symbol *) templ_func); + newobj->name = new_symbol (die, read_type_die (die, cu), cu, templ_func); if (dwarf2_flag_true_p (die, DW_AT_main_subprogram, cu)) set_objfile_main_name (objfile, newobj->name->linkage_name (),