From patchwork Wed Mar 22 16:35:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lancelot SIX X-Patchwork-Id: 66752 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DAF2D3854836 for ; Wed, 22 Mar 2023 16:35:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DAF2D3854836 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1679502954; bh=YNp4RA7qWkn4/Avw7HRYE2cKxeDehx/RZE8NQoLt9Fo=; h=To:CC:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=TWPXlBTHh+n1aE3/X38MlLbAz6YBXDlSLaAOa+X93dRrsAd50iHqoS4weGQGMnc2u kA9wvMa3oObieUlMWYmQjnklWyHqAcKN05s/IjZndkHCYDkNbJoRueerfiaIVQVgoP OQaATkNznNR59EKS+uilSuOgHkgwzPQ9TZX0D6NE= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20608.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe5b::608]) by sourceware.org (Postfix) with ESMTPS id 8D3C53858D3C for ; Wed, 22 Mar 2023 16:35:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8D3C53858D3C ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bGkWebNamheFKLcGQI5CENXA9PsxIS+7ZPDtLtnpki/rOrPdCcq70BWpYkU03i05JluPXMd7fd7OKHWH8wYOUpn1bDM/wtVZAc4i11uL1O2RL8jCx3kCeGcpZRkN88fu6jU6kfyvf6Gr2Rj7sgtThAitk55oo5Hmq+vMpcZ2LMAyPmDJ3Kopf4rKI64dt4dodHCzA1KXvLYUTry0Ft7B3biVB4x+YfVw0c9Ispx4bzN+2GYipYzXxhD74dBeSiVu43/oaZXTybttxmd1+gOpB2y/nd8qLiqmx+5LQSMi6feecPEb2y40yhH1vdQBTOOIiDjc2QN+qh4+jBr32qygpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YNp4RA7qWkn4/Avw7HRYE2cKxeDehx/RZE8NQoLt9Fo=; b=ZXsG1VGpAkIzF8ZbJng/4ka3EF6iLTPiQb/qI99f/qtooA/75tqPAOpmXZtVpD4TdPJEWRud5cdLAolo3i6G8npJ7vIxO3mpc5Y6sGjQ/C0vaW4Bxy8civhpcqNVz9yLvTJ9DXisnf/c08KiMnIUfrZ1pJ0HPdofOcFYdSZej+1etgpVHmv3WeK2GHiolK012aJPmmXlRZyqpv+2No5kNfMRqAROHSh1EgVmBWaDMX5MjUM5RInmbjQI+IQYJQhRVLHRcMi0KjNb9jfvOfsdoRQXc88kKTbpXgObTDwon2HKXH5FqVMTww7wHAb2gFbaUvsD0amHMxdlSNHDusZL2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=sourceware.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none Received: from BN9PR03CA0970.namprd03.prod.outlook.com (2603:10b6:408:109::15) by IA1PR12MB7590.namprd12.prod.outlook.com (2603:10b6:208:42a::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Wed, 22 Mar 2023 16:35:26 +0000 Received: from BN8NAM11FT083.eop-nam11.prod.protection.outlook.com (2603:10b6:408:109:cafe::bc) by BN9PR03CA0970.outlook.office365.com (2603:10b6:408:109::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37 via Frontend Transport; Wed, 22 Mar 2023 16:35:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT083.mail.protection.outlook.com (10.13.177.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6222.17 via Frontend Transport; Wed, 22 Mar 2023 16:35:25 +0000 Received: from khazad-dum.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 22 Mar 2023 11:35:24 -0500 To: CC: , Lancelot SIX Subject: [PATCH v6 2/3] gdb/infrun: Improve assertion in stop_all_threads Date: Wed, 22 Mar 2023 16:35:03 +0000 Message-ID: <20230322163504.560986-3-lancelot.six@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230322163504.560986-1-lancelot.six@amd.com> References: <2daa1736-57cb-3c5a-f1cd-48f5aa03d010@simark.ca> <20230322163504.560986-1-lancelot.six@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT083:EE_|IA1PR12MB7590:EE_ X-MS-Office365-Filtering-Correlation-Id: 72ab6b89-2ce3-4c9a-f49f-08db2af370c1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pDVQXsgTKtgDfwqh+7LOp1y5FOl/1aq+NPB6wh17n3/ZUdeBsqSTul72UoL1Z0YX4urnhKQXiFGyQmlZQth3EhJ/bIQT5LywiDzOLEJTwW9PYTqbG1s/EOUclkSsQqfS//GGV890r2k6BGfaHggTIYxLSk0OaWldi6PhxQ1/ZtYyyu92YD0BJnszrtvyPu4YoNcS1I9T5vJl2+jpFYBYCgVU2GcYaWAl7CaQsqAEkKJScB4Pe4Y/e7laJFxnmoe8o6lXUakKCj3oBKBYxfzTbWLBOzdxrHAz6LvfpV4u9b0S37bCHXwOh6VxpFOxPJB3kTXoZUKU6wzzSMJei6McNtiOkmImOculTBXG4ZbOfOAz+YKNkigoXTsRTWz73vVUlxQ1p2TbWYCaVIiSfzCUlph9WoRkdIXAJtpcgXRq20HYlbJAaVY8ApYqUTc+2tWW8R0ging+0oEHzgK8EdZnSEFF3L62aYCRQNCbT9j5RpWF+l2tJFdcM+5ShTp83ELx6AG+n81bsWeF9onALth9BXT/c6fkiSdsqD1vOOH9cSUIs0tlPepHf3H2Z1TRdhJgNwla+M9B2+mBfVOFCX2hc9Qj6DMM7VTzdzj7RZKPd2Och70M+gJVqlSj2K+ThWnxiOTzpfuwPxVxnavVxkOIxzvD4RQEE8HoNQ0t/GKZlVR8a3N9v6n7m5eu0eJKlCQ+rrD0uC88ngoOpCDn9oNFGRvuJ4oZcfsT/ETPnDpBnKc= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230025)(4636009)(376002)(396003)(39860400002)(136003)(346002)(451199018)(40470700004)(46966006)(36840700001)(40460700003)(86362001)(4326008)(356005)(316002)(426003)(6916009)(5660300002)(36756003)(54906003)(478600001)(336012)(70586007)(8676002)(81166007)(41300700001)(70206006)(8936002)(4744005)(2906002)(36860700001)(1076003)(83380400001)(82740400003)(40480700001)(26005)(47076005)(6666004)(186003)(7696005)(16526019)(2616005)(82310400005)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2023 16:35:25.9923 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 72ab6b89-2ce3-4c9a-f49f-08db2af370c1 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT083.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7590 X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FORGED_SPF_HELO, GIT_PATCH_0, SPF_HELO_PASS, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Lancelot SIX via Gdb-patches From: Lancelot SIX Reply-To: Lancelot SIX Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" The stop_all_threads function has an assertion to check that there is a non-stop target. However, when called with a non-NULL INF parameter, we only need INF's target to be non-stop. This patch updates the assertion. If INF is non-NULL, check that INF's target is non-stop, otherwise keep the assertion as before. --- gdb/infrun.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gdb/infrun.c b/gdb/infrun.c index 5c9babb9104..a509e0d5bef 100644 --- a/gdb/infrun.c +++ b/gdb/infrun.c @@ -5189,7 +5189,10 @@ stop_all_threads (const char *reason, inferior *inf) int pass; int iterations = 0; - gdb_assert (exists_non_stop_target ()); + if (inf == nullptr) + gdb_assert (exists_non_stop_target ()); + else + gdb_assert (target_is_non_stop_p (inf)); INFRUN_SCOPED_DEBUG_START_END ("reason=%s, inf=%d", reason, inf != nullptr ? inf->num : -1);