From patchwork Tue Mar 21 11:47:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 66677 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D7A2C3858418 for ; Tue, 21 Mar 2023 11:48:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D7A2C3858418 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1679399286; bh=ALynK/tQaZJ591ghASKxnz3/Nx0Gt8ckIrrLMxX0Hkw=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=S+6lwYSJjm3DCNKDOXuRqAQp3Lx+KrgfaqAiODI1CnvAzORdhEi8o0TODyaJcpszm T6lYEbl7jfIf5Uh9050A/Jn5p9mJ0U73i5GDKrT36Z1JzwcTBxnICTyoX2EltHfX9E mnu7YlaQGXapMfWJEpn5EmOvVlRemyQGUpX3jGfw= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id C1AD03858D38 for ; Tue, 21 Mar 2023 11:47:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C1AD03858D38 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0681E1FF62 for ; Tue, 21 Mar 2023 11:47:44 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E720613451 for ; Tue, 21 Mar 2023 11:47:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 44wwN1+ZGWT3DwAAMHmgww (envelope-from ) for ; Tue, 21 Mar 2023 11:47:43 +0000 To: gdb-patches@sourceware.org Subject: [pushed] [gdb/testsuite] Remove ${board}_file from remote-stdio-gdbserver.exp Date: Tue, 21 Mar 2023 12:47:45 +0100 Message-Id: <20230321114745.31692-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tom de Vries via Gdb-patches From: Tom de Vries Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Looking at the implementation of ${board}_file in remote-stdio-gdbserver.exp, I don't see a relevant difference with the implementation of standard_file in dejagnu. Simplify the board by removing ${board}_file. Tested on x86_64-linux, by running gdb.testsuite/board-sanity.exp. --- gdb/testsuite/boards/remote-stdio-gdbserver.exp | 8 -------- 1 file changed, 8 deletions(-) base-commit: 6ad0261323ae6df46439fc9bec312e21ed80397a diff --git a/gdb/testsuite/boards/remote-stdio-gdbserver.exp b/gdb/testsuite/boards/remote-stdio-gdbserver.exp index c4e29e402fe..1007b199106 100644 --- a/gdb/testsuite/boards/remote-stdio-gdbserver.exp +++ b/gdb/testsuite/boards/remote-stdio-gdbserver.exp @@ -86,14 +86,6 @@ proc get_target_remote_pipe_cmd { } { return "$rsh_cmd $gdbserver --once stdio $target_exec" } -proc ${board}_file { dest op args } { - if { $op == "delete" } { - set res [remote_exec target "rm -f $args"] - return [lindex $res 0] - } - return [eval [list standard_file $dest $op] $args] -} - proc ${board}_spawn { board cmd } { global board_info