diff mbox series

[v2,7/8] Use bool and early loop exit in remove_extra_symbols

Message ID 20230314-submit-pragma-import-export-v2-7-dcff927191fb@adacore.com
State New
Headers
Series Implement Ada Pragma Import and Pragma Export |

Commit Message

Tom Tromey April 7, 2023, 4:40 p.m. UTC 
  This changes remove_extra_symbols to use bool rather than int, and
changes the nested loops to exit early when "remove_p" is set.
---
 gdb/ada-lang.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
diff mbox series

Patch

diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c
index 5d0ba5ac20b..091faba3037 100644
--- a/gdb/ada-lang.c
+++ b/gdb/ada-lang.c
@@ -5040,7 +5040,7 @@  remove_extra_symbols (std::vector<struct block_symbol> &syms)
   i = 0;
   while (i < syms.size ())
     {
-      int remove_p = 0;
+      bool remove_p = false;
 
       /* If two symbols have the same name and one of them is a stub type,
 	 the get rid of the stub.  */
@@ -5048,14 +5048,14 @@  remove_extra_symbols (std::vector<struct block_symbol> &syms)
       if (syms[i].symbol->type ()->is_stub ()
 	  && syms[i].symbol->linkage_name () != NULL)
 	{
-	  for (j = 0; j < syms.size (); j++)
+	  for (j = 0; !remove_p && j < syms.size (); j++)
 	    {
 	      if (j != i
 		  && !syms[j].symbol->type ()->is_stub ()
 		  && syms[j].symbol->linkage_name () != NULL
 		  && strcmp (syms[i].symbol->linkage_name (),
 			     syms[j].symbol->linkage_name ()) == 0)
-		remove_p = 1;
+		remove_p = true;
 	    }
 	}
 
@@ -5066,7 +5066,7 @@  remove_extra_symbols (std::vector<struct block_symbol> &syms)
 	  && syms[i].symbol->aclass () == LOC_STATIC
 	  && is_nondebugging_type (syms[i].symbol->type ()))
 	{
-	  for (j = 0; j < syms.size (); j += 1)
+	  for (j = 0; !remove_p && j < syms.size (); j += 1)
 	    {
 	      if (i != j
 		  && syms[j].symbol->linkage_name () != NULL
@@ -5076,7 +5076,7 @@  remove_extra_symbols (std::vector<struct block_symbol> &syms)
 		      == syms[j].symbol->aclass ())
 		  && syms[i].symbol->value_address ()
 		  == syms[j].symbol->value_address ())
-		remove_p = 1;
+		remove_p = true;
 	    }
 	}