From patchwork Mon Mar 13 22:08:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 66329 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5D44A385B535 for ; Mon, 13 Mar 2023 22:08:25 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id F2EC03858C60 for ; Mon, 13 Mar 2023 22:08:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F2EC03858C60 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id 1CEEF1003BE06 for ; Mon, 13 Mar 2023 22:08:07 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id bqKtpfLGPHIU4bqKtpFyAC; Mon, 13 Mar 2023 22:08:07 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=NfUja0P4 c=1 sm=1 tr=0 ts=640f9ec7 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10:nop_charset_1 a=k__wU0fu6RkA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=xKO94FZI0hc4bIEnGXcA:9 a=QEXdDO2ut3YA:10:nop_charset_2 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=fQyODqGSZKydQH01VRQyuvIsVSIS9CGmn+O9g7Ag8ic=; b=qgcUgYXNRXlfeZPyP0PrmsMYJi QMQy4TiHxJKNpnqp5u2W+i6oT3OV4tzWv6GLj74/LXtYm8bSLNBFeotjyVse/pcPI/SKt3LG342xo TfxSjVGWAsf0UTEvCD4wEoYxG; Received: from 71-211-185-113.hlrn.qwest.net ([71.211.185.113]:52788 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pbqKs-000u2m-UH for gdb-patches@sourceware.org; Mon, 13 Mar 2023 16:08:06 -0600 From: Tom Tromey Date: Mon, 13 Mar 2023 16:08:05 -0600 Subject: [PATCH 05/20] Reuse existing builtin types MIME-Version: 1.0 Message-Id: <20230313-split-objfile-type-allocator-2-v1-5-69ba773ac17b@tromey.com> References: <20230313-split-objfile-type-allocator-2-v1-0-69ba773ac17b@tromey.com> In-Reply-To: <20230313-split-objfile-type-allocator-2-v1-0-69ba773ac17b@tromey.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.1 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.185.113 X-Source-L: No X-Exim-ID: 1pbqKs-000u2m-UH X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-185-113.hlrn.qwest.net ([192.168.0.21]) [71.211.185.113]:52788 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3026.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" This changes a few spots to reuse the existing builting "void" type, rather than construct a new one. --- gdb/d-lang.c | 3 +-- gdb/f-lang.c | 3 +-- gdb/go-lang.c | 3 +-- gdb/jit.c | 5 +---- gdb/opencl-lang.c | 2 +- 5 files changed, 5 insertions(+), 11 deletions(-) diff --git a/gdb/d-lang.c b/gdb/d-lang.c index 8286c5be646..457e367fd51 100644 --- a/gdb/d-lang.c +++ b/gdb/d-lang.c @@ -201,8 +201,7 @@ build_d_types (struct gdbarch *gdbarch) struct builtin_d_type *builtin_d_type = new struct builtin_d_type; /* Basic types. */ - builtin_d_type->builtin_void - = arch_type (gdbarch, TYPE_CODE_VOID, TARGET_CHAR_BIT, "void"); + builtin_d_type->builtin_void = builtin_type (gdbarch)->builtin_void; builtin_d_type->builtin_bool = arch_boolean_type (gdbarch, 8, 1, "bool"); builtin_d_type->builtin_byte diff --git a/gdb/f-lang.c b/gdb/f-lang.c index 0d7863e4fd1..e1eb47577d6 100644 --- a/gdb/f-lang.c +++ b/gdb/f-lang.c @@ -1725,8 +1725,7 @@ build_fortran_types (struct gdbarch *gdbarch) { struct builtin_f_type *builtin_f_type = new struct builtin_f_type; - builtin_f_type->builtin_void - = arch_type (gdbarch, TYPE_CODE_VOID, TARGET_CHAR_BIT, "void"); + builtin_f_type->builtin_void = builtin_type (gdbarch)->builtin_void; builtin_f_type->builtin_character = arch_type (gdbarch, TYPE_CODE_CHAR, TARGET_CHAR_BIT, "character"); diff --git a/gdb/go-lang.c b/gdb/go-lang.c index bbf80af1f5c..456b74d80df 100644 --- a/gdb/go-lang.c +++ b/gdb/go-lang.c @@ -483,8 +483,7 @@ build_go_types (struct gdbarch *gdbarch) { struct builtin_go_type *builtin_go_type = new struct builtin_go_type; - builtin_go_type->builtin_void - = arch_type (gdbarch, TYPE_CODE_VOID, TARGET_CHAR_BIT, "void"); + builtin_go_type->builtin_void = builtin_type (gdbarch)->builtin_void; builtin_go_type->builtin_char = arch_character_type (gdbarch, 8, 1, "char"); builtin_go_type->builtin_bool diff --git a/gdb/jit.c b/gdb/jit.c index a93813b3f7f..b5386df2b46 100644 --- a/gdb/jit.c +++ b/gdb/jit.c @@ -571,10 +571,7 @@ finalize_symtab (struct gdb_symtab *stab, struct objfile *objfile) { struct block *new_block = new (&objfile->objfile_obstack) block; struct symbol *block_name = new (&objfile->objfile_obstack) symbol; - struct type *block_type = arch_type (objfile->arch (), - TYPE_CODE_VOID, - TARGET_CHAR_BIT, - "void"); + struct type *block_type = builtin_type (objfile->arch ())->builtin_void; new_block->set_multidict (mdict_create_linear (&objfile->objfile_obstack, NULL)); diff --git a/gdb/opencl-lang.c b/gdb/opencl-lang.c index ae1a6d4446d..9b5304f588f 100644 --- a/gdb/opencl-lang.c +++ b/gdb/opencl-lang.c @@ -941,7 +941,7 @@ class opencl_language : public language_defn add (arch_integer_type (gdbarch, gdbarch_ptr_bit (gdbarch), 0, "ptrdiff_t")); add (arch_integer_type (gdbarch, gdbarch_ptr_bit (gdbarch), 0, "intptr_t")); add (arch_integer_type (gdbarch, gdbarch_ptr_bit (gdbarch), 1, "uintptr_t")); - add (arch_type (gdbarch, TYPE_CODE_VOID, TARGET_CHAR_BIT, "void")); + add (builtin_type (gdbarch)->builtin_void); /* Type of elements of strings. */ lai->set_string_char_type (char_type);